- 01 9月, 2015 5 次提交
-
-
由 Rafael Mendonça França 提交于
Support MySQL 5.7.8 which enables show_compatibility_56=off
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
ArrayInquirer to correctly find symbols or strings
-
由 Sean Griffin 提交于
We are only supporting Ruby 2.2 and later in Rails 5, so we do not need an actual constant here. Additionally, referencing a constant actually does a hash lookup (because constants are not constant in Ruby >_>). This will be marginally (likely immeasurable) faster. It is less ugly.
-
由 Rafael Mendonça França 提交于
Silence callback deprecation warning if testing AJ
-
- 31 8月, 2015 3 次提交
-
-
由 claudiob 提交于
Currently the log returned by running ActiveJob tests is filled with: > DEPRECATION WARNING: Returning `false` in a callback will not implicitly halt a callback chain in the next release of Rails. To explicitly halt a callback chain, please use `throw :abort` instead. For instance, see https://travis-ci.org/rails/rails/builds/77978273 This happens because some setup and teardown methods [like these one](https://github.com/rails/rails/blob/master/activejob/test/cases/async_job_test.rb#L10-L17) invoke other methods like `perform_asynchronously!` that can return `false`, but not with the intention of halting the process if they do. In my opinion, these deprecation warnings can be silenced to have the log result cleaner (especially when browsing for errors).
-
由 Sean Griffin 提交于
[ci skip] Update what methods `Migration#change` can reverse
-
由 yui-knk 提交于
* Documentations and comments about what methods `Migration#change` can reverse is out of date. For example `change_column_default` is now reversible by this [commit](https://github.com/rails/rails/pull/20018). * Comments about `CommandRecorder` dose not match with Rails Guide. For example `add_foreign_key` is listed only on Rails Guide.
-
- 30 8月, 2015 7 次提交
-
-
由 Kasper Timm Hansen 提交于
fix typo in method name [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Sean Griffin 提交于
Make revert of `disable_extension` to work
-
由 Vijay Dev 提交于
-
由 yui-knk 提交于
This is fix of #11826 which miss to add `disable_extension` to `ReversibleAndIrreversibleMethods`. So `CommandRecorder#method_missing` catches `change_column_default` and @delegate's method is called.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 29 8月, 2015 9 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
References #19565.
-
由 yui-knk 提交于
-
由 Carlos Antonio da Silva 提交于
make `ENV` a required argument
-
由 yuuji.yaginuma 提交于
-
由 Rafael Mendonça França 提交于
Set the content-type to `text/html` if the options[:html] is true
-
由 Leigh Halliday 提交于
The problem existed where if your ArrayInquirer values were strings but you checked them using any? with a symbol, it would not find the value. Now it will correctly check whether both the String form or the Symbol form are included in the Array. `
-
由 akihiro17 提交于
In this commit, we set the content-type to `text/html` in AbstractController if the `options[:html]` is true so that we don't include ActionView::Rendering into ActionController::Metal to set it properly. I removed the if `options[:plain]` statement because `AbstractController#rendered_format` returns `Mime::TEXT` by default.
-
- 28 8月, 2015 16 次提交
-
-
由 Xavier Noria 提交于
* A string in the example lacked quotes. * The tests asserted stuff about :last_name, whereas test params do not have that key. * But, the first one passed, why? After hitting my head against the wall and doing some obscure rituals realized the new #require had an important typo, wanted to iterate over the array argument (key), but it ran over its own hash keys (method #keys). * Modified the test to prevent the same typo to happen again. * The second test assigned to an unused variable safe_params that has been therefore removed. * Grammar of the second test description. * Since I was on it, reworded both test descriptions.
-
由 Yves Senn 提交于
Closes #21418. Previously schema names were not quoted. This leads to issues when a schema names contains a ".". Methods in `schema_statements.rb` should quote user input.
-
由 Robin Dupret 提交于
-
由 Shivani 提交于
These changes rephrases the description with better explanation of step by step process.
-
由 Kasper Timm Hansen 提交于
[Feature] params.require accepts array of parameters that should be present or raise error
-
由 Gaurish Sharma 提交于
This PR adds ability to accept arrays which allows you to require multiple values in one method. so instead of this: ```ruby params.require(:person).require(:first_name) params.require(:person).require(:last_name) ``` Here it will be one line for each params, so say if I require 10params, it will be 10lines of repeated code which is not dry. So I have added new method which does this in one line: ```ruby params.require(:person).require([:first_name, :last_name]) ``` Comments welcome
-
由 Yves Senn 提交于
[ci skip] Currently the `#tables` method does not make use of the `name` argument and always returns all the tables in the schema search path. However the docs suggest different behavior. While we should porbably adjust the implementation to provide this behavior, let's make the docs right for now (also for `4-2-stable`) and then implement the behavior on `master`.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
fix reference to undefined variable in email testing guide [ci skip]
-
由 Konstantinos Rousis 提交于
-
由 Rafael Mendonça França 提交于
Support for custom regular expression for number_to_delimeted
-
由 Vipul A M 提交于
- Extracted `DELIMITED_REGEX` to `delimited_regex` method and made use of user passed `options[:delimited_regex]` if available. Changed `DELIMITED_REGEX` to `DEFAULT)DELIMITED_REGEX` to signify what it means. - Added tests for number to delimited and number to currency in both actionview and activesupport. Changes Changes
-
由 Guillermo Iguaran 提交于
Code cleanup
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
10X speed improvements for AS::Dependencies.loadable_constants_for_path
-
由 Claudio B. 提交于
Fix Configuring Active Record [ci skip]
-