- 26 11月, 2017 22 次提交
-
-
由 Matthew Draper 提交于
This reverts commit 536d3068.
-
由 Matthew Draper 提交于
Flush idle database connections
-
由 Matthew Draper 提交于
minor Engines guide copyedits: neutral language, verb tense, comma splice [ci skip]
-
-
-
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 yuuji.yaginuma 提交于
When load `5.1` config, `form_with_generates_remote_forms` is set. https://github.com/rails/rails/blob/89a209f1abba5a2320d31c4898dea150c0abd0c0/railties/lib/rails/application/configuration.rb#L86
-
由 Rafael França 提交于
Provide arguments to RecordNotFound
-
由 Rafael França 提交于
Fix names of http authentication modules in api only guides
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
form_with_generates_ids
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Own style guide says we should be using parentheses for method calls with arguments.
-
由 Nikita Misharin 提交于
-
由 Rafael Mendonça França 提交于
Allow skip_default_ids option to be set in form_with
-
由 Rafael França 提交于
Improved logging of AJ's DelayedJob wrapper
-
由 Rafael Mendonça França 提交于
When the defaults being loaded are the 5.0 or 5.1 we disable generation of ids with form_with.
-
由 npezza93 提交于
When `form_with` was introduced we disabled the automatic generation of ids that was enabled in `form_for`. This usually is not an good idea since labels don't work when the input doesn't have an id and it made harder to test with Capybara. You can still disable the automatic generation of ids setting `config.action_view.form_with_generates_ids` to `false.`
-
由 Rafael Mendonça França 提交于
Even that collisions are unlikely we need to make sure the two strings are equal. Timing is not important in this case because this only runs after the comparison between the SHA256 digested strings returns true.
-
由 Rafael Mendonça França 提交于
Make variable_size_secure_compare public
-
- 25 11月, 2017 12 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add :nodoc: to activerecord [ci skip]
-
由 Eileen M. Uchitelle 提交于
Ordinal methods should respect loaded records
-
由 Eileen M. Uchitelle 提交于
Update guide layout [ci skip]
-
由 Francis Go 提交于
-
由 Atul Shimpi 提交于
* [ci skip] SecureRandom should mentioned Win32 CryptoAPI functions instead of Win32 * Remove functions word
-
由 Matthew Draper 提交于
Improve AR connection fork safety
-
由 Rafael França 提交于
Rubocop style: Missing magic comment
-
由 Vipul A M 提交于
Update documentation to lead with ajax param `event.detail` [ci skip]
-
由 Dimitri Roche 提交于
-
由 Vipul A M 提交于
[ci skip] Rails Associations examples contains ActiveRecord::Base ref…
-
由 Vipul A M 提交于
Fix tld_length documentation in ActionDispatch::Cookies [ci skip]
-
由 Atul Shimpi 提交于
[ci skip] Rails Associations examples contains ActiveRecord::Base reference instead of ApplicationRecord in images
-
- 24 11月, 2017 4 次提交
-
-
由 Dixit Patel 提交于
-
由 Jacek Lachowski 提交于
ActiveJob wraps every adapter into its own class, that is later passed into DelayedJob which is responsible for displaying all the logs. This change improves the logging so we can easily trace executed jobs and see meaningful information in the logs.
-
由 Avneet Singh Malhotra 提交于
Correct render method's response header's content type for option(:body) from text/html to text/plain. (#31212)
-
由 George Claghorn 提交于
-
- 23 11月, 2017 2 次提交
-
-
由 Ryuta Kamizono 提交于
Fix unstable test test_delegate_socket_errors_to_on_error_handler
-
由 Fumiaki MATSUSHIMA 提交于
I often face the following error when running test/connection/client_socket_test.rb: ``` $ bin/test test/connection/client_socket_test.rb:38 Run options: --seed 44035 # Running: F Failure: ActionCable::Connection::ClientSocketTest#test_delegate_socket_errors_to_on_error_handler [/app/actioncable/test/connection/client_socket_test.rb:47]: --- expected +++ actual @@ -1 +1 @@ -["foo"] +["Broken pipe", "Broken pipe", "Broken pipe", "foo"] ``` It can be reproduced easily by applying the following patch: ``` diff --git a/actioncable/test/connection/client_socket_test.rb b/actioncable/test/connection/client_socket_test.rb index 2051216010..6bb9f13ea7 100644 --- a/actioncable/test/connection/client_socket_test.rb +++ b/actioncable/test/connection/client_socket_test.rb @@ -34,7 +34,8 @@ def on_error(message) @server.config.allowed_request_origins = %w( http://rubyonrails.com ) end - test "delegate socket errors to on_error handler" do + 1000.times do |i| + test "delegate socket errors to on_error handler #{i}" do run_in_eventmachine do connection = open_connection @@ -47,6 +48,7 @@ def on_error(message) assert_equal %w[ foo ], connection.errors end end + end test "closes hijacked i/o socket at shutdown" do run_in_eventmachine do ``` The cause is writing io from different thread at the same time. `connection.process` sends handshake message from [StreamEventLoop's thread][] whereas `connection.handle_open` sends welcome message from current thread. [StreamEventLoop's thread]: https://github.com/rails/rails/blob/067fc779c4560fff4812614a2f78f9248f3e55f8/actioncable/lib/action_cable/connection/stream_event_loop.rb#L75
-