1. 07 2月, 2015 1 次提交
    • X
      Remove documentation tasks · cd7cc525
      Xavier Noria 提交于
      This patch removes the tasks doc:app, doc:rails, and doc:guides.
      
      In our experience applications do not generate APIs using doc:app.
      Methods may be certainly documented for maintainers, annotated
      with YARD tags, etc. but that is intended to be read with the
      source code, not in a separate website. Then, teams also have
      typically selected topics written down in Markdown files, or in
      a GitHub wiki... that kind of thing.
      
      If a team absolutely needs to generate application documentation
      for internal purposes, they can still easily write their own task.
      
      Regarding doc:rails and doc:guides, we live in 2015. We are used
      to go to online docs all the time. If you really want access to the
      API offline RubyGems generates it for every Rails component unless
      you tell it not to, and you can checkout the Rails source code to
      read the guides as Markdown, or download them for a Kindle reader.
      
      All in all, maintaining this code does not seem to be worthwhile
      anymore.
      
      As a consequence of this, guides (+3 MB uncompressed) won't be
      distributed with the rails gem anymore. Of course, guides and API
      are going to be still part of releases, since documentation is
      maintained alongside code and tests.
      
      Also, time permitting, this will allow us to experiment with novel
      ways to generate documentation in the Rails docs server, since
      right now we were constrained by being able to generate them in
      the user's environment.
      cd7cc525
  2. 06 2月, 2015 1 次提交
    • A
      Force generated route to be inserted · 80838d9b
      Andrew White 提交于
      Thor isn't very discerning over whether some content is present when passed
      to `inject_into_file`, e.g. a commented out route is detected as being present.
      So to prevent people scratching their heads as to why a route hasn't appeared
      it's better to fall on the side of having duplicate routes.
      80838d9b
  3. 04 2月, 2015 1 次提交
    • A
      Don't remove all line endings from routes.rb · 1c59ffca
      Andrew White 提交于
      When there is a single scaffold in the routes.rb with no other lines
      then revoking/destroying it will create a routes.rb file with a syntax
      error. This is because the sentinel for the Thor `route` action didn't
      include the newline but the logged route code did.
      
      The fix is to add the newline to the sentinel and remove it from the
      the logged route code.
      
      Fixes #15913.
      1c59ffca
  4. 31 1月, 2015 1 次提交
  5. 30 1月, 2015 4 次提交
  6. 28 1月, 2015 2 次提交
  7. 21 1月, 2015 1 次提交
    • V
      - Extracted silence_stream method to new module in activesupport/testing. · 166ce95f
      Vipul A M 提交于
      - Added include for the same in ActiveSupport::Test.
      - Removed occurrences of silence_stream being used elsewhere.
      - Reordered activesupport testcase requires alphabetically.
      
      - Removed require of silence stream from test_case
      
      - Moved quietly method to stream helper
      
      - Moved capture output to stream helper module and setup requires for the same elsewhere
      166ce95f
  8. 14 1月, 2015 1 次提交
  9. 12 1月, 2015 1 次提交
  10. 10 1月, 2015 1 次提交
  11. 09 1月, 2015 1 次提交
  12. 06 1月, 2015 1 次提交
  13. 05 1月, 2015 1 次提交
  14. 04 1月, 2015 3 次提交
  15. 03 1月, 2015 2 次提交
    • P
    • C
      Add config to halt callback chain on return false · 9c65c539
      claudiob 提交于
      This stems from [a comment](rails#17227 (comment)) by @dhh.
      In summary:
      
      * New Rails 5.0 apps will not accept `return false` as a way to halt callback chains, and will not display a deprecation warning.
      * Existing apps ported to Rails 5.0 will still accept `return false` as a way to halt callback chains, albeit with a deprecation warning.
      
      For this purpose, this commit introduces a Rails configuration option:
      
      ```ruby
      config.active_support.halt_callback_chains_on_return_false
      ```
      
      For new Rails 5.0 apps, this option will be set to `false` by a new initializer
      `config/initializers/callback_terminator.rb`:
      
      ```ruby
      Rails.application.config.active_support.halt_callback_chains_on_return_false = false
      ```
      
      For existing apps ported to Rails 5.0, the initializers above will not exist.
      Even running `rake rails:update` will not create this initializer.
      
      Since the default value of `halt_callback_chains_on_return_false` is set to
      `true`, these apps will still accept `return true` as a way to halt callback
      chains, displaying a deprecation warning.
      
      Developers will be able to switch to the new behavior (and stop the warning)
      by manually adding the line above to their `config/application.rb`.
      
      A gist with the suggested release notes to add to Rails 5.0 after this
      commit is available at https://gist.github.com/claudiob/614c59409fb7d11f2931
      9c65c539
  16. 02 1月, 2015 5 次提交
  17. 30 12月, 2014 1 次提交
  18. 23 12月, 2014 4 次提交
    • S
      Add test missed by a03ea684 · b7d7e0b1
      Sean Griffin 提交于
      b7d7e0b1
    • S
      Use the new `foreign_key` option on `references` in generators · a03ea684
      Sean Griffin 提交于
      Changes `rails g model Post user:references` from
      
          def change
            create_table :posts do |t|
              t.references :user, index: true
            end
      
            add_foreign_key :posts, :users
          end
      
      to
      
          def change
            create_table :posts do |t|
              t.references :user, index: true, foreign_key: true
            end
          end
      
      Changes `rails g migration add_user_to_posts user:references` from
      
          def change
            add_reference :posts, :users, index: true
            add_foreign_key :posts, :users
          end
      
      to
      
          def change
            add_reference :posts, :users, index: true, foreign_key: true
          end
      a03ea684
    • S
      Skip byebug on all non-MRI rubies, fix tests · 9fff631a
      Sean Griffin 提交于
      The changes in #18149 added tests for the app generator, but only fixed
      it for the plugin generator (I should have let CI finish though I think
      it would have failed as an allowed failure).
      9fff631a
    • A
      Only add debugger/byebug if on MRI · 0bb73f03
      Arthur Neves 提交于
      0bb73f03
  19. 14 12月, 2014 1 次提交
  20. 07 12月, 2014 1 次提交
  21. 02 12月, 2014 1 次提交
  22. 27 11月, 2014 1 次提交
  23. 26 11月, 2014 1 次提交
    • D
      Generators add foreign keys on references · 323334a7
      Derek Prior 提交于
      If you run a generator such as:
      
      ```
      rails generate model accounts supplier:references
      ```
      
      The resulting migration will now add the corresponding foreign key
      constraint unless the reference was specified to be polymorphic.
      323334a7
  24. 25 11月, 2014 2 次提交
  25. 22 11月, 2014 1 次提交