- 24 6月, 2017 4 次提交
-
-
由 Kasper Timm Hansen 提交于
Removed reference to unexisting methods:
-
由 Ryuta Kamizono 提交于
Guides: Clarify partial local variable naming. [ci skip]
-
由 Yong Bakos 提交于
Clarify the partial local variable name as being the same as the name of the partial, minus the _leading_ underscore.
-
由 Edouard CHIN 提交于
`get/post_via_redirect`, `xhr` and his alias `xml_http_request` were respectively removed in 092033d5 and eb52e5d4
-
- 23 6月, 2017 2 次提交
-
-
由 Ryuta Kamizono 提交于
Fix typo in `AC::UnfilteredParameters` message [ci skip]
-
- 22 6月, 2017 8 次提交
-
-
由 Eileen M. Uchitelle 提交于
Do not use private API in bug report templates
-
由 Ryuta Kamizono 提交于
Fix hash conditions documentation
-
由 Kasper Timm Hansen 提交于
Remove unused variable
-
由 Abraham Chan 提交于
-
由 yuuji.yaginuma 提交于
This fixes the following warnings: ``` activerecord/test/cases/relation_test.rb:231: warning: assigned but unused variable - authors_with_commented_posts ```
-
由 yuuji.yaginuma 提交于
`ActiveRecord::Migrator` is private API. https://github.com/rails/rails/blob/bb9d6eb094f29bb94ef1f26aa44f145f17b973fe/activerecord/lib/active_record/migration.rb#L977 Therefore, it is not good to use it in bug report templates. Instead, should use the public API `ActiveRecord::Migration#migrate`.
-
由 Rafael França 提交于
Avoid begin/rescue in fixture quoting
-
由 Rafael França 提交于
Keep INNER JOIN when merging relations
-
- 21 6月, 2017 12 次提交
-
-
由 Kir Shatrov 提交于
Scalar values like arrays and hashes can't be inserted directly into table. Previously, the way to determine if the value is scalar was to try quoting it. If `quote` raised with an error than the value has to be converted to YAML. This flow is not very obvious. Ideally we could have a `quotable?` method in the connection, but I think that we can avoid begin/rescue block by simply checking if the value is Array or Hash. https://github.com/rails/rails/commit/aa31d21f5f4fc4d679e74a60f9df9706da7de373
-
由 Ryuta Kamizono 提交于
Fixes #29512.
-
由 Maxime Lapointe 提交于
Doing `Author.joins(:posts).merge(Post.joins(:comments))` does this `SELECT ... INNER JOIN posts ON... LEFT OUTER JOIN comments ON...` instead of doing `SELECT ... INNER JOIN posts ON... INNER JOIN comments ON...`. This behavior is unexpected and makes little sense as, basically, doing `Post.joins(:comments)` means I want posts that have comments. Turning it to a LEFT JOIN means I want posts and join the comments data, if any. We can see this problem directly in the existing tests. The test_relation_merging_with_merged_joins_as_symbols only does joins from posts to comments to ratings while the ratings fixture isn't loaded, but the count is non-zero.
-
由 Rafael França 提交于
Fix ActiveRecord::Persistence#touch with locking
-
由 bogdanvlviv 提交于
`ActiveRecord::Persistence#touch` does not work well when optimistic locking enabled and `locking_column`, without default value, is null in the database.
-
由 Rafael França 提交于
Fix destroy with locking_column value null
-
由 bogdanvlviv 提交于
Fix destroying existing object does not work well when optimistic locking enabled and `locking column` is null in the database. Follow 22a822e5, #28914
-
由 Rafael França 提交于
Updates README on rails internal dev tools
-
由 Marc Ignacio 提交于
... and minor typo fix
-
由 Rafael França 提交于
Use bulk INSERT to insert fixtures
-
由 Kir Shatrov 提交于
Improves the performance from O(n) to O(1). Previously it would require 50 queries to insert 50 fixtures. Now it takes only one query. Disabled on sqlite which doesn't support multiple inserts.
-
由 Akira Matsuda 提交于
-
- 20 6月, 2017 14 次提交
-
-
由 Rafael França 提交于
Fix current_page? helper issue with engine root path
-
由 Rafael França 提交于
Add test cases for optimistic locking
-
由 Prathamesh Sonpatki 提交于
-
由 Rafael França 提交于
prepare for Minitest 6
-
由 utilum 提交于
-
由 Rafael França 提交于
Use of ParameterFilter no longer forces `request.filtered_parameters' class to be Hash
-
由 savroff 提交于
fix fix
-
由 savroff 提交于
-
由 Rafael França 提交于
nodoc AC::Connection::WebSocket
-
由 Rafael França 提交于
Fix `Relation#exists?` queries with query cache
-
由 Rafael França 提交于
Prevent extra `scope` construction in `find_target`
-
由 Rafael França 提交于
Refactor #insert_fixtures to use Arel
-
由 Rafael França 提交于
Deprecate an `capify!` method in generators and templates
-
由 Kir Shatrov 提交于
-