- 06 4月, 2015 1 次提交
-
-
由 Stephen Bussey 提交于
-
- 05 4月, 2015 1 次提交
-
-
由 Robin Dupret 提交于
-
- 02 4月, 2015 2 次提交
-
-
由 brainopia 提交于
-
由 brainopia 提交于
https://github.com/ruby/ruby/pull/579 - there is a new optimization since ruby 2.2 Previously regexp patterns were faster (since a string was converted to regexp underneath anyway). But now string patterns are faster and better reflect the purpose. Benchmark.ips do |bm| bm.report('regexp') { 'this is ::a random string'.gsub(/::/, '/') } bm.report('string') { 'this is ::a random string'.gsub('::', '/') } bm.compare! end # string: 753724.4 i/s # regexp: 501443.1 i/s - 1.50x slower
-
- 28 3月, 2015 2 次提交
-
-
由 Shuhei Kagawa 提交于
The current implementation of ActionController::Parameters.const_missing returns `ActionController::Parameters.always_permitted_parameters` even if its `super` returns a constant without raising error. This prevents its subclass in a autoloading module/class from taking advantage of autoloading constants. class SomeParameters < ActionController::Parameters def do_something DefinedSomewhere.do_something end end In the code above, `DefinedSomewhere` is to be autoloaded with `Module.const_missing` but `ActionController::Parameters.const_missing` returns `always_permitted_parameters` instead of the autoloaded constant. This pull request fixes the issue respecting `const_missing`'s `super`.
-
由 Rafael Mendonça França 提交于
setup as block run before setup actlually runs so it will fail for our case
-
- 25 3月, 2015 3 次提交
-
-
由 Arthur Neves 提交于
-
由 George Claghorn 提交于
Wrapping an array in an `ArrayInquirer` gives a friendlier way to check its string-like contents. For example, `request.variant` returns an `ArrayInquirer` object. To check a request's variants, you can call: request.variant.phone? request.variant.any?(:phone, :tablet) ...instead of: request.variant.include?(:phone) request.variant.any? { |v| v.in?([:phone, :tablet]) } `Array#inquiry` is a shortcut for wrapping the receiving array in an `ArrayInquirer`: pets = [:cat, :dog] pets.cat? # => true pets.ferret? # => false pets.any?(:cat, :ferret} # => true
-
由 George Claghorn 提交于
Closes #18933.
-
- 23 3月, 2015 3 次提交
-
-
由 Andrew White 提交于
-
由 Ryan Tomayko 提交于
The status returned in the rack [status, headers, body] array was a string, which can cause problems with middleware that assumes the status will be a Fixnum. This likely never surfaced because other middleware to_i the status returned from downstream apps before passing it on.
-
由 Gaurav Sharma 提交于
-
- 21 3月, 2015 1 次提交
-
-
由 adam 提交于
Previously, an empty X_FORWARDED_HOST header would cause Actiondispatch::Http:URL.raw_host_with_port to return nil, causing Actiondispatch::Http:URL.host to raise a NoMethodError.
-
- 20 3月, 2015 3 次提交
-
-
由 Jeremy Kemper 提交于
Preserving RACK_ENV behavior. This reverts commit 7bdc7635, reversing changes made to 45786be5.
-
由 eileencodes 提交于
ActionDispatch::IntegrationTest HTTP request methods will accept only certain kwargs in the future. This test caused a deprecation warning when running ActionPack tests. Added `params` and `headers` to fix.
-
由 Akshay Vishnoi 提交于
-
- 19 3月, 2015 1 次提交
-
-
由 Damien Mathieu 提交于
-
- 16 3月, 2015 1 次提交
-
-
由 Boris Peterbarg 提交于
Regexp is broken for both content types including charsets and for integration tests, where the content_type is a Mime::Type and not String
-
- 15 3月, 2015 1 次提交
-
-
由 Mike Naberezny 提交于
-
- 13 3月, 2015 1 次提交
-
-
由 Joel Hayhurst 提交于
It was returning false in normal circumstances. This broke the `head :ok and return if` construct. Add appropriate test.
-
- 12 3月, 2015 2 次提交
-
-
由 Brian John 提交于
As of the upgrade to Rack 1.5, request.session_options[:id] is no longer populated. Reflect this change in the tests by using request.session.id instead. Related change in Rack: https://github.com/rack/rack/commit/83a270d6
-
由 Kohei Suzuki 提交于
-
- 11 3月, 2015 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Prevents double escaping errors, such as "&" becoming "&amp;".
-
- 10 3月, 2015 3 次提交
-
-
由 Kohei Suzuki 提交于
Rack::Lint raises an error saying "Content-Type header found in 304 response, not allowed".
-
由 eileencodes 提交于
This fixes the reasons 4cf3b8ac, 303567e5, and fa634484 needed to be reverted in 71420598. The revert has been reverted and this fixes the issues caused previously. If we call `super` first we will end up nuking the session settings in the application tests that do `setup do` - so any session login or cookie settings will not be persisted thoughout the test sessions. Calling `super` last prevents `@integration_session` from getting nuked and set to nil if it's already set. Test added to prevent regression of this behavior in the future.
-
由 eileencodes 提交于
This reverts commit 71420598.
-
- 09 3月, 2015 1 次提交
-
-
由 Peter Suschlik 提交于
This is a follow-up to #19257
-
- 07 3月, 2015 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 06 3月, 2015 5 次提交
-
-
由 Prathamesh Sonpatki 提交于
- The request needs to be instance of ActionDispatch::Request or an object that responds to host, optional_port, protocol and symbolized_path_parameter. - This documentation was correctly added in https://github.com/rails/rails/commit/e3b3f416b57f5642ea25078485f7e9394ad04526 but was changed to https://github.com/rails/rails/commit/e1ceae576e3911f3e6708b5d19a0e3ef63769eb7. - Fixes #16160.
-
由 Aaron Patterson 提交于
This way we can get the relative_url_root from the application without setting another global value
-
由 Matthew Draper 提交于
This reverts commit 7025d776.
-
-
由 Guo Xiang Tan 提交于
-
- 05 3月, 2015 5 次提交
-
-
由 Genadi Samokovarov 提交于
The bug caused a segfault and you can find more info about it at: https://bugs.ruby-lang.org/issues/10685. We did a couple of work arounds, but 2.2.1 rolled out and those aren't needed anymore. Here are the reverted commits: - Revert "Work around for upstream Ruby bug #10685", commit 707a4338. - Revert "Fix segmentation fault in ActionPack tests", commit 22e0a22d. I'm also bumping the Ruby version check to 2.2.1 to prevent future segfaults.
-
-
-
-
由 Aaron Patterson 提交于
If you would like to use a custom request class, please subclass and implemet the `request_class` method.
-
- 04 3月, 2015 1 次提交
-
-
由 Robin Dupret 提交于
-
- 03 3月, 2015 1 次提交
-
-
由 Anton Davydov 提交于
-