- 15 11月, 2019 8 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up of #35280. If a model has default scopes, vanilla `klass.all` is not the same with `klass.unscoped`. In that case, we should use `klass.default_scoped` instead.
-
由 John Hawthorn 提交于
Fix yarn issues on CI
-
由 Ryuta Kamizono 提交于
Update a tag for missing <dl> in guides
-
由 Takayuki Nakata 提交于
The errors below heppens in executing `bundle exec rake guides:validate`. ``` $ bundle exec rake guides:generate:html (snip) $ bundle exec rake guides:validate (snip) ./output/active_record_querying.html has 57 validation error(s): ERROR; line 55: Element “dt” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) (snip) ```
-
由 John Hawthorn 提交于
We want to yarn install in the template dir so that templates get a yarn.lock copied over.
-
由 John Hawthorn 提交于
The app template is in a higher-level directory than test/isolation/assets, so these paths wern't accurate.
-
由 John Hawthorn 提交于
-
由 John Hawthorn 提交于
-
- 14 11月, 2019 13 次提交
-
-
由 Ryuta Kamizono 提交于
Add `HTTP Token authentication` section to guide [skip ci]
-
由 Ryuta Kamizono 提交于
Remove unused require
-
由 Takayuki Nakata 提交于
`extract` was removed at 0fa8c0a1
-
由 Ryuta Kamizono 提交于
Remove Resolver autoload
-
由 John Crepezzi 提交于
This class has been removed in #37695 but I just noticed this lingering around while doing some other work!
-
由 Gannon McGibbon 提交于
Fix ActiveStorage::Blob#service method redefined warning
-
由 Gannon McGibbon 提交于
-
由 John Hawthorn 提交于
Fix undefined method `start_with?' for :to_json
-
由 John Hawthorn 提交于
-
由 Ryuta Kamizono 提交于
Relocate require in AS::Deprecation
-
由 Ryuta Kamizono 提交于
rubocop-performance v1.5.1 includes bug fixes for that cops. https://github.com/rubocop-hq/rubocop-performance/releases/tag/v1.5.1
-
由 Ryuta Kamizono 提交于
It is a part of `env.delete_if { |k, v| k.match?(/^(action_dispatch|rack)\.request/) }`.
-
由 Peter Wagenet 提交于
Without this, it's possible to encounter: NoMethodError: undefined method `on_jruby?' for Concurrent:Module See also https://github.com/ruby-concurrency/concurrent-ruby/pull/833
-
- 13 11月, 2019 5 次提交
-
-
由 Eileen M. Uchitelle 提交于
Remove ConnectionAdapters::Resolver in favor of DatabaseConfigurations
-
由 soartec-lab 提交于
-
由 John Crepezzi 提交于
We have these two objects, `ConnectionAdapters::Resolver` and `DatabaseConfiguratons` that implement a lot of the same logic. One of them is used for configurations defined in `config/database.yml` and the other is used when passing raw configurations `String` or `Hash` objects into methods like `establish_connection`. Over time these two have diverged a bit. In the interest of less code complexity, and more consistency for users this commit brings them back together. * Remove `Resolver` altogether and replace its primary method with `DatabaseConfigurations#resolve`. * Move `resolve_pool_config` over to the `ConnectionPool` alongside the code that uses it.
-
由 Ryuta Kamizono 提交于
Add missing require for Concurrent::ThreadLocalVar
-
由 Peter Wagenet 提交于
Fixes #37697
-
- 11 11月, 2019 9 次提交
-
-
由 Kasper Timm Hansen 提交于
Simplify dangerous_class_method?
-
由 Kasper Timm Hansen 提交于
Closes #37595
-
由 bogdanvlviv 提交于
I changed `load_defaults` to `config.load_defaults` in the guide to emphasize its context, sorted headers "With 'x.x'" in descending and rephrased them to "With 'x.x', it includes previous versions' new defaults" and documented the method on https://api.rubyonrails.org.
-
由 Kasper Timm Hansen 提交于
Closes #37496
-
由 Tim Masliuchenko 提交于
-
由 Kasper Timm Hansen 提交于
Update form examples [ci skip]
-
由 Kasper Timm Hansen 提交于
Additionally order by primary key if implicit_order_column is not uniq
-
由 Xavier Noria 提交于
Fix inconsistent capitalization of Article in getting started
-
由 Vincent Voyer 提交于
In the getting started, we're asked to add `"<h1>New Article</h1>"` while later on in the guide it is referenced as `"<h1>New article</h1>"` This pull request aims at fixing this small inconsistency. [ci skip]
-
- 10 11月, 2019 5 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
That was accidentally added at e5d9ad3e.
-