Changed the default value for the options argument on ActiveRecord::ConnectionAdapters::Table#column_exists? from nil to an empty Hash {}.

That method calls through to ActiveRecord::ConnectionAdapters::SchemaStatements##column_exists? expects options to be a Hash.

When options was nil, an error would occur in cases where the column did exist because the called method attempted to perform a key lookup on options.

* Changes should better reflect present code behavior
* Related to issue: https://github.com/rails/rails/issues/1624

This will hopefully make Active Record run a bit more faster.

This will hopefully make Active Record run a bit more faster.

[#4219 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#4596 state:resolved]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

This reverts commit 6626833d.

This commit breaks dumping a few tables, as the sessions table.
To reproduce, just create a new application and:

  rake db:sessions:create
  rake db:migrate
  rake db:test:prepare

And then look at the db/schema.rb file (ht: Sam Ruby).

This reverts commit 5b95730e.

Example:

  add_index(:accounts, :name, :name => 'by_name', :length => 10)
  => CREATE INDEX by_name ON accounts(name(10))

  add_index(:accounts, [:name, :surname], :name => 'by_name_surname', :length => {:name => 10, :surname => 15})
  => CREATE INDEX by_name_surname ON accounts(name(10), surname(15))
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NEmilio Tagua <miloops@gmail.com>

To reproduce, start a new application, create a scaffold and run test suite. [#876 state:open]

This reverts commit faeca694.

Signed-off-by: Nwycats <wycats@gmail.com>

This reverts commit 41e5c7ed.

Signed-off-by: Nwycats <wycats@gmail.com>

This reverts commit 717a2941. Bunch of failures when running postgresql tests.

* Use direct integer parsing in #fast_string_to_time to avoid convoluted
   conversions and errors due to truncation.
 * Use Float#round in #microseconds to avoid truncation errors.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>