- 06 9月, 2012 1 次提交
-
-
由 Ian Lesperance 提交于
-
- 05 9月, 2012 2 次提交
-
-
由 Adam Meehan 提交于
The string_to_dummy_time method was blindly parsing the dummy time string with Date._parse which returns a hash for the date part regardless of whether the time part is an invalid time string.
-
由 Konstantin Shabanov 提交于
-
- 03 9月, 2012 1 次提交
-
-
由 Yves Senn 提交于
I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
-
- 01 9月, 2012 1 次提交
-
-
由 Jon Leighton 提交于
This is purely a performance optimisation. See https://gist.github.com/3552829
-
- 31 8月, 2012 5 次提交
-
-
由 Jon Leighton 提交于
This is a performance/GC optimisation. In theory, this could be optimised by the implementation (last time I checked, this would have no effect on JRuby). But in practise, this make attribute access faster.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
We don't need separate @class_to_pool and @connection_pool hashes.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
* Loop rather than recurse in retrieve_connection_pool * Key the hash by class rather than class name. This avoids creating unnecessary strings.
-
- 30 8月, 2012 4 次提交
-
-
由 Xavier Noria 提交于
-
由 Jo Liss 提交于
-
由 Jo Liss 提交于
Per https://github.com/lifo/docrails/commit/e94e8d8c3fcac624466afcf61f6a118abe5a6af4#commitcomment-1784677 Thanks @randomecho! This reverts commit e94e8d8c.
-
由 Jo Liss 提交于
-
- 26 8月, 2012 4 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit 7a8aee08.
-
由 Rafael Mendonça França 提交于
This reverts commit a7f4b0a1. Conflicts: activerecord/lib/active_record/associations/has_one_association.rb activerecord/lib/active_record/persistence.rb activerecord/test/cases/base_test.rb activerecord/test/cases/dirty_test.rb activerecord/test/cases/timestamp_test.rb
-
由 Mikhail Dieterle 提交于
-
- 25 8月, 2012 3 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Prem Sichanugrist 提交于
This functionality will be available from gem `active_record-session_store` instead.
-
- 24 8月, 2012 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Isaac Sanders 提交于
This is a cleaner version of #6916. Closes #3165.
-
- 23 8月, 2012 1 次提交
-
-
由 David Celis 提交于
I've noticed a caveat with the :autosave option biting people before. Questions arise about why they must explicitly save an associated object in their own before_save callbacks. I've updated the documentation as such to note to users that the :autosave callback occurs before any user defined callbacks. They must save the associated record themselves if altering it in their own callbacks. Signed-off-by: NDavid Celis <david@davidcelis.com>
-
- 22 8月, 2012 3 次提交
-
-
由 José Valim 提交于
The new option allows any Ruby namespace to be registered and set up for eager load. We are effectively exposing the structure existing in Rails since v3.0 for all developers in order to make their applications thread-safe and CoW friendly.
-
由 Dave Desrochers 提交于
reset_counters() was crashing when there were multiple belongs_to associations with the same foreign key. This closes #5200.
-
由 kennyj 提交于
-
- 21 8月, 2012 8 次提交
-
-
由 kennyj 提交于
-
由 kennyj 提交于
-
由 Carlos Antonio da Silva 提交于
* Use each_key instead of generating intermediate keys array. * Use each_with_object instead of inject to build hash. * Use ternary to return instead of if + assignment.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 20 8月, 2012 1 次提交
-
-
由 Carlos Antonio da Silva 提交于
This method was added to be shared between update_attribute and update_column in 50725cec, but since update_attribute was removed, and update_column has changed to delegate to update_columns, the method is not used anywhere anymore. Also remove "key.to_s" conversion when raising readonly error, since the key is being interpolated.
-
- 19 8月, 2012 1 次提交
-
-
由 Ernie Miller 提交于
This is a real fix (as compared to the band-aid in b127d86c), which uses the recently-added equality methods for ARel nodes. It has the side benefit of simplifying the merge code a bit.
-
- 18 8月, 2012 3 次提交
-
-
由 brainopia 提交于
-
由 Carlos Antonio da Silva 提交于
Cleans up a lot of noise from arguments being passed from one method to another.
-
由 Carlos Antonio da Silva 提交于
This should make it easier to refactor and improve this code, and remove complexity with params going around here and there.
-