- 02 11月, 2016 5 次提交
-
-
由 Sean Griffin 提交于
With the changes in #25337, double save bugs are pretty much impossible, so we can just lift this restriction with pretty much no change. There were a handful of cases where we were relying on specific quirks in tests that had to be updated. The change to has_one associations was due to a particularly interesting test where an autosaved has_one association was replaced with a new child, where the child failed to save but the test wanted to check that the parent id persisted to `nil`. I think this is almost certainly the wrong behavior, and I may change that behavior later. But ultimately the root cause was because we never remove the parent in memory when nullifying the child. This makes #23197 no longer needed, but it is what we'll do to fix some issues on 5.0 Close #23197
-
由 Sean Griffin 提交于
Deprecate the behavior of AR::Dirty inside of after_(create|update|save) callbacks
-
由 Sean Griffin 提交于
We pretty frequently get bug reports that "dirty is broken inside of after callbacks". Intuitively they are correct. You'd expect `Model.after_save { puts changed? }; model.save` to do the same thing as `model.save; puts model.changed?`, but it does not. However, changing this goes much farther than just making the behavior more intuitive. There are a _ton_ of places inside of AR that can be drastically simplified with this change. Specifically, autosave associations, timestamps, touch, counter cache, and just about anything else in AR that works with callbacks have code to try to avoid "double save" bugs which we will be able to flat out remove with this change. We introduce two new sets of methods, both with names that are meant to be more explicit than dirty. The first set maintains the old behavior, and their names are meant to center that they are about changes that occurred during the save that just happened. They are equivalent to `previous_changes` when called outside of after callbacks, or once the deprecation cycle moves. The second set is the new behavior. Their names imply that they are talking about changes from the database representation. The fact that this is what we really care about became clear when looking at `BelongsTo.touch_record` when tests were failing. I'm unsure that this set of methods should be in the public API. Outside of after callbacks, they are equivalent to the existing methods on dirty. Dirty itself is not deprecated, nor are the methods inside of it. They will only emit the warning when called inside of after callbacks. The scope of this breakage is pretty large, but the migration path is simple. Given how much this can improve our codebase, and considering that it makes our API more intuitive, I think it's worth doing.
-
由 Arthur Neves 提交于
-
由 Rafael Fidelis 提交于
fixing @generators var initialization pre initializing variables values Changing from var init to symbol to instance var get/set
-
- 01 11月, 2016 3 次提交
-
-
由 Kasper Timm Hansen 提交于
fix typo in Rails Test Runner section
-
由 colleenmcguckin 提交于
-
由 Andrew White 提交于
Previously `ActiveSupport::Duration.parse` used `Time.current` and `Time#advance` to calculate the number of seconds in the duration from an arbitrary collection of parts. However as `advance` tries to be consistent across DST boundaries this meant that either the duration was shorter or longer depending on the time of year. This was fixed by using an absolute reference point in UTC which isn't subject to DST transitions. An arbitrary date of Jan 1st, 2000 was chosen for no other reason that it seemed appropriate. Additionally, duration parsing should now be marginally faster as we are no longer creating instances of `ActiveSupport::TimeWithZone` every time we parse a duration string. Fixes #26941.
-
- 31 10月, 2016 11 次提交
-
-
由 Guillermo Iguaran 提交于
allow ActiveRecord::Core#slice to use array arg
-
由 Cohen Carlisle 提交于
-
由 Arthur Nogueira Neves 提交于
Fix the order of `create_table` to match a comment about `:inverse_of…
-
由 प्रथमेश Sonpatki 提交于
Remove `Rack::Runtime from console log [ci skip]
-
由 Shia 提交于
-
由 Andrew White 提交于
remove warning from big integer test
-
由 Guillermo Iguaran 提交于
Add missing space in Migrations guide [ci skip]
-
由 Benny 提交于
-
由 yui-knk 提交于
These comment sometimes explain a face which does not match the face.
-
由 yui-knk 提交于
In ActiveRecord test :men, :faces, :interests and :zines tables are used for `:inverse_of` test cases, not `:wheels`.
-
由 yuuji.yaginuma 提交于
This removes the following warnings. ``` activemodel/test/cases/type/big_integer_test.rb:15: warning: ambiguous first argument; put parentheses or a space even after `-' operator ```
-
- 30 10月, 2016 2 次提交
-
-
由 Jon Moss 提交于
update doc about assets digest class [ci skip]
-
由 yuuji.yaginuma 提交于
The default digest class changed to SHA256 in sprockets 3.0. Ref: https://github.com/sstephenson/sprockets/pull/647
-
- 29 10月, 2016 8 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Support plain loggers in DebugExceptions
-
由 Rafael Mendonça França 提交于
This reverts commit aaf561d2, reversing changes made to 83776676. Reason: It is not a good idea to connect to the database on generators
-
由 Matthew Draper 提交于
-
由 Arthur Neves 提交于
Fix for has_and_belongs_to_many & has_many_through associations
-
由 Arthur Nogueira Neves 提交于
Dynamically show available sql types [ci skip]
-
由 Genadi Samokovarov 提交于
I have been seeing people setting `Logger` instances for `config.logger` and it blowing up on `rails/web-console` usage. Now, I doubt many folks are manually setting `ActionView::Base.logger`, but given that `DebugExceptions` is running in a pretty fragile environment already, having it crash (and being silent) in those cases can be pretty tricky to trace down. I'm proposing we verify whether the `ActionView::Base.logger` supports silencing before we try to do it, to save us the headache of tracing it down.
-
由 Kasper Timm Hansen 提交于
They're just barren on the site and confure more than guide, instead rely on the built in --help to guide users.
-
- 28 10月, 2016 11 次提交
-
-
由 Kasper Timm Hansen 提交于
Remove unnecessary `respond_to?(:indexes)` checking
-
由 Kasper Timm Hansen 提交于
Follow up to 454460e8. Rebuild the sentence so the bit about only symbols allowed comes less out of left field and fits in better with the existing doc. Also remove the `(Legacy syntax)` construct. The sections are properly nested under `=== Options` with `====` and look fine on the generated API doc site.
-
由 Kasper Timm Hansen 提交于
Add documentation for `config.assets.version`
-
由 Erol Fornoles 提交于
-
由 Akira Matsuda 提交于
I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets. So I'm adding them to the help message. I'm still not sure how to show `--no-test-framework` though.
-
由 Rafael França 提交于
Fix :stopdoc: to :startdoc: [ci skip]
-
由 Ryuta Kamizono 提交于
-
由 Arthur Nogueira Neves 提交于
Fix HABTM associations join table resolver bug on constants and symbols
-
由 Matthew Draper 提交于
A query may wait on a database-level lock, which could lead to a deadlock between threads.
-
由 Sean Griffin 提交于
Fixes an issue where time_zone_conversion that causes an exception in…
-
由 Julian Nadeau 提交于
Following off of https://github.com/rails/rails/issues/15945, I realized that super needs to be the first thing that is called in an AbstractModel's inherited method. I was receiving errors within the inherited method of time_zone_conversion, so I tested locally by moving super to the top of the method declaration. All exceptions went away.
-