1. 12 5月, 2018 1 次提交
  2. 11 5月, 2018 3 次提交
  3. 10 5月, 2018 2 次提交
  4. 09 5月, 2018 3 次提交
  5. 08 5月, 2018 3 次提交
  6. 07 5月, 2018 5 次提交
  7. 06 5月, 2018 5 次提交
    • X
      restores original intention in constants guide, reworded [ci skip] · 5c7656d9
      Xavier Noria 提交于
      Once all technicalities have been introduced, the purpose of this
      paragraph is to precisely unroll expressions like "the String class".
      That way, the reader is forced to clearly separate concepts that Ruby
      programmers often have kind of blurred:
      
        * Constants are storage, like variables.
      
        * Ruby does not have syntax for class or module names.
      
        * `String` is a regular constant that holds a value. In this case, the
          value happens to be a class object.
      
        * Constants are stored in class and module objects. In the case of
          `String`, the holder is the class object stored in the `Object`
          constant.
      
      Understanding that paragraph the way is written is important to
      accomplish this objective.
      
      References #32818.
      5c7656d9
    • V
      Merge pull request #32827 from sagarkt/guides_active_record_postgresql · 5edafc21
      Vipul A M 提交于
      Active Record postgresql documentation for bit string types corrected [ci skip]
      5edafc21
    • S
    • R
    • X
      prefer File.write for bulk writes · be9a32b6
      Xavier Noria 提交于
      I saw these ones while working on #32362.
      
      File.write was introduced in Ruby 1.9.3 and it is the most concise way
      to perform bulk writes (as File.read is for bulk reading).
      
      The existing flags enabled binmode, but we are dumping text here.
      The portable way to dump text is text mode. The only difference is
      newlines, and portable code should in particular emit portable newlines.
      
      Please note the hard-coded \ns are still correct. In languages with C
      semantics for newlines like Ruby, Python, Perl, and others, "\n" is a
      portable newline. Both when writing and when reading. On Windows, the
      I/O layer is responsible for prepending a CR before each LF on writing,
      and removing CRs followed by LFs on reading. On Unix, binmode is a
      no-op.
      be9a32b6
  8. 05 5月, 2018 4 次提交
    • Y
      Merge pull request #32780 from ttanimichi/tmp · 42b9e7e5
      Yuji Yaginuma 提交于
      Don't generate assets' initializer in `app:update` task if sprockets is skipped
      42b9e7e5
    • T
      Don't generate assets' initializer in `app:update` task if sprockets is skipped · 59c3d539
      Tsukuru Tanimichi 提交于
      Execute `rails new myapp -S` and then upgrade the app by using the `app:update` task, `bin/rails c` results in `NoMethodError`.
      
      ```
      $ bin/rails app:update
      
      $ bin/rails c
      Traceback (most recent call last):
          44: from bin/rails:4:in `<main>'
      (snip)
           1: from /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/config/initializers/assets.rb:4:in `<top (required)>'
      /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x00007fcb8d3697e0> (NoMethodError)
      Did you mean?  asset_host
      ```
      59c3d539
    • R
      Merge pull request #32807 from bdurand/fix_committed_disable_callbacks · 5eaec23b
      Ryuta Kamizono 提交于
      Fix logic on disabling afer_commit callbacks
      5eaec23b
    • B
      Fix logic on disabling commit callbacks · a779b1a0
      Brian Durand 提交于
      Commit callbacks are intentionally disabled when errors occur when calling the callback chain in order to reset the internal record state. However, the implicit order of operations on the logic for checking if callbacks are disabled is wrong. The result is that callbacks can be unexpectedly when errors occur in transactions.
      a779b1a0
  9. 04 5月, 2018 6 次提交
  10. 03 5月, 2018 7 次提交
  11. 02 5月, 2018 1 次提交