- 10 5月, 2018 1 次提交
-
-
由 Assain 提交于
-
- 09 5月, 2018 3 次提交
-
-
由 Claudio B 提交于
Fix ActiveRecord::AttributeMethods::Dirty documentation
-
由 George Claghorn 提交于
Add option to ActiveStorage::Blob to set extract_content_type_from_io
-
由 Ryan Davidson 提交于
This adds a boolean argument called identify to ActiveStorage::Blob methods #create_after_upload, #build_after_upload and #upload. It allows a user to bypass the automatic content_type inference from the io.
-
- 08 5月, 2018 3 次提交
-
-
由 yuuji.yaginuma 提交于
The prefix of `new` and `edit` generated by `resources` is singular.
-
由 Ryuta Kamizono 提交于
Remove leftover requires
-
由 T.J. Schuck 提交于
* Concurrent::Map usage was removed from this file in 3239ed48 * Monitor usage was removed in f233598d
-
- 07 5月, 2018 5 次提交
-
-
由 Vipul A M 提交于
Fix output in routing.md [ci skip]
-
由 Yuta Uchida 提交于
-
由 Kieran Trezona-le Comte 提交于
Previously the documentation for the newly introduced (in 5.1) AR::Dirty methods was misleading, as it stated the the new methods were aliases for the old methods. This was false, and caused confusion when the differences in their implementation became apparent. This change attempts to describe the behaviour of these methods more accurately, also noting when they are likely to be useful (i.e. before or after saving a record). This change also makes minor updates to consistently format the documentation of this API, in accordance with the API Documentation Guidelines.
-
由 yuuji.yaginuma 提交于
-
由 Ryuta Kamizono 提交于
Follow up of #32034.
-
- 06 5月, 2018 5 次提交
-
-
由 Xavier Noria 提交于
Once all technicalities have been introduced, the purpose of this paragraph is to precisely unroll expressions like "the String class". That way, the reader is forced to clearly separate concepts that Ruby programmers often have kind of blurred: * Constants are storage, like variables. * Ruby does not have syntax for class or module names. * `String` is a regular constant that holds a value. In this case, the value happens to be a class object. * Constants are stored in class and module objects. In the case of `String`, the holder is the class object stored in the `Object` constant. Understanding that paragraph the way is written is important to accomplish this objective. References #32818.
-
由 Vipul A M 提交于
Active Record postgresql documentation for bit string types corrected [ci skip]
-
由 Sagar Kamble 提交于
-
由 Xavier Noria 提交于
I saw these ones while working on #32362. File.write was introduced in Ruby 1.9.3 and it is the most concise way to perform bulk writes (as File.read is for bulk reading). The existing flags enabled binmode, but we are dumping text here. The portable way to dump text is text mode. The only difference is newlines, and portable code should in particular emit portable newlines. Please note the hard-coded \ns are still correct. In languages with C semantics for newlines like Ruby, Python, Perl, and others, "\n" is a portable newline. Both when writing and when reading. On Windows, the I/O layer is responsible for prepending a CR before each LF on writing, and removing CRs followed by LFs on reading. On Unix, binmode is a no-op.
-
- 05 5月, 2018 4 次提交
-
-
由 Yuji Yaginuma 提交于
Don't generate assets' initializer in `app:update` task if sprockets is skipped
-
由 Tsukuru Tanimichi 提交于
Execute `rails new myapp -S` and then upgrade the app by using the `app:update` task, `bin/rails c` results in `NoMethodError`. ``` $ bin/rails app:update $ bin/rails c Traceback (most recent call last): 44: from bin/rails:4:in `<main>' (snip) 1: from /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/config/initializers/assets.rb:4:in `<top (required)>' /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x00007fcb8d3697e0> (NoMethodError) Did you mean? asset_host ```
-
由 Ryuta Kamizono 提交于
Fix logic on disabling afer_commit callbacks
-
由 Brian Durand 提交于
Commit callbacks are intentionally disabled when errors occur when calling the callback chain in order to reset the internal record state. However, the implicit order of operations on the logic for checking if callbacks are disabled is wrong. The result is that callbacks can be unexpectedly when errors occur in transactions.
-
- 04 5月, 2018 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix #29632 - nil #path leads to NoMethodError in LoadError#is_missing?
-
由 Neil Souza 提交于
See #29632 for details. In short, it's possible to enter `LoadError#is_missing?` when `LoadError#path` returns `nil`, leading to `path.sub` throwing an none-to-helpful `NoMethodError`. This tiniest of patch inserts `#to_s` before the `sub` call to make sure it succeeds. Affected surface area should be just as tiny since something has already gone wrong to get us into `#is_missing?` and the current behavior when `#path` returns `nil` seems clearly not intended. [Gannon McGibbon + Neil Souza]
-
由 Eileen M. Uchitelle 提交于
Remove confusion in the sentence [ci skip]
-
由 Santosh Wadghule 提交于
-
由 Ryuta Kamizono 提交于
Updates documentation on ActionDispatch::Integration::Session#process [ci skip]
-
由 George Claghorn 提交于
Minor edits to the Active Storage guide
-
- 03 5月, 2018 7 次提交
-
-
由 Tyler Hunt 提交于
Fix spelling, grammar, and formatting. [ci skip]
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Use usual method definition instead of extracting args from array
-
由 printercu 提交于
Follows #32612
-
由 Ryuta Kamizono 提交于
weblog.jamisbuck.org is not GitHub Pages.
-
由 yuuji.yaginuma 提交于
Specification: https://w3c.github.io/webappsec-csp/#directive-prefetch-src This directive can already be used as an experimental feature in Chrome. Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=801561
-
由 George Claghorn 提交于
-
- 02 5月, 2018 6 次提交
-
-
由 Arun Agrawal 提交于
Use https with weblog URI
-
由 Yoshiyuki Hirano 提交于
-
由 Rafael França 提交于
Remove unused `assert_like` from `Arel::Test`
-
由 George Claghorn 提交于
-
由 Yasuo Honda 提交于
It had been added at https://github.com/rails/arel/commit/05b5bb12270b32e094c1c879273e0978dabe5b3b and removed at https://github.com/rails/arel/commit/db1bb4e9a728a437d16f8bdb48c3b772c3e4edb0
-
由 yuuji.yaginuma 提交于
`require 'rubygems'` is already required in Ruby 1.9 or later.
-