1. 14 10月, 2016 3 次提交
  2. 13 10月, 2016 1 次提交
  3. 12 10月, 2016 6 次提交
  4. 11 10月, 2016 18 次提交
    • R
      Merge pull request #26757 from biow0lf/set-target-ruby-version · 32617a2c
      Rafael França 提交于
      Set target ruby version for rubocop to 2.2 instead 2.3.
      32617a2c
    • P
      ActionController::Parameters#deep_dup (#26567) · f80ddf30
      Pavel Evstigneev 提交于
      * ActionController::Parameters#deep_dup
      
      * Tests for ActionController::Parameters#deep_dup
      
      * Fix test for ActionController::Parameters#deep_dup
      
      * More tests for ActionController::Parameters#deep_dup
      
      [Rafael Mendonça França + Pavel Evstigneev]
      f80ddf30
    • I
      Set target ruby version for rubocop to 2.2 instead 2.3. · b16a0750
      Igor Zubkov 提交于
      This change will help to catch ruby 2.3+ syntax in code base. Right now, minimal ruby version set to 2.2.2 in gemspecs.
      
      Rubocop output before:
      
      $ rubocop
      Inspecting 2133 files
      .............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................CC.........................................................................................................................................................................................................................................................
      
      Offenses:
      
      activerecord/test/cases/schema_dumper_test.rb:454:32: C: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
          output = dump_table_schema('infinity_defaults')
                                     ^^^^^^^^^^^^^^^^^^^
      guides/bug_report_templates/active_record_migrations_gem.rb:65:4: C: Final newline missing.
      end
      
      guides/bug_report_templates/active_record_migrations_master.rb:64:4: C: Final newline missing.
      end
      
      2133 files inspected, 3 offenses detected
      $
      
      After:
      $ rubocop
      Inspecting 2133 files
      .............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................CC.........................................................................................................................................................................................................................................................
      
      Offenses:
      
      activerecord/test/cases/schema_dumper_test.rb:454:32: C: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
          output = dump_table_schema('infinity_defaults')
                                     ^^^^^^^^^^^^^^^^^^^
      guides/bug_report_templates/active_record_migrations_gem.rb:65:4: C: Final newline missing.
      end
      
      guides/bug_report_templates/active_record_migrations_master.rb:64:4: C: Final newline missing.
      end
      
      2133 files inspected, 3 offenses detected
      $
      b16a0750
    • M
      Permit same-origin connections by default · dae40447
      Matthew Draper 提交于
      WebSocket always defers the decision to the server, because it didn't
      have to deal with legacy compatibility... but the same-origin policy is
      still a reasonable default.
      
      Origin checks do not protect against a directly connecting attacker --
      they can lie about their host, but can also lie about their origin.
      Origin checks protect against a connection from 3rd-party controlled
      script in a context where a victim browser's cookies will be passed
      along. And if an attacker has breached that protection, they've already
      compromised the HTTP session, so treating the WebSocket connection in
      the same way seems reasonable.
      
      In case this logic proves incorrect (or anyone just wants to be more
      paranoid), we retain a config option to disable it.
      dae40447
    • M
      Merge pull request #26568 from skateman/cable-sameorigin-as-host · f8c53eff
      Matthew Draper 提交于
      Optionally allow ActionCable requests from the same host as origin
      f8c53eff
    • M
      Merge pull request #26208 from nanaya/pg-insensitive-text · bc9dc418
      Matthew Draper 提交于
      Fix case insensitive check for text column in pg
      bc9dc418
    • R
      Merge pull request #26756 from kamipo/extract_format_colspec · 469dd36a
      Rafael França 提交于
      Extract `format_colspec` to format column spec
      469dd36a
    • R
      Merge pull request #26531 from y-yagi/remove_unused_benchmark · 3c8f26ac
      Rafael França 提交于
      remove unused require `benchmark`
      3c8f26ac
    • R
      Extract `format_colspec` to format column spec · 1fa97c76
      Ryuta Kamizono 提交于
      1fa97c76
    • R
      Merge pull request #26577 from dharamgollapudi/add_license · a7b20c70
      Rafael França 提交于
      Add top level license
      a7b20c70
    • R
      Merge pull request #26755 from rafaelfranca/deprecations · c2fa5360
      Rafael França 提交于
      Remove deprecations in Active Model, Action View and Active Job
      c2fa5360
    • R
      6a78e0ec
    • R
      Removed deprecated methods in ActiveModel::Errors · 9de6457a
      Rafael Mendonça França 提交于
      `#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
      9de6457a
    • R
      Merge pull request #26753 from kamipo/fix_table_comment_dumping · 36f6ab2d
      Rafael França 提交于
      Fix table comment dumping
      36f6ab2d
    • R
      Fix table comment dumping · 0780c444
      Ryuta Kamizono 提交于
      Follow up to #26735.
      
      If `table_options` returns `{ comment: nil }`, `create_table` line is
      broken.
      
      Example:
      
      ```ruby
        create_table "accounts", force: :cascade,  do |t|
      ```
      0780c444
    • R
    • R
    • R
      Merge pull request #26747 from kamipo/name_is_not_column_option · 15fa2821
      Rafael França 提交于
      `name` is not a column option
      15fa2821
  5. 10 10月, 2016 12 次提交