Although no recognized formats use non-ASCII characters, sometimes they
can be included in the :format parameter because of invalid URLS. To
prevent encoding incompatibility errors we need to escape them before
passing the path to URI.unescape.

Closes #4379

This fixes undef `to_str' for Rack::Chunked::Body when using
caches_action + streaming on an action

Closes #5027

Ensure that the format isn't applied twice to the cache key, else it becomes impossible to target with expire_action.

Proc objects for cache_path for caches_action no longer need controller object, nor to use send when calling routing helpers

Fix Action caching bug where an action that has a non-cacheable response always renders a nil response body. It now correctly renders the response body.

Note that only GET and HTTP 200 responses can be cached.

[#6480 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

handle HTTP_ACCEPT attribute properly and might
provide wrong result. Use params[:format] to
avoid this issue.

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

ActionCachingTestController rescues from all exceptions. Making sure that all the tests check for valid response. [#4468 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Remove caching's dependency on view_context. Also, make it so that the layout is always rendered the same way (so that layout dependencies on the action actually being rendered aren't masked on the first render)

Replace _action_view with view_context to reflect that it is public and that it does not need to be an ActionView instance

Methods raising ActiveRecord::RecordNotFound were returning 404 on first request and 200 OK with blank body on subsequent requests.

[#2533 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Deprecate template, session, assigns, and layout accessors on response object. Instead access them through the controller instance. This mainly affects functional test assertions.