1. 02 6月, 2016 4 次提交
    • S
      Ensure that records with unselected fields can be updated · c587b636
      Sean Griffin 提交于
      As part of refactoring mutation detection to be more performant, we
      introduced the concept of `original_value` to `Attribute`. This was not
      overridden in `Attribute::Uninitialized` however, so assigning ot an
      uninitialized value and calling `.changed?` would raise
      `NotImplementedError`.
      
      We are using a sentinel value rather than checking the result of
      `original_attribute.initialized?` in `changed?` because `original_value`
      might go through more than one node in the tree.
      
      Fixes #25228
      c587b636
    • V
      Merge pull request #25252 from felguerez/master · b604dd0b
      Vipul A M 提交于
      add missing "as" to Engines doc page [ci skip]
      b604dd0b
    • A
      add missing "as" · 5413d403
      Antonio Felguerez 提交于
      it reads a bit awkwardly without it.
      5413d403
    • S
      Fix failing tests · 1b8a7b82
      Sean Griffin 提交于
      Currently CI is broken due to 56a61e0c and c4cb6862. This occurred because
      the failures are not present on SQLite which is what I normally run
      locally before pushing.
      
      The optimizations to our YAML size were dropping mutations, as
      `with_type` didn't set the previous value if it'd already been read
      (that method was never really designed to be used with values on
      individual objects, it was previously only used for defaults). I'm
      questioning whether there's a better place to be handling the exclusion
      of the type, but this will fix the failing build.
      
      Additionally, there was a bug in `remove_foreign_key` if you passed it
      an options hash containing `to_table`. This now occurs whenever removing
      a reference, as we always normalize to a hash.
      
      [Sean Griffin & Ryuta Kamizono]
      1b8a7b82
  2. 01 6月, 2016 12 次提交
  3. 31 5月, 2016 18 次提交
  4. 30 5月, 2016 4 次提交
  5. 29 5月, 2016 2 次提交