- 09 11月, 2012 28 次提交
-
-
由 Jon Leighton 提交于
Rather than just changing it and hoping for the best. Requested by @jeremy: https://github.com/rails/rails/commit/ba1544d71628abff2777c9c514142d7e9a159111#commitcomment-2106059
-
由 Rafael Mendonça França 提交于
Removing duplication in callback normalization.
-
由 Steve Klabnik 提交于
These two things were 100% identical.
-
由 Jon Leighton 提交于
:counter_cache option for to support custom named counter caches
-
由 Jon Leighton 提交于
So that the scope may be a NullRelation and return a result without executing a query. Fixes #7928
-
由 Jon Leighton 提交于
Fixes #8102. I couldn't find a nicer way to deal with this than delegate the call to #scope, which will be a NullRelation when we want it to be.
-
由 Jon Leighton 提交于
This allows us to avoid hacks like the "return 0 if owner.new_record?" in #count (which this commit removes). Also, the relevant foreign key may actually be present even on a new owner record, in which case we *don't* want a null relation. This logic is encapsulated in the #null_scope? method. We also need to make sure that the CollectionProxy is not 'infected' with the NullRelation module, or else the methods from there will override the definitions in CollectionProxy, leading to incorrect results. Hence the nullify: false option to CollectionAssociation#scope. (This feels a bit nasty but I can't think of a better way.)
-
由 Carlos Antonio da Silva 提交于
delegate PathSet's enumerator methods
-
由 Carlos Antonio da Silva 提交于
Fix message about include_blank option. [ci skip]
-
由 Jon Leighton 提交于
For example, the following should not run any query on the database: Post.new.comments.where(body: 'omg').to_a # => [] Fixes #5215.
-
由 Xavier Noria 提交于
Add note about squashing in contributor guide.
-
由 Vasiliy Ermolovich 提交于
-
We tell people how to do this all the time in the Issues tracker, so now we can just point them here.
-
由 Aaron Patterson 提交于
not raise so many exceptions: https://github.com/rails/rails/blob/master/actionpack/lib/action_view/template.rb#L126 irb(main):001:0> class Foo; def method_missing(*args); super; end end => nil irb(main):002:0> $DEBUG = true => true irb(main):003:0> Array(Foo.new) Exception `NoMethodError' at (irb):1 - undefined method `to_ary' for #<Foo:0x007f854390e488> Exception `NoMethodError' at (irb):1 - undefined method `to_a' for #<Foo:0x007f854390e488> => [#<Foo:0x007f854390e488>] irb(main):004:0>
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Carlos Antonio da Silva 提交于
Kernel#capture replaced by version which can catch output from subprocesses
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
Reformat gemspec
-
由 Jon Leighton 提交于
This reverts commit 36376560, reversing changes made to 3148ed9a. Conflicts: actionpack/lib/action_dispatch/middleware/flash.rb Reason: it broke Sam's CI https://github.com/rails/rails/pull/8017#issuecomment-10210655
-
由 Vinny Diehl 提交于
Organized the gemspec files a bit. * Made quotes more consistent (single quotes dominated, so I used that). * Moved license line down a line, separating it logically, and removed the extra whitespace before its = operator. * Minor whitespace fixes.
-
由 Carlos Antonio da Silva 提交于
-
由 Jon Leighton 提交于
Store FlashHashes in the session as plain hashes
-
由 Rafael Mendonça França 提交于
handle trailing slash with engines (test case for #7842)
-
由 Rafael Mendonça França 提交于
Add test to avoid regression of 58e48d52
-
-
由 Rafael Mendonça França 提交于
[ci skip]
-
- 08 11月, 2012 5 次提交
-
-
由 Carlos Antonio da Silva 提交于
Add app Rake tasks when -T and --dummy-path is passed to `plugin new`
-
由 Yves Senn 提交于
Closes #8121 The `plugin new` generator always adds the dummy app rake tasks, when a dummy app was created.
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
This is already handled by #find, it's a duplicate check, since find_with_ids is not called from anywhere else.
-
- 07 11月, 2012 7 次提交
-
-
由 Carlos Antonio da Silva 提交于
Commit 65a2977c has introduced some changes to format content for small devices, this change reverts the original font size for normal screens while maintaing the same format for these devices. [ci skip]
-
由 Carlos Antonio da Silva 提交于
[ci skip]
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Carlos Antonio da Silva 提交于
Permitted should be sticky on #slice
-