- 10 11月, 2017 4 次提交
-
-
由 Lisa Ugray 提交于
Use these to back the attributes API. Stop automatically including ActiveModel::Dirty in ActiveModel::Attributes, and make it optional.
-
由 Rafael França 提交于
field_error_proc wrap form select optgroup and separator option
-
由 Rafael Mendonça França 提交于
Use `Tempfile.create`
-
由 neumayr 提交于
### Summary The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`. * Fix for `field_error_proc` wraps form select `optgroup` * Fix for `field_error_proc` wraps form select divider `option` * Add tests for uncovered elements with errors [Fixes #31088] #### Test coverage * `test_select_grouped_options_with_errors` * `test_time_zone_select_with_priority_zones_and_errors` #### Extend test coverage * `test_collection_select_with_errors` * `test_label_with_errors` * `test_check_box_with_errors` * `test_check_boxes_with_errors` * `test_radio_button_with_errors` * `test_radio_buttons_with_errors` * `test_collection_check_boxes_with_errors` * `test_collection_radio_buttons_with_errors`
-
- 09 11月, 2017 18 次提交
-
-
由 Andrew White 提交于
Allow `Range#include?` on TWZ ranges
-
由 Nobuyoshi Nakada 提交于
As `@cache_path` is expected to be a directory name, use `Dir.mktmpdir`. And omit unnecessary `Dir.tmpdir`.
-
由 Eileen M. Uchitelle 提交于
Do not show credentials in generators help
-
由 yuuji.yaginuma 提交于
Since credentials generator is executed via the credentials command and does not need to be executed directly, so it is not necessary to show it in help.
-
由 Nobuyoshi Nakada 提交于
Instead of `Dir::Tmpname.make_tmpname`, an internal method which does not guarantee uniqueness, use `Tempfile.create`.
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Use plain assert in assert_changes to avoid MT6 refutes
-
由 Rafael França 提交于
Fix typoes on ActionDispatch::HTTP::FilterParameters
-
由 Rafael França 提交于
Correctly kill the server started with ujs test
-
由 yuuji.yaginuma 提交于
`Kernel.#spawn` execute command via the shell if contains shell metacharacters in the command. In that case, return value of `spawn` is pid of the shell, not the server. Therefore, just killing the pid will leave the process of server. In order to correctly kill the server, send a signal to the process group, not the process.
-
由 Rafael França 提交于
Allow `ConcurrentTransactionTest` can run with Oracle enhanced adapter
-
由 Yasuo Honda 提交于
returns true Not only postgresql or mysql2 adapter, Oracle enhanced adapter whose default isolation level is read commited, passes these two test cases. `ConcurrentTransactionTest#test_transaction_per_thread` `ConcurrentTransactionTest#test_transaction_isolation__read_committed` ```ruby $ ARCONN=oracle bin/test test/cases/transactions_test.rb:961 -v Using oracle Run options: -v --seed 18865 ConcurrentTransactionTest#test_transaction_per_thread = 0.98 s = . Finished in 1.061036s, 0.9425 runs/s, 5.6549 assertions/s. 1 runs, 6 assertions, 0 failures, 0 errors, 0 skips ``` ```ruby $ ARCONN=oracle bin/test test/cases/transactions_test.rb:979 -v Using oracle Run options: -v --seed 13341 ConcurrentTransactionTest#test_transaction_isolation__read_committed = 1.85 s = . Finished in 1.928637s, 0.5185 runs/s, 10.3700 assertions/s. 1 runs, 20 assertions, 0 failures, 0 errors, 0 skips $ ``` Also, regardless it is a file based or memory based these tests could fail with SQLite3Adapter. (Extra CR added to make lines shorter) ```ruby $ ARCONN=sqlite3 bin/test test/cases/transactions_test.rb:961 -v Using sqlite3 Run options: -v --seed 18815 ConcurrentTransactionTest#test_transaction_per_thread = /home/yahonda/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/sqlite3-1.3.13/lib/sqlite3/statement.rb:108:in `step': SQLite3::BusyException: database is locked: UPDATE "topics" SET "approved" = ?, "updated_at" = ? WHERE "topics"."id" = ? (ActiveRecord::StatementInvalid) ``` ```ruby $ ARCONN=sqlite3 bin/test test/cases/transactions_test.rb:979 -v Using sqlite3 Run options: -v --seed 25520 ConcurrentTransactionTest#test_transaction_isolation__read_committed = 0.12 s = E /home/yahonda/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/sqlite3-1.3.13/lib/sqlite3/statement.rb:108:in `step': SQLite3::BusyException: database is locked: UPDATE "developers" SET "salary" = ?, "updated_at" = ?, "updated_on" = ? WHERE "developers"."id" = ? (ActiveRecord::StatementInvalid) ```
-
由 Rafael França 提交于
Change output log about skipping instalation of Active Storage
-
由 Rafael França 提交于
Merge pull request #31092 from bogdanvlviv/remove-redundant-passing-skip-active-storage-in-test-cases Remove redundant passing --skip-active-storage in test cases
-
由 bogdanvlviv 提交于
Using of "`" is preferable over "'" to express console command in output log
-
由 bogdanvlviv 提交于
These were added in #30101, after #31084 it became redundant.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
- 08 11月, 2017 10 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
`through_reflection` and `source_reflection` are used only in the class.
-
由 Andrew White 提交于
In #11474 we prevented TWZ ranges being iterated over which matched Ruby's handling of Time ranges and as a consequence `include?` stopped working with both Time ranges and TWZ ranges. However in ruby/ruby@b061634 support was added for `include?` to use `cover?` for 'linear' objects. Since we have no way of making Ruby consider TWZ instances as 'linear' we have to override `Range#include?`. Fixes #30799.
-
由 Matthew Draper 提交于
Use released `redis-namespace` instead of master version
-
由 yuuji.yaginuma 提交于
The `redis-namespace` 1.6.0 includes redis-rb 4.0 support.
-
由 Ryuta Kamizono 提交于
Fix output of `select_tag` with `include_blank: true` [ci skip]
-
由 Ryuta Kamizono 提交于
Merge pull request #31084 from y-yagi/do_not_run_active_storage_install_when_bundle_install_is_skipped Do not run active storage install when bundle install is skipped
-
由 yuuji.yaginuma 提交于
Since #24923, if use `select_tag` with `include_blank: true`, an empty label is added.
-
由 yuuji.yaginuma 提交于
Since isolation application is generated with the `--skip-gemfile` option, so `active_storage:install` is not executed.
-
由 yuuji.yaginuma 提交于
In order to execute the `rails` command, need to run bundle install in advance. Therefore, if skipped bundle install, `rails` command may fail and should not do it.
-
- 07 11月, 2017 8 次提交
-
-
由 George Claghorn 提交于
-
由 Takumasa Ochi 提交于
-
由 Genadi Samokovarov 提交于
Seeing the previously issued PRs about it, we can avoid the `nil` comparisons that can happen in `assert_changes` by using plain `assert` calls. This is to avoid a deprecation warning about comparing `nil` values in `assert_equal` for Minitest 5 and a crash in Minitest 6. You can see the preparations done in [`assert_equal`][ae]. You can also see that [`assert`][a] does not care about `nil`s. [ae]: https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest/assertions.rb#L159-L188 [a]: https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest/assertions.rb#L131-L142
-
由 Ryuta Kamizono 提交于
Fix comment in `check_class_collision` [ci skip]
-
由 yuuji.yaginuma 提交于
`ScaffoldBase` was changed to `ResourceHelpers` by 0efedf2a.
-
由 Rafael França 提交于
Prevent extra string allocations when no 'rel' arg passed
-
由 Rafael França 提交于
Add cases to test combining validation conditions
-
由 Rafael França 提交于
Fix `bin/rails db:migrate` with specified `VERSION`
-