1. 03 5月, 2014 3 次提交
  2. 02 5月, 2014 4 次提交
  3. 01 5月, 2014 3 次提交
  4. 24 4月, 2014 1 次提交
    • G
      Fixed an issue with migrating legacy json cookies. · 2a412b3d
      Godfrey Chan 提交于
      Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming
      cookies are marshal-encoded. This is not the case when `secret_token` is
      used in conjunction with the `:json` or `:hybrid` serializer.
      
      In those case, when upgrading to use `secret_key_base`, this would cause a
      `TypeError: incompatible marshal file format` and a 500 error for the user.
      
      Fixes #14774.
      
      *Godfrey Chan*
      2a412b3d
  5. 20 4月, 2014 3 次提交
    • A
      Make URL escaping more consistent · 5460591f
      Andrew White 提交于
      1. Escape '%' characters in URLs - only unescaped data
         should be passed to URL helpers
      
      2. Add an `escape_segment` helper to `Router::Utils`
         that escapes '/' characters
      
      3. Use `escape_segment` rather than `escape_fragment`
         in optimized URL generation
      
      4. Use `escape_segment` rather than `escape_path`
         in URL generation
      
      For point 4 there are two exceptions. Firstly, when a route uses wildcard
      segments (e.g. *foo) then we use `escape_path` as the value may contain '/'
      characters. This means that wildcard routes can't be optimized. Secondly,
      if a `:controller` segment is used in the path then this uses `escape_path`
      as the controller may be namespaced.
      
      Fixes #14629, #14636 and #14070.
      5460591f
    • A
      Optimize URI escaping · a6179257
      Andrew White 提交于
      The URI::Parser#escape method is a general use method that has to deal
      with a variety of input however our use of it is limited in scope so
      we can increase the performance by implementing our specific needs
      within ActionDispatch::Journey::Router::Utils directly.
      
      If there is no encoding required then there is no change in performance
      or number of objects allocated, but for each character that needs to be
      encoded we save five object allocations and gain a performance boost.
      The performance boost seen varies from 20% when there is one character
      to over 50% when encoding ten characters.
      a6179257
    • E
      Always escape string passed to url helper. · e2ef83f8
      edogawaconan 提交于
      Makes it clear that anything passed with the helper must not be percent encoded.
      
      Fixes previous behavior which tricks people into believing passing
      non-percent-encoded will generate a proper percent-encoded path while in
      reality it doesn't ('%' isn't escaped).
      
      The intention is nice but the heuristic is broken.
      e2ef83f8
  6. 19 4月, 2014 1 次提交
  7. 18 4月, 2014 1 次提交
  8. 16 4月, 2014 1 次提交
  9. 15 4月, 2014 1 次提交
    • R
      Return null type format when format is not know · 4d21e496
      Rafael Mendonça França 提交于
      When requesting a controller with the following code with a unknown format:
      
          def my_action
            respond_to do |format|
              format.json { head :ok }
              format.any { render text: 'Default response' }
            end
          end
      
      we should render the default response instead of raising ActionController::UnknownFormat
      
      Fixes #14462
      
      Conflicts:
      	actionpack/CHANGELOG.md
      	actionpack/test/controller/mime/respond_with_test.rb
      
      Conflicts:
      	actionpack/CHANGELOG.md
      4d21e496
  10. 14 4月, 2014 1 次提交
  11. 13 4月, 2014 2 次提交
  12. 11 4月, 2014 4 次提交
  13. 10 4月, 2014 1 次提交
    • A
      Avoid URI parsing · 85e424de
      Andriel Nuernberg 提交于
      This parsing is unecessary once the Request object already has the
      needed information.
      85e424de
  14. 02 4月, 2014 4 次提交
  15. 29 3月, 2014 1 次提交
  16. 27 3月, 2014 1 次提交
  17. 23 3月, 2014 1 次提交
  18. 21 3月, 2014 1 次提交
  19. 20 3月, 2014 1 次提交
  20. 16 3月, 2014 1 次提交
  21. 13 3月, 2014 2 次提交
    • A
      use the body proxy to freeze headers · 3df07d09
      Aaron Patterson 提交于
      avoid freezing the headers until the web server has actually read data
      from the body proxy.  Once the webserver has read data, then we should
      throw an error if someone tries to set a header
      3df07d09
    • A
      only write the jar if the response isn't committed · 77a09218
      Aaron Patterson 提交于
      when streaming responses, we need to make sure the cookie jar is written
      to the headers before returning up the stack. This commit introduces a
      new method on the response object that writes the cookie jar to the
      headers as the response is committed.  The middleware and test framework
      will not write the cookie headers if the response has already been
      committed.
      
      fixes #14352
      77a09218
  22. 12 3月, 2014 1 次提交
  23. 09 3月, 2014 1 次提交