- 03 5月, 2014 3 次提交
-
-
由 Akshay Vishnoi 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 02 5月, 2014 4 次提交
-
-
由 Robin Dupret 提交于
-
由 Aaron Patterson 提交于
I think this is wrong, but it gets the build passing for now. We should always add options, but we need to make more guarantees about how the underlying url helper is called
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
if you want options, don't mix them with the first hash, just pass them all in with the second hash
-
- 01 5月, 2014 3 次提交
-
-
由 Juan David Pastas 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 24 4月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
Previously, the `VerifyAndUpgradeLegacySignedMessage` assumes all incoming cookies are marshal-encoded. This is not the case when `secret_token` is used in conjunction with the `:json` or `:hybrid` serializer. In those case, when upgrading to use `secret_key_base`, this would cause a `TypeError: incompatible marshal file format` and a 500 error for the user. Fixes #14774. *Godfrey Chan*
-
- 20 4月, 2014 3 次提交
-
-
由 Andrew White 提交于
1. Escape '%' characters in URLs - only unescaped data should be passed to URL helpers 2. Add an `escape_segment` helper to `Router::Utils` that escapes '/' characters 3. Use `escape_segment` rather than `escape_fragment` in optimized URL generation 4. Use `escape_segment` rather than `escape_path` in URL generation For point 4 there are two exceptions. Firstly, when a route uses wildcard segments (e.g. *foo) then we use `escape_path` as the value may contain '/' characters. This means that wildcard routes can't be optimized. Secondly, if a `:controller` segment is used in the path then this uses `escape_path` as the controller may be namespaced. Fixes #14629, #14636 and #14070.
-
由 Andrew White 提交于
The URI::Parser#escape method is a general use method that has to deal with a variety of input however our use of it is limited in scope so we can increase the performance by implementing our specific needs within ActionDispatch::Journey::Router::Utils directly. If there is no encoding required then there is no change in performance or number of objects allocated, but for each character that needs to be encoded we save five object allocations and gain a performance boost. The performance boost seen varies from 20% when there is one character to over 50% when encoding ten characters.
-
由 edogawaconan 提交于
Makes it clear that anything passed with the helper must not be percent encoded. Fixes previous behavior which tricks people into believing passing non-percent-encoded will generate a proper percent-encoded path while in reality it doesn't ('%' isn't escaped). The intention is nice but the heuristic is broken.
-
- 19 4月, 2014 1 次提交
-
-
由 Akshay Vishnoi 提交于
-
- 18 4月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 16 4月, 2014 1 次提交
-
-
由 Tim Linquist 提交于
In some cases users may need to work with/manipulate more of the Tempfile api than provided by Upload. Allow users to get at the underlying io via the common to_io method of IO/IO-like objects
-
- 15 4月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
When requesting a controller with the following code with a unknown format: def my_action respond_to do |format| format.json { head :ok } format.any { render text: 'Default response' } end end we should render the default response instead of raising ActionController::UnknownFormat Fixes #14462 Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/mime/respond_with_test.rb Conflicts: actionpack/CHANGELOG.md
-
- 14 4月, 2014 1 次提交
-
-
由 Vlad Bokov 提交于
-
- 13 4月, 2014 2 次提交
-
-
由 Marcel Morgan 提交于
References to ``AppName::Application` removed in favour of ``Rails.application`` as generated with a new rails 4.1 app. [ci skip]
-
由 Marcus Stollsteimer 提交于
-
- 11 4月, 2014 4 次提交
-
-
由 Andrew White 提交于
Since `:shallow` may be set at any point in the resource nesting we should only make the new and collection routes shallow when the parent is shallow. This is a bit of a hack but until the mapper is refactored to an object graph instead of a hash of merged values it's the best we can do. Fixes #14684.
-
由 Winston 提交于
- also refactored the javascript.
-
由 Winston 提交于
-
由 Winston 提交于
-
- 10 4月, 2014 1 次提交
-
-
由 Andriel Nuernberg 提交于
This parsing is unecessary once the Request object already has the needed information.
-
- 02 4月, 2014 4 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 29 3月, 2014 1 次提交
-
-
由 Kelley Reynolds 提交于
-
- 27 3月, 2014 1 次提交
-
-
由 Boris Kuznetsov 提交于
-
- 23 3月, 2014 1 次提交
-
-
由 Vishal Lal 提交于
-
- 21 3月, 2014 1 次提交
-
-
由 Earl St Sauver 提交于
THe match documentation doesn't mention any requirement of the parameter name requirement for matches. However, including a bare glob character without a variable assignment causes a parse error.
-
- 20 3月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
Closes #8513
-
- 16 3月, 2014 1 次提交
-
-
由 Andrew White 提交于
The method `shallow?` returns false if the parent resource is a singleton so we need to check if we're not inside a nested scope before copying the :path and :as options to their shallow equivalents. Fixes #14388.
-
- 13 3月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header
-
由 Aaron Patterson 提交于
when streaming responses, we need to make sure the cookie jar is written to the headers before returning up the stack. This commit introduces a new method on the response object that writes the cookie jar to the headers as the response is committed. The middleware and test framework will not write the cookie headers if the response has already been committed. fixes #14352
-
- 12 3月, 2014 1 次提交
-
-
由 Lauro Caetano 提交于
-
- 09 3月, 2014 1 次提交
-
-
由 Andrew White 提交于
If the options :shallow_prefix and :shallow_path are not set in the scope options then copy them from the normal :as and :path options if they are set.
-