- 02 1月, 2020 5 次提交
-
-
由 Ryuta Kamizono 提交于
Use travel_to to in date_helper_test.rb.
-
由 Matthew Draper 提交于
Remove Travis CI files
-
由 Josef Šimánek 提交于
-
由 Yasuo Honda 提交于
Rails CI has been running at Buildkite for 9 month. Refer https://github.com/rails/rails/commit/e485c14a3ee29ee486324a96545abf964d428101
-
由 Yasuo Honda 提交于
Rather than replace `ENV['TRAVIS']` with `ENV['CI']`, I think we can remove this condition because `ENV['TRAVIS']` is not valid at Buildkite then Rails CI has been running with `PROCESS_COUNT` about 9 month since this https://github.com/rails/rails/commit/e485c14a3ee29ee486324a96545abf964d428101
-
- 31 12月, 2019 8 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Kasper Timm Hansen 提交于
Address StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star failure
-
由 Kasper Timm Hansen 提交于
Add ActionCable subscription connection identifier to PostgreSQL adapter
-
由 Carlos Antonio da Silva 提交于
* The last html block wasn't formatting properly, it needed a blank line between the paragraph and the text. * The ordered list wasn't generating the sequence, but always showing 1., the inner content/examples needed to be indented for that to work. * Mark some pieces as inline code for highlighting. * Tweak a couple sentences.
-
由 Sergey Ponomarev 提交于
* You can distinguish connection among others with specific `application_name` ```sql SELECT application_name FROM pg_stat_activity; /* application_name ------------------------ psql ActionCable-PID-42 (2 rows) */ ``` * It's possible to customize connection identification with `id` option in `cable.yml` `ActionCable-PID-#{$$}` is the default value * Related tests refactoring * `ActionCable::Server#config.cable` is no mutated anymore inside Redis subscription adapter
-
由 Yasuo Honda 提交于
Fix #38094 * Steps to reproduce: ```ruby % cd actionpack % MT_CPU=0 bundle exec ruby -w -Itest test/controller/mime/accept_format_test.rb -n "/^(?:MimeControllerLayoutsTest#(?:test_missing_layout_renders_properly)|StarStarMimeControllerTest#(?:test_javascript_with_no_format_only_star_star))$/" --verbose --seed 15759 ``` * Actual result without this commit: ```ruby % cd actionpack % MT_CPU=0 bundle exec ruby -w -Itest test/controller/mime/accept_format_test.rb -n "/^(?:MimeControllerLayoutsTest#(?:test_missing_layout_renders_properly)|StarStarMimeControllerTest#(?:test_javascript_with_no_format_only_star_star))$/" --verbose --seed 15759 Run options: -n "/^(?:MimeControllerLayoutsTest#(?:test_missing_layout_renders_properly)|StarStarMimeControllerTest#(?:test_javascript_with_no_format_only_star_star))$/" --verbose --seed 15759 MimeControllerLayoutsTest#test_missing_layout_renders_properly = 0.18 s = . StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star = 0.00 s = E Error: StarStarMimeControllerTest#test_javascript_with_no_format_only_star_star: ArgumentError: Invalid formats: :iphone /Users/yahonda/src/github.com/yahonda/rails/actionview/lib/action_view/lookup_context.rb:287:in `formats=' /Users/yahonda/src/github.com/yahonda/rails/actionview/lib/action_view/view_paths.rb:11:in `formats=' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/rendering.rb:29:in `process_action' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/abstract_controller/callbacks.rb:42:in `block in process_action' /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/callbacks.rb:98:in `run_callbacks' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/abstract_controller/callbacks.rb:41:in `process_action' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/rescue.rb:22:in `process_action' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action' /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument' /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument' /Users/yahonda/src/github.com/yahonda/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/instrumentation.rb:33:in `process_action' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/abstract_controller/base.rb:136:in `process' /Users/yahonda/src/github.com/yahonda/rails/actionview/lib/action_view/rendering.rb:39:in `process' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/metal.rb:190:in `dispatch' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/test_case.rb:512:in `process' /Users/yahonda/src/github.com/yahonda/rails/actionpack/lib/action_controller/test_case.rb:390:in `get' test/controller/mime/accept_format_test.rb:28:in `test_javascript_with_no_format_only_star_star' rails test test/controller/mime/accept_format_test.rb:26 Finished in 0.180610s, 11.0736 runs/s, 11.0736 assertions/s. 2 runs, 2 assertions, 0 failures, 1 errors, 0 skips % ``` * How to diagnose this error: At first Restore `require "action_view/base"` to `actionpack/lib/action_dispatch/middleware/debug_exceptions.rb` addresses this error, then isolated which lines are required then found this line is required. https://github.com/rails/rails/blob/22483b86a6c779743b30e2f23bb46accfbf96b28/actionpack/lib/action_dispatch.rb#L117 ```ruby ActionView::Base.default_formats ||= Mime::SET.symbols ```
-
- 30 12月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Kasper Timm Hansen 提交于
Set AJ `return_false_on_aborted_enqueue` true in the test suite:
-
- 29 12月, 2019 6 次提交
-
-
由 Rafael França 提交于
Return unfrozen strings from to_sentence
-
由 Rafael França 提交于
Do not abort `rails new` when git binary doesn't exist
-
由 Martijn Storck 提交于
Co-Authored-By: NEugene Kenny <elkenny@gmail.com>
-
由 Akira Matsuda 提交于
for `line.from`
-
由 Nicolas Dular 提交于
-
由 Ryuta Kamizono 提交于
-
- 28 12月, 2019 17 次提交
-
-
由 Edouard CHIN 提交于
- Since this is going to be the default in 6.1, let's set it in the test suite to avoid deprecation warning. Otherwise one has to do `AS::Deprecation.silence { }` everytime we add a new test. Fix #38107
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
I misunderstood the effect of `ruby2_keywords`, the effect is not local scope, the effect still alive even where you delegate.
-
由 Ryuta Kamizono 提交于
Address `DEPRECATED: use MT_CPU instead of N for parallel test runs`
-
由 Yasuo Honda 提交于
* Steps to reproduce ```ruby % cd actionpack % N=0 bundle exec ruby -w -Itest test/controller/mime/accept_format_test.rb DEPRECATED: use MT_CPU instead of N for parallel test runs ... snip ... % ``` * minitest 5.12.0 deprecates ENV["N"] to specify number of parallel test runners: https://github.com/seattlerb/minitest/blob/master/History.rdoc#5120--2019-09-22 https://github.com/seattlerb/minitest/commit/4103a10eb4bb99bc60721b3245ee3a69988a214b * No other code uses `ENV["N"]` ``` % git grep 'ENV\["N"\]' actionpack/test/abstract_unit.rb: PROCESS_COUNT = (ENV["N"] || 4).to_i % ``` * Rails guide suggests using `PARALLEL_WORKERS` to specify the number of workers, not `N` https://guides.rubyonrails.org/testing.html#parallel-testing https://guides.rubyonrails.org/testing.html#parallel-testing ```ruby PARALLEL_WORKERS=15 rails test ```
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We don't do anything with it, so even if the user pass it no warning is print
-
由 Rafael França 提交于
Remove reference to global rails command in the docs
-
由 Rafael Mendonça França 提交于
-
由 Haroon Ahmed 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Switch to standardized argument name
-
由 Rafael Mendonça França 提交于
We only need to call this method once.
-
由 Jared Fine 提交于
-
- 27 12月, 2019 2 次提交
-
-
由 Rafael França 提交于
Allow AR::Enum definitions with boolean values
-
由 Rafael Mendonça França 提交于
Ruby 2.7 is not available yet.
-