Some end with a full stop, some don't. Let's have attention to detail
and make them uniform. I have chosen to add full stops according to
our documentation guidelines related to RDoc.

Remove not used requires from csrf helper file and test

These requires were added in a87b92db and the implementation changed in
2cdc1f0c, removing the need for them.

Remove ActiveSupport::TestCase#pending, use `skip` instead

This reverts commit ecac7c96.

Reason: Changelogs are not meant to be changed from docrails.

change AR default_timezone to :utc since it's the default for AR::Railtie

Replace regexp matching with a simple string manipulation.

Using regexp looks like overkill here and is also 2x slower.

             user     system      total        real
string   0.020000   0.000000   0.020000 (  0.016256)
regexp   0.030000   0.000000   0.030000 (  0.035360)

require "benchmark"

names = ("a".."z").map { |c| c + "a" * rand(5..10) + "=" * rand(0..1) }.map(&:to_sym)
puts names

n = 1000
Benchmark.bmbm do |x|
  x.report "string" do
    n.times do
      names.each do |name|
        string_name = name.to_s
        string_name.chomp!('=')
        string_name
      end
    end
  end

  x.report "regexp" do
    n.times do
      names.each do |name|
        name.to_s =~ /(.*)=$/
        $1
      end
    end
  end
end

Refactor NumberHelpers

From 2c667f69.

Thanks @pwnall for the heads-up.

Fix for log tailer when the log file doesn't exist.

Removed unused assigns from ActionView::Template::Error

No need to check html_safe? twice at number_to_percentage

This reverts commit be7d2248.

Fix documentation bug in Rails::Engine

They existed since initial rails commit by DHH but lost use a long time
ago

Bump mail 2.4.1