Signed-off-by: NCarl Lerche <carllerche@mac.com>

Revert "protected instance variables added to the deprecated config accessor

This reverts commit 4bce5ba6 and 0ee2d3c8.

Signed-off-by: NXavier Noria <fxn@hashref.com>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

They can be bundled. Just the git repos can't. Use rails/rack-mount for that.

This reverts commit ef6cdc97.

Instead of using a single `notify_observers` call for every callback type,
each observer now registers a unique callback for itself. Example:

  before_save :_notify_user_observer_for_before_save

  def _notify_user_observer_for_before_save
    observer.update(:before_save, self)
  end

Benefit: "before" callbacks halt when `observer.update` returns false.
This way, ActiveRecord observers can prevent records from saving.

[#4087 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
callback chains) and has extra features (like `changed`) that were never used.
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Benefits: test able to run independently, subclassing instead of changing the original Comment model
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NXavier Noria <fxn@hashref.com>

Fixing up some errors and changing the observer pattern to a much more simple and direct controller pattern

Revert "Add test case which check content type when rendering rjs" partial in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag

This reverts commit dc251389.

Signed-off-by: NXavier Noria <fxn@hashref.com>

Observers observing models with scopes defined will require the connection to be established.

Revert "logger added to the deprecated config accessor" we need a major refactor to get this working

This reverts commit 68f4e046.

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Revert "I18n guide: change ActionController by Action Controller in some places and fix code example in 2.4 section"

This reverts commit 002da9b6.

[#4398 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

I18n guide: change ActionController by Action Controller in some places and fix code example in 2.4 section