1. 04 1月, 2015 2 次提交
  2. 29 10月, 2014 2 次提交
    • X
      edit pass over all warnings · e595d91a
      Xavier Noria 提交于
      This patch uniformizes warning messages. I used the most common style
      already present in the code base:
      
      * Capitalize the first word.
      
      * End the message with a full stop.
      
      * "Rails 5" instead of "Rails 5.0".
      
      * Backticks for method names and inline code.
      
      Also, converted a few long strings into the new heredoc convention.
      e595d91a
    • X
      let's warn with heredocs · b3bfa361
      Xavier Noria 提交于
      The current style for warning messages without newlines uses
      concatenation of string literals with manual trailing spaces
      where needed.
      
      Heredocs have better readability, and with `squish` we can still
      produce a single line.
      
      This is a similar use case to the one that motivated defining
      `strip_heredoc`, heredocs are super clean.
      b3bfa361
  3. 20 10月, 2014 2 次提交
  4. 07 9月, 2014 1 次提交
  5. 06 9月, 2014 1 次提交
  6. 08 6月, 2014 1 次提交
  7. 16 5月, 2014 1 次提交
  8. 13 3月, 2014 2 次提交
    • A
      use the body proxy to freeze headers · 3df07d09
      Aaron Patterson 提交于
      avoid freezing the headers until the web server has actually read data
      from the body proxy.  Once the webserver has read data, then we should
      throw an error if someone tries to set a header
      3df07d09
    • A
      only write the jar if the response isn't committed · 77a09218
      Aaron Patterson 提交于
      when streaming responses, we need to make sure the cookie jar is written
      to the headers before returning up the stack. This commit introduces a
      new method on the response object that writes the cookie jar to the
      headers as the response is committed.  The middleware and test framework
      will not write the cookie headers if the response has already been
      committed.
      
      fixes #14352
      77a09218
  9. 05 3月, 2014 1 次提交
    • P
      Do note remove `Content-Type` when `render :body` · ed88a601
      Prem Sichanugrist 提交于
      `render :body` should just not set the `Content-Type` header. By
      removing the header, it breaks the compatibility with other parts.
      
      After this commit, `render :body` will returns `text/html` content type,
      sets by default from `ActionDispatch::Response`, and it will preserve
      the overridden content type if you override it.
      
      Fixes #14197, #14238
      
      This partially reverts commit 30473768.
      ed88a601
  10. 19 2月, 2014 2 次提交
    • P
      Add `#no_content_type` attribute to `AD::Response` · 30473768
      Prem Sichanugrist 提交于
      Setting this attribute to `true` will remove the content type header
      from the request. This is use in `render :body` feature.
      30473768
    • P
      Introduce `render :body` for render raw content · 103e18c8
      Prem Sichanugrist 提交于
      This is an option for sending a raw content back to browser. Note that
      this rendering option will unset the default content type and does not
      include "Content-Type" header back in the response.
      
      You should only use this option if you are expecting the "Content-Type"
      header to not be set. More information on "Content-Type" header can be
      found on RFC 2616, section 7.2.1.
      
      Please see #12374 for more detail.
      103e18c8
  11. 09 2月, 2014 1 次提交
  12. 01 2月, 2014 1 次提交
  13. 03 12月, 2013 1 次提交
  14. 01 9月, 2013 1 次提交
  15. 16 8月, 2013 1 次提交
  16. 29 6月, 2013 1 次提交
  17. 31 5月, 2013 1 次提交
    • S
      Add propery docs to ActionDispatch::Response [ci skip] · 8603bc06
      Steve Klabnik 提交于
      After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is
      a bit sparse. This class is useful when you're writing tests, as often you want to assert various
      things about the response that's coming back. Better docs would make this easier for people new
      to testing in Rails.
      
      I only added some descriptions for various properties that were defined, and mostly just a sentence
      or two. Most of these things are familliar if you're working with HTTP, but some words is better
      than no words at all.
      
      Hopefully further commits will fix up things that aren't just documentation.
      8603bc06
  18. 22 4月, 2013 1 次提交
  19. 16 2月, 2013 1 次提交
  20. 14 2月, 2013 1 次提交
  21. 27 1月, 2013 1 次提交
  22. 21 1月, 2013 1 次提交
  23. 16 1月, 2013 3 次提交
  24. 31 12月, 2012 1 次提交
  25. 05 12月, 2012 1 次提交
  26. 14 8月, 2012 1 次提交
  27. 09 8月, 2012 1 次提交
  28. 03 8月, 2012 2 次提交
  29. 30 7月, 2012 4 次提交