The #substitute_at gets an ActiveRecord::ConnectionAdapters::Column in #insert to match replacement in #exec_query.

Evaluate default scopes at the last possible moment in order to avoid problems with default scopes getting included into other scopes and then being unable to remove the default part via unscoped.

Deprecated support for passing hashes and relations to default_scope, in favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details.

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#5829 state:resolved]
Signed-off-by: NAndrew White <andyw@pixeltrix.co.uk>

Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries.

Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries.

Relation will delegate to AR::Base which already uses the Dynamic finders, so eliminate duplicate calls

ActiveRecord::Relation#primary_key should return a string, just like ActiveRecord::Base.primary_key does.

previously primary key value was always assigned nil which caused Oracle enhanced adapter failing tests

implicit_readonly is not set until records are loaded, just check readonly_value and then set readonly status.