1. 04 6月, 2019 1 次提交
    • C
      Do not clear deprecated initializer dependencies if using classic autoloader · bb3f24af
      Cliff Pruitt 提交于
      `Rails::Application::Finisher` defines a `:let_zeitwerk_take_over` initializer. This initializer is always run but it's statements are wrapped in a guard: `config.autoloader == :zeitwerk`.
      
      `Finisher` also defines a `initializer :warn_if_autoloaded` initializer with a `before: :let_zeitwerk_take_over` option which also always runs. This initializer unloads any constants autoloaded during initialization and displays a deprecation warning. This initializer does not account for `config.autoloader` being set to `:classic`.
      
      The problem is that this initializer changes the behavior of the classic autoloader. Constant autoloading from initializers is deprecated but the deprecation should not break existing applications which currently depend on autoloaded constants in initializers.
      
      This commit prevents the dependencies from being unloaded if the autoloader is not Zeitwerk. It also updates the deprecation warning, if the classic autoloader is enabled, to indicate that the constants would have been unloaded if Zeitwerk had been used.
      bb3f24af
  2. 03 6月, 2019 1 次提交
  3. 02 6月, 2019 2 次提交
  4. 01 6月, 2019 2 次提交
  5. 29 5月, 2019 4 次提交
  6. 28 5月, 2019 7 次提交
  7. 27 5月, 2019 1 次提交
  8. 26 5月, 2019 1 次提交
  9. 24 5月, 2019 2 次提交
  10. 23 5月, 2019 1 次提交
  11. 22 5月, 2019 2 次提交
    • R
      Merge pull request #36320 from XrXr/no-doc-prepend · fd8261a1
      Rafael França 提交于
      [CI skip] Put :nodoc: on method that raises NoMethodError
      fd8261a1
    • R
      Except SCHEMA SQLs in `capture_sql` · ec1e1717
      Ryuta Kamizono 提交于
      Testing the result of `capture_sql` is fragile, it is due to whether
      SCHEMA SQLs are executed or not depends on whether schema cache is
      filled or not.
      
      https://buildkite.com/rails/rails/builds/61248#a5b9dc59-ff0c-40c0-b56e-0895662fbc4c/993-1004
      https://buildkite.com/rails/rails/builds/61248#1157b389-f2c7-4554-b6e5-a37624a0e74a/996-1005
      
      I've confirmed all `capture_sql` use cases in our code base, all cases
      won't expect SCHEMA SQLs are included.
      
      ```
      % git grep -n capture_sql
      test/cases/associations/belongs_to_associations_test.rb:202:    sql = capture_sql { comment.post }
      test/cases/associations/belongs_to_associations_test.rb:204:    assert_not_equal sql, capture_sql { comment.post }
      test/cases/associations/has_many_associations_test.rb:169:    sql = capture_sql { post.comments.to_a }
      test/cases/associations/has_many_associations_test.rb:171:    assert_not_equal sql, capture_sql { post.comments.to_a }
      test/cases/associations/has_many_associations_test.rb:276:    expected_sql = capture_sql { author.thinking_posts.delete_all }
      test/cases/associations/has_many_associations_test.rb:281:    loaded_sql = capture_sql { author.thinking_posts.delete_all }
      test/cases/associations/has_many_associations_test.rb:289:    expected_sql = capture_sql { author.posts.delete_all }
      test/cases/associations/has_many_associations_test.rb:294:    loaded_sql = capture_sql { author.posts.delete_all }
      test/cases/associations/left_outer_join_association_test.rb:22:      queries = capture_sql do
      test/cases/associations/left_outer_join_association_test.rb:49:    queries = capture_sql { Author.left_outer_joins(:posts).to_a }
      test/cases/associations/left_outer_join_association_test.rb:54:    queries = capture_sql { Author.joins(:posts).left_outer_joins(:posts).to_a }
      test/cases/associations/left_outer_join_association_test.rb:60:    queries = capture_sql { Author.left_outer_joins({}).to_a }
      test/cases/associations/left_outer_join_association_test.rb:65:    queries = capture_sql { Author.left_outer_joins([]).to_a }
      test/cases/associations/left_outer_join_association_test.rb:78:    queries = capture_sql { Author.left_outer_joins(:essays).to_a }
      test/cases/associations_test.rb:384:    log = capture_sql do
      test/cases/associations_test.rb:399:    log = capture_sql do
      test/cases/associations_test.rb:414:    log = capture_sql do
      test/cases/associations_test.rb:429:    log = capture_sql do
      test/cases/associations_test.rb:444:    log = capture_sql do
      test/cases/associations_test.rb:459:    log = capture_sql do
      test/cases/reflection_test.rb:307:    expected_sql = capture_sql { hotel.recipes.to_a }
      test/cases/reflection_test.rb:312:    loaded_sql = capture_sql { hotel.recipes.to_a }
      test/cases/relation_test.rb:212:      queries = capture_sql { Author.joins(:posts).merge(Post.joins(:comments)).to_a }
      test/cases/relation_test.rb:232:      queries = capture_sql { Post.joins(:author, :categorizations).merge(Author.select(:id)).merge(categorizations_with_authors).to_a }
      test/cases/relation_test.rb:347:      log = capture_sql do
      test/cases/scoping/relation_scoping_test.rb:146:      log = capture_sql do
      test/cases/scoping/relation_scoping_test.rb:159:    log = capture_sql do
      test/cases/test_case.rb:33:    def capture_sql
      test/cases/test_case.rb:41:      capture_sql { yield }
      ```
      ec1e1717
  12. 21 5月, 2019 1 次提交
  13. 20 5月, 2019 1 次提交
  14. 19 5月, 2019 1 次提交
  15. 18 5月, 2019 1 次提交
  16. 17 5月, 2019 1 次提交
  17. 16 5月, 2019 2 次提交
  18. 15 5月, 2019 2 次提交
  19. 14 5月, 2019 2 次提交
  20. 13 5月, 2019 4 次提交
  21. 12 5月, 2019 1 次提交