- 29 5月, 2016 3 次提交
-
-
由 Prathamesh Sonpatki 提交于
- These initializers are new defaults for Rails 5 and newly generated apps do not need to change them. - Fixes #25181
-
由 Kasper Timm Hansen 提交于
Follow up to e45f388e.
-
由 Kasper Timm Hansen 提交于
When changing the generated integration tests to assert redirects with an absolute path this redirection check in `assert_redirected_to` against the absolute response location would now pass: https://github.com/rails/rails/blob/af245aaf3a1c447752a1b5895adddc66e5f73c00/actionpack/lib/action_dispatch/testing/assertions/response.rb#L55 Thus we'd break early instead of hitting `assert_operator` and have 2 fewer assertions per `assert_redirected_to` as `assert_operator` is composed of 2 assertions internally: https://github.com/seattlerb/minitest/blob/4e146b1515b19a5c474e39c174b037510f6dbc6e/lib/minitest/assertions.rb#L254-L258 Deduct 2 assertions for 2 redirects taking the expected count down by 4 in total for the two failing tests.
-
- 28 5月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Fixes #25180
-
- 21 5月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 18 5月, 2016 1 次提交
-
-
由 Jon Moss 提交于
Sorry, I missed a few places in my last PR. This should be the last of 'em
😬
-
- 17 5月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application - Now we will detect what javascript engine user is using and based on that we will generate either `.js` or `.coffee` version of the channel file. - This also needs a change in coffee-rails to override the `js_template` method. Related PR https://github.com/rails/coffee-rails/pull/72. - Currently coffee-rails gem sets `config.app_generators.javascript_engine` to `:coffee` and using this information we override the `js_template` to set the extension as `.coffee` in coffee-rails gem. - Using this approach, we can keep the `channel.js` and `channel.coffee` files in the Rails repository itself. - Additionally the `js_template` method can act as public interface for coffee-rails gem to hook into and change the extension to `.coffee` without maintaining the actual asset files. [Prathamesh Sonpatki, Matthew Draper]
-
- 07 5月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
It is related with https://github.com/rack/rack/commit/7b66d2cdb80a4d6b44fa8c61d92e25fbbda1f152
-
- 05 5月, 2016 1 次提交
-
-
由 Joe Rafaniello 提交于
[ci skip]
-
- 25 4月, 2016 2 次提交
-
-
由 yuuji.yaginuma 提交于
In order to prevent `OptionParser::ParseError` when specify the rake options to `routes` task.
-
由 yuuji.yaginuma 提交于
If run the test over the `rake` command, because of the test patterns is passed via `rake_run` method, do not need to be obtained from the argv. This probably fixes #24372.
-
- 24 4月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Followup of https://github.com/rails/rails/pull/24709.
-
- 23 4月, 2016 2 次提交
-
-
由 Andrew White 提交于
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will preserve the timezone of the receiver when converting to an instance of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we need to introduce a compatibility layer so that apps that upgrade do not break. New apps will have a config initializer file that defaults to match the new Ruby 2.4 behavior going forward. For information about the changes to Ruby see: https://bugs.ruby-lang.org/issues/12189 https://bugs.ruby-lang.org/issues/12271 Fixes #24617.
-
由 Vipul A M 提交于
-
- 22 4月, 2016 1 次提交
-
-
由 Mohit Natoo 提交于
-
- 19 4月, 2016 1 次提交
-
-
由 Vipul A M 提交于
-
- 18 4月, 2016 1 次提交
-
-
由 bogdanvlviv 提交于
-
- 16 4月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
`cable.js` is required for other Channels.
-
- 13 4月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4. - Based on the comment - https://github.com/rails/rails/issues/24418#issuecomment-205421995.
-
- 10 4月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
This was added in a4c358f8, but `config.assets` has been removed in 5172d933. Also, do not use env path to `Sprockets::Cache::FileStore` even `sprockets-rails`. ref: https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/railtie.rb#L129
-
- 08 4月, 2016 1 次提交
-
-
由 Jeroen Visser 提交于
* Updated syntax * Updated tests to match syntax
-
- 30 3月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- We need to pass the restart command to Puma so that it will use it while restarting the server. - Also made sure that all the options passed by user while starting the server are used in the generated restart command so that they will be used while restarting the server. - Besides that we need to remove the server.pid file for the previous running server because otherwise Rack complains about it's presence. - We don't care if the server.pid file does not exist. We only want to delete it if it exists. - This also requires some changes on Puma side which are being tracked here - https://github.com/puma/puma/pull/936. - Fixes #23910.
-
- 25 3月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
ActiveJob jobs now inherit from ApplicationJob by default. However, when updating to Rails 5 from the old Rails, since there is a possibility that ApplicationJob does not exist.
-
- 22 3月, 2016 3 次提交
-
-
由 Arthur Neves 提交于
[related #24243]
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
- 21 3月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
The default is that's false, caching even if you do not specify the caching option is determined not to use, and `tmp/caching-dev.txt` will be deleted. If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option, I think that in than good to so as not to do anything by default.
-
- 20 3月, 2016 1 次提交
-
-
由 Jon Moss 提交于
Due to that `ActionDispatch::Flash` (the flash API's middleware) is not included for API controllers, the `request.reset_session` method, which relies on there being a `flash=` method which is in fact defined by the middleware, was previously breaking. Similarly to how add46482 created a method to be overridden by the flash middleware in order to ensure non-breakage, this is how flashes are now reset. Fixes #24222
-
- 12 3月, 2016 2 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Followup of https://github.com/rails/rails/pull/24161.
-
由 Sen-Zhang 提交于
-
- 09 3月, 2016 2 次提交
-
-
由 claudiob 提交于
This commit comes from the comments made by @matthewd at https://github.com/rails/rails/pull/23795/files#r54469637 and by @rafaelfranca at https://github.com/rails/rails/pull/23795/files#r54609364 The idea is that if you type (for example) "rake db:migrate" in an AppGenerator, then this should actually invoke `rake db:migrate` on the command line, whereas if you type "rails_command db:migrate", this should invoke `rails db:migrate`.
-
由 Prathamesh Sonpatki 提交于
- While working on https://github.com/rails/rails/pull/22790 I found out that we pass `with_dispatchers: true` but it's not used at all by Rails. - We were passing `with_dispatchers: true` in few tests too but again it's not used by Rails.
-
- 08 3月, 2016 2 次提交
-
-
由 Genadi Samokovarov 提交于
-
由 Genadi Samokovarov 提交于
Between major versions 2 and 3, we hit a bug. It's fixed in version 3, however, the explicit 2.x requirement of `~> '2.0'` will prevent people from getting the fix with `bundle update` and they would have to explicitly set the constraint to `~> '3.0'`. For more information see: rails/web-console#178. I propose we drop the explicit version constraints in the Gemfile. Web Console has been relatively stable for the past couple of years, and I don't anticipate any major alterations, like we saw between major versions 1 and 2.
-
- 06 3月, 2016 1 次提交
-
-
由 Vipul A M 提交于
- Fixed test name for setting fallbacks to config.i18n.fallbacks = [{ :ca => :'es-ES' }]
-
- 05 3月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up to #24050.
-
- 04 3月, 2016 3 次提交
-
-
由 Mohit Natoo 提交于
-
由 Mohit Natoo 提交于
-
由 Mohit Natoo 提交于
-
- 03 3月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
-