- 17 6月, 2015 1 次提交
-
-
由 Diego Carrion 提交于
raise ActiveModel::MissingAttributeError when trying to access a relationship without the foreign key attribute fixes regression reported on #20253 ActiveRecord::Base#[] was not used cause of 8b954200
-
- 16 6月, 2015 17 次提交
-
-
由 Yves Senn 提交于
Small refactor on db:reset
-
由 Aaron Patterson 提交于
People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals.
-
由 Aaron Patterson 提交于
this way we don't have to mutate the instance (as much) when writing a rack response
-
由 Matthew Draper 提交于
Deprecate passing hash as first parameter into ActionController::Head
-
由 Arthur Nogueira Neves 提交于
Add missing spec and documentation for button_tag helper
-
由 Mehmet Emin İNAÇ 提交于
-
由 Arthur Nogueira Neves 提交于
Added test case for serial? method when sequence name is not quoted
-
由 Arthur Nogueira Neves 提交于
Removed not needed includes, As record_tag_helper is moved to a gem we..
-
由 Matthew Draper 提交于
Fix flakyness.
-
由 Kasper Timm Hansen 提交于
Brought on by my own stupidity :)
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Arthur Neves 提交于
db:reset should not prematurely load the environment, so, for instance, if there is any initializer that touches th DB, it will not touch that before droping it. Also this makes the code simpler. This changed was made back in 15fb4302 , not sure why. But I am pretty much sure we should do it like this, as drop and setup should load its dependencies tasks if necessary.
-
由 Arthur Nogueira Neves 提交于
[ci skip] Fix the Rails::Generators::NamedBase#template doc
-
由 Matthew Draper 提交于
Fix the message verifier encoding issue
-
由 Arthur Nogueira Neves 提交于
make sure to load_config for db:abort_if_pending_migrations
-
由 Robin Dupret 提交于
-
- 15 6月, 2015 11 次提交
-
-
由 Matthew Draper 提交于
Fix inflector test by using dup inflections when it needs to be changed
-
由 Roque Pinel 提交于
This is not something that is failing at the moment, but can do it eventually. I had the issue with db620812 as the HEAD and with the following change: ``` --- a/activesupport/test/inflector_test.rb +++ b/activesupport/test/inflector_test.rb @@ -101,6 +101,7 @@ class InflectorTest < ActiveSupport::TestCase def test_acronyms ActiveSupport::Inflector.inflections do |inflect| inflect.acronym("API") + inflect.acronym("HTM") inflect.acronym("HTML") inflect.acronym("HTTP") inflect.acronym("RESTful") ``` I was expecting only `test_acronyms` to fail, but with a specific `seed` others were also failing: `ruby -w -I"lib:test" test/inflector_test.rb --seed 4313`. Now, `inflections` instance is duplicated on `setup` and restored on `teardown`. I decided to benchmark and check the impact of the patch and it seems to me to be fine. ``` Calculating ------------------------------------- without changes 1.000 i/100ms with setup dup 1.000 i/100ms with block dup 1.000 i/100ms ------------------------------------------------- without changes 0.817 (± 0.0%) i/s - 5.000 in 6.119916s with setup dup 0.784 (± 0.0%) i/s - 4.000 with block dup 0.797 (± 0.0%) i/s - 4.000 ``` Where `with setup dup` duplicates on setup for each test and `with block` duplicates for just for tests that actually modify `inflections`.
-
由 Robin Dupret 提交于
* Fix a few remaining typos * Wrap lines to 80 chars * Fix the conversion from Textile to Markdown * Update the part about `Rack::Cache` which isn't included anymore and speak about Active Support's provided middleware * Remove references to out-of-date methods and middlewares (e.g. respond_with) and update the list of modules and middlewares to match the actual code-base. * Remove the middleware's description and links to the Rack guide
-
由 Yves Senn 提交于
[ci skip] The PostgreSQL 9.4 docs suggest to use `pgcrypto`. Howerver `create_table id: :uuid` will still default to `uuid_generate_v4()`
-
由 Yves Senn 提交于
This used to raise a `IrreversibleMigration` error (since #10437). However since `remove_index :table, :column` is probably the most basic use-case we should make it reversible again. Conflicts: activerecord/CHANGELOG.md
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Add RDoc about add_reference to ActiveRecord::Migration [ci skip]
-
由 Rafael Mendonça França 提交于
Updated bundler link [ci skip]
-
由 Roque Pinel 提交于
Since #13612, `template` is no longer being used to generate migrations.
-
由 839 提交于
-
由 Guillermo Iguaran 提交于
ActionDispatch::SSL should keep original header's behavior
-
- 14 6月, 2015 11 次提交
-
-
由 Roque Pinel 提交于
```ruby verifier = ActiveSupport::MessageVerifier.new('secret') verifier.verify("\xff") # => ArgumentError: invalid byte sequence in UTF-8 ```
-
由 Kasper Timm Hansen 提交于
Add missing "header" word in documentation of Token#authentication_request [ci skip]
-
由 Matthew Draper 提交于
Wrong documentation about Rails autoload on active_jobs_basics doc [ci skip]
-
由 Mehmet Emin İNAÇ 提交于
By default Rails automaticaly loads all files under the app directory
-
由 Fumiaki MATSUSHIMA 提交于
`ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`.
-
由 Prathamesh Sonpatki 提交于
-
由 Zachary Scott 提交于
Add gotcha to RDoc of collection_check_boxes
-
由 Zachary Scott 提交于
Extended 'Active Job Basics' guide with more detailed information
-
由 Kasper Timm Hansen 提交于
[ci skip] fix typo mistake
-
由 Andreas Metzger 提交于
Extended 'Active Job Basics' edge guide with more detailed information and an additional step [ci skip] Normalized use of 'queueing'/'queuing' in the document.
-
由 Kuldeep Aggarwal 提交于
-