- 14 4月, 2020 11 次提交
-
-
由 Josh 提交于
Previously, if `build_association` was called multiple times for a `has_one` association but never committed to the database, the first newly-associated record would trigger `touch` during the attempted removal of the record. For example: class Post < ActiveRecord::Base has_one :comment, inverse_of: :post, dependent: :destroy end class Comment < ActiveRecord::Base belongs_to :post, inverse_of: :comment, touch: true end post = Post.create! comment_1 = post.build_comment comment_2 = post.build_comment When `comment_2` is initialized, the `has_one` would attempt to destroy `comment_1`, triggering a `touch` on `post` from an association record that hasn't been committed to the database. This removes the attempt to delete an associated `has_one` unless it’s persisted.
-
由 Rafael Mendonça França 提交于
This deprecation is useless since the result is still an Error object and there is no way to fix the code to remove the deprecation. Let's just accept as a breaking change.
-
由 David Heinemeier Hansson 提交于
-
由 Eugene Kenny 提交于
Followup to e7514dc6.
-
由 Rafael França 提交于
Ignore Errno::ENOTEMPTY when calling AS::Cache::FileStore#clear with race conditions
-
由 Rafael França 提交于
Load XML Builder if it is not available
-
由 Derek Hammer 提交于
-
由 Rafael França 提交于
Document update for ActiveModel#errors
-
由 Rafael França 提交于
Fix perform_enqueued_jobs without a block inside other helpers
-
由 Étienne Barrié 提交于
assert_enqueued_with with a block ignores all the jobs enqueued before the block for its assertions by counting the number of jobs and dropping the n first elements from the Array, but since we're now mutating the Array in perform_enqueued_jobs without a block, it's broken. This uses another implementation which is correct when the array is mutated, by getting a duplicated array of jobs, then removing them from the original array. Similarly assert_enqueued_jobs with a block was using counts only, now keeps track of the specific jobs to count them at the end.
-
由 Rafael França 提交于
Reduce calls to get path info when finding routes
-
- 13 4月, 2020 1 次提交
-
-
由 Eugene Kenny 提交于
Followup to b94efe9f.
-
- 12 4月, 2020 8 次提交
-
-
由 Ryuta Kamizono 提交于
Fix random CI fail due to non-deterministic order
-
由 Jonathan Hefner 提交于
Example failure: https://buildkite.com/rails/rails/builds/68187#333e3624-ac0d-4b23-95b9-f068d9901093/1016-1028 These tests expect the 2nd Account fixture (with a NULL `firm_id`) to be in the first four rows of the result set, but that behavior is not guaranteed without an `order`.
-
由 Eugene Kenny 提交于
Remove reference to global rails command
-
由 Ryuta Kamizono 提交于
Do not expose association relation in the API doc [ci skip]
-
由 Ryuta Kamizono 提交于
Allow extra scoping in callbacks when create on association relation
-
由 Ryuta Kamizono 提交于
Remove dead code in tests
-
由 Kir Shatrov 提交于
-
由 Haroon Ahmed 提交于
-
- 11 4月, 2020 6 次提交
-
-
由 Kasper Timm Hansen 提交于
Add subsec to `ActiveSupport::TimeWithZone#inspect`
-
由 akinomaeni 提交于
Time.at(1498099140).in_time_zone.inspect => "Thu, 22 Jun 2017 02:39:00.000000000 UTC +00:00" Time.at(1498099140, 123456780, :nsec).in_time_zone.inspect => "Thu, 22 Jun 2017 02:39:00.123456780 UTC +00:00" Time.at(1498099140 + Rational("1/3")).in_time_zone.inspect => "Thu, 22 Jun 2017 02:39:00.333333333 UTC +00:00"
-
由 akinomaeni 提交于
-
由 Eugene Kenny 提交于
Remove ActiveRecord::DefineCallbacks module
-
由 Eileen M. Uchitelle 提交于
Fix db object to not return deprecated variable
-
由 eileencodes 提交于
Calling `db_config.config` was deprecated in #37185 in favor of `db_config.configuration_hash`. When returning the objects from `configurations` we should ensure the object returns the non-deprecated method. Before: ``` <ActiveRecord::DatabaseConfigurations::HashConfig:0x00007ff0f61696a0 @env_name="development", @name="primary", @config={:adapter=>"mysql2", :database=>"recipes_development"}> ``` After: ``` <ActiveRecord::DatabaseConfigurations::HashConfig:0x00007ff0f61696a0 @env_name="development", @name="primary", @configuration_hash={:adapter=>"mysql2", :database=>"recipes_development"}> ``` Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
- 10 4月, 2020 6 次提交
-
-
由 Ryuta Kamizono 提交于
#37523 has a regression that ignore extra scoping in callbacks when create on association relation. It should respect `klass.current_scope` even when create on association relation to allow extra scoping in callbacks. Fixes #38741.
-
由 Eugene Kenny 提交于
This module was added in 16ae3db5 to allow `ActiveRecord::AttributeMethods::Dirty` to define callbacks and still have its `_update_record` method wrapped by the version defined in `ActiveRecord::Callbacks`, so that updates in `before_update` callbacks are taken into account for partial writes. The callbacks that created this circular dependency were removed in 34f075fe, so we can move the callback definitions back to the `Callbacks` module.
-
由 jasonhl 提交于
-
由 Ryuta Kamizono 提交于
Reduce loops in head route matching
-
由 Ryuta Kamizono 提交于
`Association` and `AssociationRelation` are implementation details, I do not want to expose those internals in the API doc, and people basically should not rely on those internals. https://github.com/rails/rails/blob/8544c9c23687964ab754c06a7745215a5369a4e0/activerecord/lib/active_record/associations/association.rb https://github.com/rails/rails/blob/8544c9c23687964ab754c06a7745215a5369a4e0/activerecord/lib/active_record/association_relation.rb As a side note, `record.association(:name)` is also private API. https://github.com/rails/rails/blob/8544c9c23687964ab754c06a7745215a5369a4e0/activerecord/lib/active_record/associations.rb#L228-L240
-
由 Vinicius Stock 提交于
-
- 09 4月, 2020 8 次提交
-
-
由 Nick Soracco 提交于
From #38142 [Rafael Mendonça França + Nick Soracco]
-
由 Rafael França 提交于
`ActionView::Base.annotate_template_file_names` only annotates HTML
-
由 Rafael França 提交于
Add attribute_names method on errors
-
由 Rafael França 提交于
Update the Active Model error treated as hash deprecation warning
-
由 Adam Hess 提交于
This method replaces the `keys` method on `errors` as a way to get the error attribute names from the errors object without treating `errors` like a hash.
-
由 Adam Hess 提交于
This message more clearly communicates how to access the attribute and message keys that you would expect to get when using the previous API. before you might iterate over errors like, errors.each do |attribute, message| # My error code here end This message helps the user find the methods on error that match the previous API.
-
由 Rafael Mendonça França 提交于
-
由 Joel Hawksley 提交于
In testing https://github.com/rails/rails/pull/38848 in the GitHub monolith, we realized that we probably should only be annotating HTML output with these comments, at least in their current format. By passing `format` to `erb_implementation`, we set ourselves up to eventually support annotations for other formats as well.
-