- 29 6月, 2018 7 次提交
-
-
由 Rafael França 提交于
Note deliver_later_queue_name gotcha in ActionMailer guide
-
由 Rafael França 提交于
Incompatibility of Direct Uploads & Mirror Service
-
由 Stanislas Boyet 提交于
[ci skip] It adds a note to the Active Storage documentation regarding the use of Mirror Service not being compatible with the use of the Direct Uploads as described later on in the documentation, as described in issue #32732
-
由 Rafael França 提交于
Merge pull request #33254 from huacnlee/add-expires-in-option-support-for-redis-cache-store-increment-method Add :expires_in option support for RedisCacheStore increment/decrement method
-
由 Jason Lee 提交于
-
由 Matthew Draper 提交于
Refactor Previewer::PopplerPDFPreviewer#pdftoppm_exists?
-
由 utilum 提交于
Does not warn `instance variable @pdftoppm_exists not initialized`.
-
- 28 6月, 2018 10 次提交
-
-
由 Rafael França 提交于
Improve wording for form_with in Getting Started Guide
-
由 Rafael Mendonça França 提交于
This reverts commit 9d6bbf4e, reversing changes made to 5a1ea090. This method only works with block.
-
由 Anthony Crumley 提交于
[ci skip] Improved wording by making it clear the form_with helper method was being referenced in the first paragraph and that the second paragraph is a continuation of the form_with train of thought. Additionally, a connection was made to examples of the form_with usage being described.
-
由 Rafael Mendonça França 提交于
Allow configurable attribute name on `#has_secure_password`
-
由 Rafael França 提交于
Break guides menu 'Digging Deeper' section in two
-
由 Rafael França 提交于
Fix ActionMailer assert_enqueued_email_with
-
由 utilum 提交于
This list in the menu is currently long, and the order of the items not immediately obvious. I often find my self rescanning to find what I'm looking for, so I imagine that others do to.
-
由 Marcus Ilgner 提交于
The documentation for assert_enqueued_email_with states that it's supposed to work without a block yet it calls assert_enqueued_with which doesn't check whether a block was passed before calling `yield`
-
由 dikond 提交于
-
由 Ryuta Kamizono 提交于
Add tests for duration multiplication and division
-
- 27 6月, 2018 12 次提交
-
-
由 Ryuta Kamizono 提交于
Autoload Activejob::Arguments
-
由 alpaca-tc 提交于
-
由 alpaca-tc 提交于
-
由 Prem Sichanugrist 提交于
Add changelog entry for allow passing multiple exceptions to retry_on/discard_on (3110caec) [ci skip]
-
由 bogdanvlviv 提交于
Since it is changes of the public API, it seems valuable to add a mention about it to the changelog file. Follow up 3110caec
-
由 Aaron Patterson 提交于
Speed up homogeneous AR lists / reduce allocations
-
由 Aaron Patterson 提交于
-
由 Rafael França 提交于
Enable TESTOPTS in railties tests
-
由 Aaron Patterson 提交于
Now that `allocate` is removed, we need to define attribute methods in all "init" methods.
-
由 Aaron Patterson 提交于
* master: Call initialize after allocate Remove `ActiveSupport::Concern` from `ActiveRecord::Aggregations` Add example for no_touching? in active_record/no_touching for api docs [ci skip] Generate a new key for each service test
-
由 Aaron Patterson 提交于
Call initialize after allocate
-
由 Aaron Patterson 提交于
If someone calls allocate on the object, they'd better also call an initialization routine too (you can't expect allocate to do any initialization work). Before this commit, AR objects that are instantiated from the database would call `define_attribute_methods` twice.
-
- 26 6月, 2018 11 次提交
-
-
由 utilum 提交于
Unlike the other components' test suites, railties' currently ignores such useful options as `"--verbose"` or `"--name"`. This patch allows us to use them.
-
由 Ryuta Kamizono 提交于
`include Aggregations` no longer needs to invoke `extend Aggregations::ClassMethods` since 657060b5.
-
由 Ryuta Kamizono 提交于
Add example for no_touching? for api docs [ci skip]
-
由 Michael Munroe 提交于
There was no example code for ActiveRecord::NoTouching#no_touching?. This PR adds an example for the API docs.
-
由 Aaron Patterson 提交于
This commit speeds up allocating homogeneous lists of AR objects. We can know if the result set contains an STI column before initializing every AR object, so this change pulls the "does this result set contain an STI column?" test up, then uses a specialized instantiation function. This way we only have to check for an STI column once rather than N times. This change also introduces a new initialization function that is meant for use when allocating AR objects that come from the database. Doing this allows us to eliminate one hash allocation per AR instance. Here is a benchmark: ```ruby require 'active_record' require 'benchmark/ips' ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:" ActiveRecord::Migration.verbose = false ActiveRecord::Schema.define do create_table :users, force: true do |t| t.string :name t.timestamps null: false end end class User < ActiveRecord::Base; end 2000.times do User.create!(name: "Gorby") end Benchmark.ips do |x| x.report("find") do User.limit(2000).to_a end end ``` Results: Before: ``` [aaron@TC activerecord (master)]$ be ruby -I lib:~/git/allocation_tracer/lib speed.rb Warming up -------------------------------------- find 5.000 i/100ms Calculating ------------------------------------- find 56.192 (± 3.6%) i/s - 285.000 in 5.080940s ``` After: ``` [aaron@TC activerecord (homogeneous-allocation)]$ be ruby -I lib:~/git/allocation_tracer/lib speed.rb Warming up -------------------------------------- find 7.000 i/100ms Calculating ------------------------------------- find 72.204 (± 2.8%) i/s - 364.000 in 5.044592s ```
-
由 George Claghorn 提交于
Sidestep Google Cloud Storage's restrictive per-object rate limit.
-
由 Aaron Patterson 提交于
Lazily add `Aggregations` to `composed_of` models
-
由 George Claghorn 提交于
-
由 Aaron Patterson 提交于
`composed_of` is a fairly rare method to call on models. This commit adds the `Aggregations` module to models that call `composed_of` so that models that *don't* call `composed_of` don't need to instantiate the `aggregation_cache` hash. This saves one hash allocation per model instance that doesn't use `composed_of`
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
The "join" affix in `table_alias_for` was added 12 years ago at 02d34440 to address poor alias tracking. `AssociationScope` no longer uses the "join" suffixed alias since 0408e212 and had been removed at a1ec8b5b. `table_alias_for` is the last place that using the useless legacy suffixed alias, but we can't remove the suffix since some test cases directly refers the alias name by `where` with string literal, so at least removing the suffix would break our test cases. (e.g. https://github.com/rails/rails/blob/b2eb1d1c55a59fee1e6c4cba7030d8ceb524267c/activerecord/test/cases/associations/has_and_belongs_to_many_associations_test.rb#L699-L731).
-