1. 20 9月, 2015 3 次提交
  2. 18 9月, 2015 1 次提交
  3. 17 9月, 2015 1 次提交
  4. 12 9月, 2015 1 次提交
  5. 09 9月, 2015 2 次提交
  6. 08 9月, 2015 3 次提交
  7. 07 9月, 2015 3 次提交
  8. 06 9月, 2015 3 次提交
  9. 03 9月, 2015 2 次提交
    • B
      HasManyAssociation: moved half of counter cache code to reflection · 712fc8a5
      Bogdan Gusiev 提交于
      Current implementation has a lot of utility methods that accept
      reflection call a lot of methods on it and exit.
      
      E.g. has_counter_cache?(reflection)
      
      It causes confusion and inability to cache result of the method even
      through it always returns the same result for the same reflection
      object.
      It can be done easier without access to the association context
      by moving code into reflection itself.
      
      e.g. reflection.has_counter_cache?
      
      Reflection is less complex object than association so moving code there
      automatically makes it simplier to understand.
      712fc8a5
    • A
      Remove unnecessary require in associations_test.rb · 715e845f
      akihiro17 提交于
      715e845f
  10. 02 9月, 2015 1 次提交
  11. 30 8月, 2015 1 次提交
    • Y
      Make revert of `disable_extension` to work · 68eb6ca6
      yui-knk 提交于
      This is fix of #11826 which miss to add `disable_extension` to
      `ReversibleAndIrreversibleMethods`. So `CommandRecorder#method_missing`
      catches `change_column_default` and @delegate's method is called.
      68eb6ca6
  12. 28 8月, 2015 2 次提交
  13. 27 8月, 2015 2 次提交
  14. 26 8月, 2015 2 次提交
  15. 25 8月, 2015 1 次提交
    • Y
      Make `change_column_default` to work · c90008a8
      yui-knk 提交于
      This is fix of #20018 which removes `change_column_default` from
      array, so `CommandRecorder#method_missing` catches
      `change_column_default` and @delegate's method is called.
      
      This PR
      
      * fix this bug
      * define `ReversibleAndIrreversibleMethods` const making clear
        which this array means to prevent these miss
      c90008a8
  16. 24 8月, 2015 3 次提交
    • S
      Further fix failing tests caused by #21350 · 35161a7f
      Sean Griffin 提交于
      35161a7f
    • S
      Fix failing tests caused by #21350 · 4f39d897
      Sean Griffin 提交于
      4f39d897
    • A
      Only nullify persisted has_one target associations · 19b168e6
      Agis- 提交于
      Since after 87d1aba3 `dependent: :destroy` callbacks on has_one
      assocations run *after* destroy, it is possible that a nullification is
      attempted on an already destroyed target:
      
          class Car < ActiveRecord::Base
            has_one :engine, dependent: :nullify
          end
      
          class Engine < ActiveRecord::Base
            belongs_to :car, dependent: :destroy
          end
      
          > car = Car.create!
          > engine = Engine.create!(car: car)
          > engine.destroy! # => ActiveRecord::ActiveRecordError: cannot update a
          >   destroyed record
      
      In the above case, `engine.destroy!` deletes `engine` and *then* triggers the
      deletion of `car`, which in turn triggers a nullification of `engine.car_id`.
      However, `engine` is already destroyed at that point.
      
      Fixes #21223.
      19b168e6
  17. 23 8月, 2015 2 次提交
  18. 20 8月, 2015 1 次提交
  19. 18 8月, 2015 2 次提交
  20. 13 8月, 2015 3 次提交
  21. 08 8月, 2015 1 次提交