- 09 2月, 2019 2 次提交
-
-
由 Guillermo Iguaran 提交于
-
由 Ryuta Kamizono 提交于
`Association#target=` invokes `loaded!`, so we no longer need to call the `loaded!` explicitly. Since Preloader is private API, we don't guarantee that it behaves like older version as long as using Preloader directly. But this refactoring fortunately also fix the Preloader compatibility issue #35195. Closes #35195.
-
- 08 2月, 2019 14 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix elapsed time calculations
-
由 Ryuta Kamizono 提交于
Fix `relation.exists?` with giving both `distinct` and `offset`
-
由 Ryuta Kamizono 提交于
Bugfix has_many association #size when ids reader is cached and assoc…
-
由 bogdanvlviv 提交于
I've found a few places in Rails code base where I think it makes sense to calculate elapsed time more precisely by using `Concurrent.monotonic_time`: - Fix calculation of elapsed time in `ActiveSupport::Cache::MemoryStore#prune` - Fix calculation of elapsed time in `ActiveRecord::ConnectionAdapters::ConnectionPool::Queue#wait_poll` - Fix calculation of elapsed time in `ActiveRecord::ConnectionAdapters::ConnectionPool#attempt_to_checkout_all_existing_connections` - Fix calculation of elapsed time in `ActiveRecord::ConnectionAdapters::Mysql2Adapter#explain` See https://docs.ruby-lang.org/en/2.5.0/Process.html#method-c-clock_gettime https://blog.dnsimple.com/2018/03/elapsed-time-with-ruby-the-right-way Related to 7c454214
-
由 Ryuta Kamizono 提交于
The `distinct` affects (reduces) rows of the result, so it is important part when both `distinct` and `offset` are given. Replacing SELECT clause to `1 AS one` and removing `distinct` and `order` is just optimization for the `exists?`, we should not apply the optimization for that case. Fixes #35191.
-
由 Bogdan Gusiev 提交于
-
由 Ryuta Kamizono 提交于
Relation is not best place to do this.
-
由 Ryuta Kamizono 提交于
Address test_belongs_to_does_not_use_order_by failure
-
由 Yasuo Honda 提交于
Address `test_belongs_to_does_not_use_order_by` failure due to checking order by for metadata queries Also, `test_has_one_does_not_use_order_by` should not check metadata queries. Fixes #35098
-
由 Eileen M. Uchitelle 提交于
Finish rename of database_operations to database_resolver_context
-
由 John Hawthorn 提交于
-
由 John Hawthorn 提交于
-
由 Eileen M. Uchitelle 提交于
Improve naming in DatabaseSelector
-
由 John Hawthorn 提交于
-
- 07 2月, 2019 17 次提交
-
-
由 Ryuta Kamizono 提交于
Fix `relation.create` to avoid leaking scope to initialization block and callbacks
-
由 Ryuta Kamizono 提交于
`relation.create` populates scope attributes to new record by `scoping`, it is necessary to assign the scope attributes to the record and to find STI subclass from the scope attributes. But the effect of `scoping` is class global, it was caused undesired behavior that pollute all class level querying methods in initialization block and callbacks (`after_initialize`, `before_validation`, `before_save`, etc), which are user provided code. To avoid the leaking scope issue, restore the original current scope before initialization block and callbacks are invoked. Fixes #9894. Fixes #17577. Closes #31526.
-
由 Ryuta Kamizono 提交于
Don't use `false` as special value to skip to find inherited scope, we could use `skip_inherited_scope = true`, and move `_scoping` back on Relation.
-
由 Aaron Patterson 提交于
Move compiled ERB to an AV::Base subclass
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Revert "Remove finalizer and configuration" This reverts commit 9e7b4a3173788ea43b11e74a4d2f69a5f1565daa.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Then we don't need the extra module.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Now we can throw away the subclass and the generated methods will get GC'd too
-
由 Pratik 提交于
-
由 John Hawthorn 提交于
We're already in the resolver, we call this class "operations" in the middleware, so we should use the same naming here.
-
由 John Hawthorn 提交于
This is more consistent with Resolver, which has build called. This allows using a Proc instead of a class, which could be nice if you need to vary switching logic based on the request in a more ad-hoc way (ie. check if it is an API request).
-
- 06 2月, 2019 7 次提交
-
-
由 Ryuta Kamizono 提交于
Fix `CollectionProxy#concat` to return self by alias it to `#<<`
-
由 Yuji Yaginuma 提交于
Improve execution time of railties' test
-
由 Yuya Tanaka 提交于
Formerly it was returning arguments (`records` array).
-
由 Yuji Yaginuma 提交于
Update terminal-to-html inline images url in ScreenshotHelper documentation
-
由 betterzega 提交于
-
由 yuuji.yaginuma 提交于
To avoid running require individually.
-
由 yuuji.yaginuma 提交于
For avoid to affect tests. Also, `action_text:install` task execute `yarn add`. This is an expensive and should be avoided if it is not needed.
-