Deprecated support for passing hashes and relations to default_scope, in favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details.

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

This reverts commit 45c233ef.
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Add interpolation of association conditions back in, in the form of proc { ... } rather than instance_eval-ing strings

Correctly update counter caches on deletion for has_many :through [#2824 state:resolved]. Also fixed a bunch of other counter cache bugs in the process, as once I fixed this one others started appearing like nobody's business.

AssociationCollection#to_ary should definitely dup the target! Also changed #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping.

We shouldn't be using scoped.scoping { ... } to build associated records, as this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved]

has_many associations with :dependent => :delete_all should update the counter cache when deleting records

reloading an association will properly set attributes of instantiated objects. Thanks Brian Palmer [#5802 state:resolved]

if association is already loaded and if a find operation is performed on the already loaded association list with an empty hash then do not perform another sql

[#5972 state:resolved]

- persisted? is the API defined in ActiveModel
- makes it easier for extension libraries to conform to ActiveModel APIs
  without concern for whether the extended object is specifically
  ActiveRecord

[#5927 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

AssociationCollection#include? working properly for objects added with build method [#3472 state:resolved]

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

While creating a new record using has_many create method default scope of child should be respected.

author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them

fixed joining of attributes when using find_or_create_by with multiple attributes through an association
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

count method should not take options if it is operated on has_many association which has finder_sql or counter_sql

[#2395 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#5076 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

(as otherwise was failing under JRuby and oracle_enhanced adapter)

[#4645 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Fix for get_ids when including a belongs_to association on a has_many association [#2896 state:resolved]
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

[#2627 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

I think it may of broke the build. Lets see.

This reverts commit 49e943c4.

Conflicts:

	activerecord/test/cases/associations/has_many_associations_test.rb

Due to the ordering of the returning result set, the test fails under the postgresql adapter. Order results by id prior to checking the first item

[#3542 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

In the current stable, ActiveRecord::Associations::AssociationProxy#method_missing calls yield() if a block is given, causing the block to always be evaluated in its calling context. However, in the case of instance_eval, correct behavior requires that the block be passed directly to the @target, rather than being evaluated inside a different block. Incidentally, this also simplifies the code slightly.

[#3412 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Changed ActiveRecord to use new callbacks and speed up observers by only notifying events that are actually being consumed.
Signed-off-by: NJoshua Peek <josh@joshpeek.com>