- 24 9月, 2016 2 次提交
-
-
由 Michael Hoy 提交于
Fixes #26602 Relevant method documentation: https://github.com/rails/rails/blob/abe3da9f12710ea85be69b17172bef41220037fc/actionpack/lib/action_dispatch/testing/integration.rb#L14-L43
-
由 Aaron Patterson 提交于
Return true if attribute is not changed for update_attribute
-
- 23 9月, 2016 4 次提交
-
-
由 Prathamesh Sonpatki 提交于
- If the attribute is not changed, then update_attribute does not run SQL query, this effectively means that no change was made to the attribute. - This change was made in https://github.com/rails/rails/commit/0fcd4cf5 to avoid a SQL call. - But the change resulted into `nil` being returned when there was no change in the attribute value. - This commit corrects the behavior to return true if there is no change in attribute value. This is same as previous behavior of Rails 4.2 plus benefit of no additional SQL call. - Fixes #26593.
-
由 Vipul A M 提交于
fix formatting of `define_callbacks` doc [ci skip]
-
由 yuuji.yaginuma 提交于
Single backticks don't work with rdoc.
-
由 Arthur Nogueira Neves 提交于
Fix memoization bug on ActionDispatch::TestRequest#request_method=
-
- 22 9月, 2016 2 次提交
-
-
由 Kir Shatrov 提交于
TestRequest have been overrriding request_method setter since 2009, but the actual implementation in Request (not TestRequest) has been changed since that. Now it's also using @request_method instance variable to keep the state. The override in TestRequest have not been calling `super`, which caused a bug that after accessing #requst_method the value was memoized and then we've never been able to change it anymore: ``` req = ActionDispatch::TestRequest.create puts "was: #{req.request_method}" # memoized here req.request_method = "POST" puts "became: #{req.request_method}" ``` output: ``` was: GET became: GET ``` Since the whole purpose of overriding the setter in TestRequest is to upcase it, I'm changing it to `super(method.to_s.upcase)`
-
由 Richard Schneeman 提交于
add check of argument
-
- 21 9月, 2016 3 次提交
-
-
由 Jon Moss 提交于
[ci skip] Replace to closing tag
-
由 Andrey Molchanov 提交于
-
由 Vijay Dev 提交于
-
- 20 9月, 2016 6 次提交
-
-
由 Andrew White 提交于
Restore missing Gemfile.lock entries
-
由 Ryuta Kamizono 提交于
These lines were lost in https://github.com/rails/rails/commit/12d5c210#diff-e79a60dc6b85309ae70a6ea8261eaf95L191.
-
由 Jon Moss 提交于
fix link to `resque` [ci skip]
-
由 yuuji.yaginuma 提交于
`1-x-stable` branch does not exist, `master` is 1.x branch. Ref: http://words.steveklabnik.com/rescuing-resque-again
-
由 Rafael França 提交于
Always store errors details information with symbols
-
由 Rafael Mendonça França 提交于
When the association is autosaved we were storing the details with string keys. This was creating inconsistency with other details that are added using the `Errors#add` method. It was also inconsistent with the `Errors#messages` storage. To fix this inconsistency we are always storing with symbols. This will cause a small breaking change because in those cases the details could be accessed as strings keys but now it can not. The reason that we chose to do this breaking change is because `#details` should be considered a low level object like `#messages` is. Fix #26499. [Rafael Mendonça França + Marcus Vieira]
-
- 19 9月, 2016 3 次提交
-
-
由 Santiago Pastorino 提交于
Reduce array allocation when `where` with passed hash
-
由 Kasper Timm Hansen 提交于
use rails command in restart task test
-
由 yuuji.yaginuma 提交于
-
- 18 9月, 2016 3 次提交
-
-
由 Kasper Timm Hansen 提交于
Remove unnecessry `alias uniq distinct` for collection association
-
由 Jon Moss 提交于
[ci skip] Fixed commas according to Oxford comma in rdoc and guides
-
由 Andrey Molchanov 提交于
-
- 17 9月, 2016 14 次提交
-
-
由 Eileen M. Uchitelle 提交于
Rename variable name that returning `type_for` to `type` from `column`
-
由 Eileen M. Uchitelle 提交于
Clear attribute changes after handling locking
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Fix bad examples in rdoc
-
由 Andrey Molchanov 提交于
-
由 yuuji.yaginuma 提交于
`#fetch_multi` in case did not cache hit, to write a cache using the block value. https://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache.rb#L383..L384 Therefore, block is a need to pass always, I think should check first.
-
由 प्रथमेश Sonpatki 提交于
fix formatting of `Cache::Store#fetch` [ci skip]
-
由 yuuji.yaginuma 提交于
Single backticks don't work with rdoc.
-
由 Rafael França 提交于
Fix small grammar issue introduced in #26382
-
由 Jon Moss 提交于
[ci skip]
-
由 Rafael França 提交于
improve error message when include assertions fail
-
由 Michael Grosser 提交于
assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
-
由 Rafael França 提交于
Update ActiveModel::Dirty Doc to be simpler to understand
-
由 Rafael França 提交于
Rename test to match what it does
-
由 Rafael França 提交于
DRYing duplicate methods
-
- 16 9月, 2016 3 次提交
-
-
由 Louis-Michel Couture 提交于
-
由 Andrey Molchanov 提交于
-
由 Arthur Neves 提交于
[fixes #26441]
-