- 08 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
-
- 07 6月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Adjusted tests instead.
-
- 04 6月, 2016 6 次提交
-
-
由 Prathamesh Sonpatki 提交于
Update the documentation of new_framework_defaults file with more details about old apps and how you can upgrade to new defaults. [Kasper Timm Hansen, Prathamesh Sonpatki]
-
由 Prathamesh Sonpatki 提交于
Fix minor regression about old apps not getting per_form_csrf and request_forgery_protection configs - Earlier per_form_csrf_tokens and request_forgery_protection config files were generated for old apps upgraded to Rails 5. - But when we collapsed all initializers into one file, the entire file does not get created for old apps. - This commit fixes it and also changes values for all new defaults for old apps so that they will not break. - Also added a test for `rails app:update`.
-
由 Prathamesh Sonpatki 提交于
- Move real new default options to the top of the file. - After that club together all the options which were added to keep backward compatibility. So all of them will get only one header. - Based on https://github.com/rails/rails/pull/25231#issuecomment-222945173.
-
由 Eileen M. Uchitelle 提交于
Fix sqlite3 test failure
-
由 Ryuta Kamizono 提交于
Sqlite3 test failure is due to 66ebbc49.
-
由 Arthur Neves 提交于
We were declaring in a few tests, which depending of the order load will cause an error, as the super class could change. see https://github.com/rails/rails/commit/ac1c4e141b20c1067af2c2703db6e1b463b985da#commitcomment-17731383
-
- 03 6月, 2016 8 次提交
-
-
由 Eileen M. Uchitelle 提交于
[skip ci] Fix grammar
-
由 Abhishek Jain 提交于
-
由 Vijay Dev 提交于
Conflicts: guides/source/action_cable_overview.md
-
由 Yves Senn 提交于
Add i18n_validation_test
-
由 Arthur Nogueira Neves 提交于
[skip ci] Make header bullets consistent in engines.md
-
由 Alex Kitchens 提交于
-
由 Sean Griffin 提交于
Fix debug helper test
-
由 Matthew Draper 提交于
Properly support reloading for Action Cable channels
-
- 02 6月, 2016 9 次提交
-
-
由 Sean Griffin 提交于
We are currently using `%e` which adds a space before the result if the digit is a single number. This leads to strings like `February 2, 2016` which is undesireable. I've opted to replace with 0 padding instead of removing the padding entirely, to preserve compatibility for those relying on the fact that the width is constant, and to be consistent with time formatting. Fixes #25251.
-
由 Ryuta Kamizono 提交于
-
由 Sean Griffin 提交于
As part of refactoring mutation detection to be more performant, we introduced the concept of `original_value` to `Attribute`. This was not overridden in `Attribute::Uninitialized` however, so assigning ot an uninitialized value and calling `.changed?` would raise `NotImplementedError`. We are using a sentinel value rather than checking the result of `original_attribute.initialized?` in `changed?` because `original_value` might go through more than one node in the tree. Fixes #25228
-
由 Vipul A M 提交于
add missing "as" to Engines doc page [ci skip]
-
由 Antonio Felguerez 提交于
it reads a bit awkwardly without it.
-
由 Sean Griffin 提交于
Currently CI is broken due to 56a61e0c and c4cb6862. This occurred because the failures are not present on SQLite which is what I normally run locally before pushing. The optimizations to our YAML size were dropping mutations, as `with_type` didn't set the previous value if it'd already been read (that method was never really designed to be used with values on individual objects, it was previously only used for defaults). I'm questioning whether there's a better place to be handling the exclusion of the type, but this will fix the failing build. Additionally, there was a bug in `remove_foreign_key` if you passed it an options hash containing `to_table`. This now occurs whenever removing a reference, as we always normalize to a hash. [Sean Griffin & Ryuta Kamizono]
-
由 Jon Moss 提交于
Not sure why #25239, but it had good changes, so I'm manually pulling in the changes. [Jon Moss, Rajat Bansal] [ci skip]
-
由 sukesan1984 提交于
add active record uniqueness validation test for { on: [:create, :update] } condition.
-
由 Matthew Draper 提交于
-
- 01 6月, 2016 12 次提交
-
-
由 Arun Agrawal 提交于
fix typo [ci skip]
-
由 Rajat Bansal 提交于
-
由 David Heinemeier Hansson 提交于
Collapse all new default initializers into a single file
-
由 Prathamesh Sonpatki 提交于
- Adjusted tests also for this new behavior. - Based on the discussion in https://github.com/rails/rails/pull/25184#issuecomment-222454583.
-
由 Matthew Draper 提交于
-
由 Sean Griffin 提交于
This reduces the size of a YAML encoded Active Record object by ~80% depending on the number of columns. There were a number of wasteful things that occurred when we encoded the objects before that have resulted in numerous wins - We were emitting the result of `attributes_before_type_cast` as a hack to work around some laziness issues - The name of an attribute was emitted multiple times, since the attribute objects were in a hash keyed by the name. We now store them in an array instead, and reconstruct the hash using the name - The types were included for every attribute. This would use backrefs if multiple objects were encoded, but really we don't need to include it at all unless it differs from the type at the class level. (The only time that will occur is if the field is the result of a custom select clause) - `original_attribute:` was included over and over and over again since the ivar is almost always `nil`. We've added a custom implementation of `encode_with` on the attribute objects to ensure we don't write the key when the field is `nil`. This isn't without a cost though. Since we're no longer including the types, an object can find itself in an invalid state if the type changes on the class after serialization. This is the same as 4.1 and earlier, but I think it's worth noting. I was worried that I'd introduce some new state bugs as a result of doing this, so I've added an additional test that asserts mutation not being lost as the result of YAML round tripping. Fixes #25145
-
由 Jon Moss 提交于
- The `Project` model should have been removed in 46893929. - The superfluous require was added in 605c6455. Closes #25215 Signed-off-by: NJeremy Daer <jeremydaer@gmail.com>
-
由 Jeremy Daer 提交于
[Action Cable] Add `WebSocket` and `logger` configuration options
-
由 Javan Makhmali 提交于
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
[Javan Makhmali, Jon Moss]
-
由 Sean Griffin 提交于
The code incorrectly assumes that the option was written as `foreign_key: true`, but that is not always the case. This now mirrors the behavior of reverting `add_foreign_key`. The code was changed to use kwargs while I was touching it, as well. This could really use a refactoring to go through the same code paths as `add_refernce` in the future, so we don't duplicate default values. Fixes #25169
-
- 31 5月, 2016 3 次提交
-
-
由 Jeremy Daer 提交于
Action Cable: Tune Sauce Labs tests
-
由 Sean Griffin 提交于
Do not include default column limit in schema.rb
-
由 Sean Griffin 提交于
Prior to this change, we would get collisions if Active Record objects of different classes with the same ID were used as keys of the same hash. It bothers me slightly that we have to allocate inside of this method, but Ruby doesn't provide any way to hash multiple values without allocation
-