- 31 3月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
* add leading `#` before `=>` since hash rocket is valid Ruby code * add backticks * remove trailing spaces * and more
-
由 Aaron Patterson 提交于
RFC: Introduce Template::File
-
- 30 3月, 2019 19 次提交
-
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
[ci skip] Fix typo directores -> directories
-
由 Abhay Nikam 提交于
-
由 Xavier Noria 提交于
During initialization, the eager load paths of engines are unshifted into AS::Dependencies.autoload_paths. After that, the collection is frozen. (See the initializers in railties/lib/rails/engine.rb.) Hence, there is no eager load path that is not an autoload path too, and so the array difference in the deleted code is always an empty array. Just do nothing.
-
由 Xavier Noria 提交于
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Updated docs to reflect index: true option not available as column modifier
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Add ActiveRecord::Relation#extract_associated method to the active_record_querying.md
-
由 Abhay Nikam 提交于
-
由 Abhay Nikam 提交于
-
由 David Heinemeier Hansson 提交于
* Add `ActiveRecord::Relation#extract_associated` for extracting associated records from a relation
-
由 Ryuta Kamizono 提交于
Type cast falsy boolean symbols on boolean attribute as false
-
由 Ryuta Kamizono 提交于
Before 34cc301f, type casting by boolean attribute when querying is a no-op, so finding by truthy boolean string (i.e. `where(value: "true") # => value = 'true'`) didn't work as expected (matches it to FALSE in MySQL #32624). By type casting is ensured, a value on boolean attribute is always serialized to TRUE or FALSE. In PostgreSQL, `where(value: :false) # => value = 'false'` was a valid SQL, so 34cc301f is a regresson for PostgreSQL since all symbol values are serialized as TRUE. I'd say using `:false` is mostly a developer's mistake (user's input basically comes as a string), but `:false` on boolean attribute is serialized as TRUE is not a desirable behavior for anybody. This allows falsy boolean symbols as false, i.e. `klass.create(value: :false).value? # => false` and `where(value: :false) # => value = FALSE`. Fixes #35676.
-
由 Rafael França 提交于
Merge pull request #35792 from abhaynikam/35789-follow-up-to-update-test-description-for-i18n-customize-full-message Updated the test description for i18n-customize-full-message after rename in #35789
-
由 Abhay Nikam 提交于
-
由 Rafael França 提交于
Add rich_text field to model generators
-
由 Rafael França 提交于
Rename `i18n_full_message` config option to `i18n_customize_full_message`
-
由 प्रथमेश Sonpatki 提交于
-
由 Prathamesh Sonpatki 提交于
- I feel `i18n_customize_full_messages` explains the meaning of the config better. - Followup of https://github.com/rails/rails/pull/32956
-
- 29 3月, 2019 6 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix annotated typo
-
由 Prathamesh Sonpatki 提交于
-
由 Chris Oliver 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Display a more helpful error message when an ERB template has a Ruby syntax error.
-
- 28 3月, 2019 11 次提交
-
-
由 Matthew Draper 提交于
sub, sub!, gsub, and gsub! should set back references
-
由 Ryuta Kamizono 提交于
[ci skip] Fixed testing guides typo `fourty` -> `forty`
-
由 Shailesh Kalamkar 提交于
-
由 Rafael França 提交于
Fix bug in Range comparisons when comparing to excluded-end Range
-
由 Owen Stephens 提交于
Before: ```ruby (1..10).cover?(1...11) => false ``` After: ```ruby (1..10).cover?(1...11) => true ``` See https://git.io/fjTtz for the commit against Ruby core that added support for Range arguments, with similar handling of this case.
-
由 Rafael França 提交于
Remove :all symbol from Mime::ALL
-
由 John Hawthorn 提交于
.all isn't a valid file extension, so it shouldn't used as a symbol. This also makes Mime::ALL better match how */* is parsed from an Accept header.
-
由 John Hawthorn 提交于
The previous behaviour of render file: was essentially the same as render template:, except that templates can be specified as an absolute path on the filesystem. This makes sense for historic reasons, but now render file: is almost exclusively used to render raw files (not .erb) like public/404.html. In addition to complicating the code in template/resolver.rb, I think the current behaviour is surprising to developers. This commit deprecates the existing "lookup a template from anywhere" behaviour and replaces it with "render this file exactly as it is on disk". Handlers will no longer be used (it will render the same as if the :raw handler was used), but formats (.html, .xml, etc) will still be detected (and will default to :plain). The existing render file: behaviour was the path through which Rails apps were vulnerable in the recent CVE-2019-5418. Although the vulnerability has been patched in a fully backwards-compatible way, I think it's a strong hint that we should drop the existing previously-vulnerable behaviour if it isn't a benefit to developers.
-
由 Rafael França 提交于
Prohibit sneaky custom params from being drawn (Fix #30467)
-
由 Ryuta Kamizono 提交于
Fix preloader to never reset associations in case they are already loaded
-
由 Matthew Draper 提交于
Stop encoding in secure_compare for speedup
-
- 27 3月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
We have a test case for `collation_connection` session variable, so it should not be changed in any other test. Fixes #35458.
-
由 Rafael França 提交于
Aligned the order of the arguments of render_template and render_with_layout
-