- 21 7月, 2014 2 次提交
-
-
由 Yves Senn 提交于
[ci skip] Fix code in Routing Guide
-
由 yuuji.yaginuma 提交于
-
- 20 7月, 2014 5 次提交
-
-
由 Rafael Mendonça França 提交于
Conflicts: actionpack/test/abstract_unit.rb
-
由 Rafael Mendonça França 提交于
We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
-
由 Rafael Mendonça França 提交于
Missing test for form values before type cast
-
由 Eugene Gilburg 提交于
-
由 Rafael Mendonça França 提交于
Some ActionView renderer refactors
-
- 19 7月, 2014 12 次提交
-
-
由 Yves Senn 提交于
Fixed typo in comment [ci skip]
-
由 Yves Senn 提交于
Make create_join_table use the same logic as HABTM reflections
-
由 Steve 提交于
-
由 Eugene Gilburg 提交于
-
由 Eugene Gilburg 提交于
-
由 Eugene Gilburg 提交于
-
由 Rafael Mendonça França 提交于
Fixes to request method test.
-
由 Rafael Mendonça França 提交于
Additional help messaging to help the user resolve a conflicted migration
-
由 Godfrey Chan 提交于
Cleanup + CHANGELOG for pr #14886
-
由 Arthur Neves 提交于
Also cleanup test a bit [related #14886] [related #14743]
-
由 Earl J St Sauver 提交于
The entire 127.0.0.0/8 range is assigned to the loopback address, not only 127.0.0.0/24. This patch allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8 loopback address. The only place that the #local? method was previously under test was in the show_expectations_test.rb file. I don't particularly like that that's implicitly where this code is under test, and I feel like I should move some of that testing code into the test/dispatch/request_test.rb file, but I wanted some feedback first. Credit goes to @sriedel for discovering the issue and adding the patch.
-
由 Stefan Kanev 提交于
Before this change, create_join_table would not remove the common prefix in the join table name, unlike ActiveRecord::Reflections. A HABTM between Music::Artist and Music::Record would use a table music_artists_records, while create_join table would create music_artists_music_records.
-
- 18 7月, 2014 21 次提交
-
-
由 Jim Jones 提交于
-
由 Matthew Draper 提交于
Dont swallow errors when bad alias_method
-
由 Robin Dupret 提交于
Even if this is not exactly the same, let's add a new-line character instead of two spaces. While it's specified in the Markdown specs that adding spaces at the end of the line creates a break-line tag, this is a brittle approach as people may remove them saving the file on certain editors.
-
由 Yves Senn 提交于
Prefer to pass block when logging.
-
由 Guo Xiang Tan 提交于
The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
-
由 Guo Xiang Tan 提交于
Since we're stubbing the request, the test is actually just asserting that `@method = env['REQUEST_METHOD']`. In order to the test against the methodoverride middleware, we should test it against an actual request. However, Rack is already covering this scenario so we can remove this test.
-
由 Guo Xiang Tan 提交于
There is already another test covering Request#request_method. This test should cover Request#method.
-
由 Guo Xiang Tan 提交于
-
由 Guo Xiang Tan 提交于
The current test is asserting against an outdated version of Request#method where HEAD requests are treated as GET requests.
-
由 Jim Jones 提交于
Added additional help messaging when there's scaffolding being generated and a migration already exists for the resource. The user is now alerted that they are able to skip the conflicted migration file via the --skip option.
-
由 Aaron Patterson 提交于
(I think)
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
this test case had a race condition where it could download data multiple times. We'll download the data once at class load.
-
由 Aaron Patterson 提交于
this prevents the array from being dumped as a DRbObject so we can reduce communication with the server. the reporter should always exist on the server side, so we don't have to worry about GC
-
由 Matthew Draper 提交于
Check for valid options in validate method
-
由 sonnym 提交于
This change prevents a certain class of user error which results when mistakenly using the `validate` class method instead of the `validates` class method. Only apply when all arguments are symbols, because some validations use the `validate` method and pass in additional options, namely the `LenghValidator` via the `ActiveMode::Validations::validates_with` method.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
These tests were passing before because the precision were not using to cast the value. Not it is being used so it would fail on sqlite3
-
由 Rafael Mendonça França 提交于
One of the branches is using a proc to check if the value respond_to a method so it is better to not do case comparations
-