- 14 7月, 2012 23 次提交
-
-
由 Rafael Mendonça França 提交于
Avoid to call send(store_attribute) twice.
-
由 kennyj 提交于
-
由 Xavier Noria 提交于
Added time related req files to AS core_ext #6896
-
由 Aaron Cruz 提交于
This way you can `require 'active_record/core_ext/time'` for example I see these libs are available through `active_record/time` but not individually
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Conflicts: activerecord/test/cases/query_cache_test.rb
-
由 Jeremy Cole 提交于
Conflicts: activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
-
由 Jeremy Cole 提交于
Prepared statements (prepare/execute/close) were being used unnecessarily when no bind variables were present, and disabling prepared statement using prepared_statements:false was principally broken. While bind variables were correctly substituted with prepared_statements:false, the prepared statement interface was still used, costing an extra two round trips per query. In addition to making this behavioral change, I also cleaned up the internals of exec_stmt and exec_without_stmt so that they behave the same (calling log and constructing the ActiveRecord::Result in the same way). Moving the check for binds.empty? to exec_query also will mean that several code paths explicitly calling exec_without_stmt could be cleaned up to once again call exec_query instead. I have also left the check for binds.empty? in exec_stmt, since it is not a private method and could be called directly with an empty binds array. For the sake of clarity in this patch, I have not made those changes. = The previous behavior = When issuing a Foo.find(1) with prepared_statements:true, the bind variable is present in the prepared query, and execute shows a value passed: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Prepare SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = ? LIMIT 1 Execute SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Close stmt Quit When issuing a Foo.find(1) with prepared_statements:false, the bind variable has already been removed and substituted with the value, but the prepared statement interface is used anyway: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Prepare SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Execute SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Close stmt Quit = With this patch applied = When issuing a Foo.find(1) with prepared_statements:true, the bind variable is present in the prepared query, and execute shows a value passed: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Prepare SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = ? LIMIT 1 Execute SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Close stmt Quit When issuing a Foo.find(1) with prepared_statements:false, the bind variable has been removed and substituted with the value, and the query interface is used instead of the prepared statement interface: Connect root@localhost on rails_test Query SET SQL_AUTO_IS_NULL=0 Statistics Query SHOW FULL FIELDS FROM `foos` Query SHOW TABLES LIKE 'foos' Query SHOW CREATE TABLE `foos` Query SELECT `foos`.* FROM `foos` WHERE `foos`.`id` = 1 LIMIT 1 Quit
-
由 Jon Leighton 提交于
-
由 Rafael Mendonça França 提交于
[tiny fixes] Remove more duplicated code.
-
由 kennyj 提交于
-
由 kennyj 提交于
-
由 Rafael Mendonça França 提交于
Remove duplicated code in the AR::Store.
-
由 Xavier Noria 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 kennyj 提交于
-
由 Xavier Noria 提交于
Add note about needing mysql superuser for unit tests.
-
由 Katrina Owen 提交于
-
由 Katrina Owen 提交于
-
由 Xavier Noria 提交于
Add documentation for ActiveRecord::Observer.
-
由 Katrina Owen 提交于
The instructions about configuration covered only rails-specific usage.
-
由 Jon Leighton 提交于
-
- 13 7月, 2012 7 次提交
-
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
-
由 Xavier Noria 提交于
-
由 Vijay Dev 提交于
add second t to overwritten
-
由 Evan Travers 提交于
fixing a misspelling in the documentation
-
- 11 7月, 2012 10 次提交
-
-
由 Vijay Dev 提交于
Fix code comment to reflect its intent.
-
由 Selem Delul 提交于
-
由 Carlos Antonio da Silva 提交于
Add teardown method to AR::Mig::RenameTableTest
-
由 Robb Kidd 提交于
Dry up reseting the renamed table after each test. Also made use of the AR::Base.connection object already available from AR::MigrationTest#connection.
-
由 Piotr Sarnacki 提交于
-
由 Piotr Sarnacki 提交于
When someone sends malformed authorization header, like: Authorization: Token foobar given token should be just ignored and resource should not be authorized, instead of raising error. Before this patch controller would return 401 header only for well formed tokens, like: Authorization: Token token=foobar and would return 500 in former case.
-
由 Carl Lerche 提交于
-
由 Rafael Mendonça França 提交于
Fixed bug creating invalid HTML in select options
-
由 Aaron Patterson 提交于
Rename default sequence when table is renamed? [AR:postgres]
-
由 Rusty Geldmacher 提交于
When a select tag is created for a field with errors, then the inserted options will errantly have a <div class="field_with_errors"> wrapping them.
-