1. 17 7月, 2014 5 次提交
  2. 15 7月, 2014 2 次提交
  3. 14 7月, 2014 1 次提交
  4. 10 7月, 2014 1 次提交
    • C
      Include missing module in tag_helper · 05fde24e
      Carlos Antonio da Silva 提交于
      Since 68574151 we are using #safe_join to
      join the content when an Array is given, so we must include the dependent
      module here to make sure it's available when this module is used alone.
      
      This was making Simple Form tests to fail with current master due to the
      missing dependency.
      05fde24e
  5. 04 7月, 2014 1 次提交
  6. 01 7月, 2014 2 次提交
  7. 30 6月, 2014 1 次提交
  8. 29 6月, 2014 1 次提交
    • M
      Rename options param of #time_ago_in_words to match API change · 4e1dc112
      Max Kramer 提交于
      Rename `include_seconds_or_options` to `options` to match 6b9356a4 (which removed the deprecation introduced by #6077).  This has no functional impact because the parameter is passed directly through, but makes it clearer that the parameter no longer supports a boolean as input.
      4e1dc112
  9. 26 6月, 2014 1 次提交
    • L
      remove Set.new from DetailsKey::get, impacts rendering overhead performance · 4955c04e
      Luke Gruber 提交于
      Using ruby-prof, I noticed that Set#add had the largest 'self time'
      percentage (5% of the overall time spent rendering) when
      benchmarking the rendering of a small cached ERB template that was 3
      lines long. It turns out it was from this line. I don't believe the
      Set is necessary, either. Removing this line increases the rendering
      ips using Benchmark::ips accordingly.
      4955c04e
  10. 25 6月, 2014 1 次提交
    • G
      Deal with regex match groups in excerpt · 124f88ea
      Gareth Rees 提交于
      Original implementation has bugs if the regex contains a match group.
      
      Example:
      
          excerpt('This is a beautiful? morning', /\b(beau\w*)\b/i, :radius => 5)
          Expected: "...is a beautiful? mor..."
          Actual: "...is a beautifulbeaut..."
      
      The original phrase was being converted to a regex and returning the text
      either side of the phrase as expected:
      
          'This is a beautiful? morning'.split(/beautiful/i, 2)
          # => ["This is a ", "? morning"]
      
      When we have a match with groups the match is returned in the array.
      
      Quoting the ruby docs: "If pattern is a Regexp, str is divided where the
      pattern matches. [...] If pattern contains groups, the respective matches will
      be returned in the array as well."
      
          'This is a beautiful? morning'.split(/\b(beau\w*)\b/iu, 2)
          # => ["This is a ", "beautiful", "? morning"]
      
      If we assume we want to split on the first match – this fix makes that
      assumption – we can pass the already assigned `phrase` variable as the place
      to split (because we already know that a match exists from line 168).
      
      Originally spotted by Louise Crow (@crowbot) at
      https://github.com/mysociety/alaveteli/pull/1557
      124f88ea
  11. 20 6月, 2014 3 次提交
  12. 17 6月, 2014 2 次提交
  13. 14 6月, 2014 3 次提交
  14. 13 6月, 2014 1 次提交
  15. 12 6月, 2014 1 次提交
  16. 11 6月, 2014 3 次提交
  17. 10 6月, 2014 1 次提交
  18. 07 6月, 2014 3 次提交
  19. 05 6月, 2014 3 次提交
  20. 03 6月, 2014 2 次提交
    • A
      call `capture` fewer times from `form_for` · e2a97adb
      Aaron Patterson 提交于
      e2a97adb
    • A
      drastically reduce object allocations · 8899503f
      Aaron Patterson 提交于
      before this change, we were allocating AS::SafeBuffer objects that were
      being interpolated in to a string, so the safe buffer object was being
      thrown away.  This change only allocates a string (vs a string *and* a
      safebuffer) and interpolates the string.
      
      On my test application, this reduced the AS::SafeBuffer objects from
      1527k per request to about 500 per request.
      8899503f
  21. 01 6月, 2014 1 次提交
  22. 31 5月, 2014 1 次提交