- 24 5月, 2014 21 次提交
-
-
由 Rafael Mendonça França 提交于
Move parsing of PG sql strings for defaults out of column
-
由 Rafael Mendonça França 提交于
add test cases for negative position in Array#from
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
Remove duplicated setup in test
-
由 Rafael Mendonça França 提交于
Remove AD::Journey::Formatter#verify_required_parts!
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Rafael Mendonça França 提交于
[ci skip] Remove Duration#=== when we drop support for 2.0.0-p353
-
由 Akshay Vishnoi 提交于
-
由 Rafael Mendonça França 提交于
Inline type cast method for PG points
-
由 Rafael Mendonça França 提交于
Change typecasting unit tests to test type objects directly
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Sean Griffin 提交于
There's no longer type casting behavior of any kind inside of `Column` for the general case. These tests can be made clearer by testing the type objects directly.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
stop hardcoding hash keys and use the accessors provided on the request object.
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
-
- 23 5月, 2014 19 次提交
-
-
由 Sean Griffin 提交于
-
由 Kuldeep Aggarwal 提交于
-
由 Viktar Basharymau 提交于
Nobody uses this private method, maybe it is a leftover from some old refactoring. Let's delete it.
-
由 Rafael Mendonça França 提交于
We need to test if the same method defined more than once only register one subscriber for it. We can safelly remove because the method body is the same and Subscriber use method_added hook for register the subscriber.
-
由 Aaron Patterson 提交于
Fixed serialization for records with an attribute named `format`.
-
由 Yves Senn 提交于
Reorder query in active record query of rails guide [ci skip]
-
由 peeyush 提交于
-
由 Aaron Patterson 提交于
this decouples our code from the env hash a bit.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Godfrey Chan 提交于
2d73f5ae forces AR to enter the `define_attribute_methods` method whenever it instantiate a record from the `init_with` entry point. This is a potential performance hotspot, because `init_with` is called from all `find*` family methods, and `define_attribute_methods` is slow because it tries to acquire a lock on the mutex everytime it is entered. By using [DCL](http://en.wikipedia.org/wiki/Double-checked_locking), we can avoid grabbing the lock most of the time when the attribute methods are already defined (the common case). This is made possible by the fact that reading an instance variable is an atomic operation in Ruby. Credit goes to Aaron Patterson for pointing me to DCL and filling me in on the atomicity guarantees in Ruby. [*Godfrey Chan*, *Aaron Patterson*]
-
由 Godfrey Chan 提交于
* * * This bug can be triggered when serializing record R (the instance) of type C (the class), provided that the following conditions are met: 1. The name of one or more columns/attributes on C/R matches an existing private method on C (e.g. those defined by `Kernel`, such as `format`). 2. The attribute methods have not yet been generated on C. In this case, the matching private methods will be called by the serialization code (with no arguments) and their return values will be serialized instead. If the method requires one or more arguments, it will result in an `ArgumentError`. This regression is introduced in d1316bb1. * * * Attribute methods (e.g. `#name` and `#format`, assuming the class has columns named `name` and `format` in its database table) are lazily defined. Instead of defining them when a the class is defined (e.g. in the `inherited` hook on `ActiveRecord::Base`), this operation is deferred until they are first accessed. The reason behind this is that is defining those methods requires knowing what columns are defined on the database table, which usually requires a round-trip to the database. Deferring their definition until the last-possible moment helps reducing unnessary work, especially in development mode where classes are redefined and throw away between requests. Typically, when an attribute is first accessed (e.g. `a_book.format`), it will fire the `method_missing` hook on the class, which triggers the definition of the attribute methods. This even works for methods like `format`, because calling a private method with an explicit receiver will also trigger that hook. Unfortunately, `read_attribute_for_serialization` is simply an alias to `send`, which does not respect method visibility. As a result, when serializing a record with those conflicting attributes, the `method_missing` is not fired, and as a result the attribute methods are not defined one would expected. Before d1316bb1, this is negated by the fact that calling the `run_callbacks` method will also trigger a call to `respond_to?`, which is another trigger point for the class to define its attribute methods. Therefore, when Active Record tries to run the `after_find` callbacks, it will also define all the attribute methods thus masking the problem. * * * The proper fix for this problem is probably to restrict `read_attribute_for_serialization` to call public methods only (i.e. alias `read_attribute_for_serialization` to `public_send` instead of `send`). This however would be quite risky to change in a patch release and would probably require a full deprecation cycle. Another approach would be to override `read_attribute_for_serialization` inside Active Record to force the definition of attribute methods: def read_attribute_for_serialization(attribute) self.class.define_attribute_methods send(attribute) end Unfortunately, this is quite likely going to cause a performance degradation. This patch therefore restores the behaviour from the 4-0-stable branch by explicitly forcing the class to define its attribute methods in a similar spot (when records are initialized). This should not cause any extra roundtrips to the database because the `@columns` should already be cached on the class. Fixes #15188.
-
由 Rafael Mendonça França 提交于
Removed not used code
-
由 Aaron Patterson 提交于
-
由 Kris Kemper 提交于
-
由 Rafael Mendonça França 提交于
Push limit to type objects
-
由 Sean Griffin 提交于
Columns and injected types no longer have any conditionals based on the format of SQL type strings! Hooray!
-
由 Rafael Mendonça França 提交于
Push precision to type objects
-