1. 24 5月, 2014 21 次提交
  2. 23 5月, 2014 19 次提交
    • S
      Remove duplicated setup in test · 4f8ba6aa
      Sean Griffin 提交于
      4f8ba6aa
    • K
      3920d644
    • V
      Remove AD::Journey::Formatter#verify_required_parts! · fd035692
      Viktar Basharymau 提交于
      Nobody uses this private method, maybe it is a leftover from some old
      refactoring. Let's delete it.
      fd035692
    • R
      Remove warning remeving the method before redefining · 2fdddcee
      Rafael Mendonça França 提交于
      We need to test if the same method defined more than once only register
      one subscriber for it. We can safelly remove because the method body is
      the same and Subscriber use method_added hook for register the
      subscriber.
      2fdddcee
    • A
      Merge pull request #15240 from chancancode/fix_attribute_methods · 8b364715
      Aaron Patterson 提交于
      Fixed serialization for records with an attribute named `format`.
      8b364715
    • Y
      Merge pull request #15251 from peeyushsingla/master · 0cc7f02b
      Yves Senn 提交于
      Reorder query in active record query of rails guide [ci skip]
      0cc7f02b
    • P
      resolved reorder issue in rails active record guide · 42c55b93
      peeyush 提交于
      42c55b93
    • A
      stop using PARAMETERS_KEY, and use the accessor on the request object · 9ca4839a
      Aaron Patterson 提交于
      this decouples our code from the env hash a bit.
      9ca4839a
    • A
      1b76c7e9
    • A
      just return path parameters · 8d8ebe3d
      Aaron Patterson 提交于
      8d8ebe3d
    • A
      use symbol keys for path_parameters · 925bd975
      Aaron Patterson 提交于
      925bd975
    • G
      Avoid slowing down AR object initialization · 28d52c59
      Godfrey Chan 提交于
      2d73f5ae forces AR to enter the `define_attribute_methods` method whenever it
      instantiate a record from the `init_with` entry point. This is a potential
      performance hotspot, because `init_with` is called from all `find*` family
      methods, and `define_attribute_methods` is slow because it tries to acquire
      a lock on the mutex everytime it is entered.
      
      By using [DCL](http://en.wikipedia.org/wiki/Double-checked_locking), we can
      avoid grabbing the lock most of the time when the attribute methods are already
      defined (the common case). This is made possible by the fact that reading an
      instance variable is an atomic operation in Ruby.
      
      Credit goes to Aaron Patterson for pointing me to DCL and filling me in on the
      atomicity guarantees in Ruby.
      
      [*Godfrey Chan*, *Aaron Patterson*]
      28d52c59
    • G
      Fixed serialization for records with an attribute named `format`. · 2d73f5ae
      Godfrey Chan 提交于
      * * *
      
      This bug can be triggered when serializing record R (the instance) of type C
      (the class), provided that the following conditions are met:
      
      1. The name of one or more columns/attributes on C/R matches an existing private
         method on C (e.g. those defined by `Kernel`, such as `format`).
      
      2. The attribute methods have not yet been generated on C.
      
      In this case, the matching private methods will be called by the serialization
      code (with no arguments) and their return values will be serialized instead. If
      the method requires one or more arguments, it will result in an `ArgumentError`.
      
      This regression is introduced in d1316bb1.
      
      * * *
      
      Attribute methods (e.g. `#name` and `#format`, assuming the class has columns
      named `name` and `format` in its database table) are lazily defined. Instead of
      defining them when a the class is defined (e.g. in the `inherited` hook on
      `ActiveRecord::Base`), this operation is deferred until they are first accessed.
      
      The reason behind this is that is defining those methods requires knowing what
      columns are defined on the database table, which usually requires a round-trip
      to the database. Deferring their definition until the last-possible moment helps
      reducing unnessary work, especially in development mode where classes are
      redefined and throw away between requests.
      
      Typically, when an attribute is first accessed (e.g. `a_book.format`), it will
      fire the `method_missing` hook on the class, which triggers the definition of
      the attribute methods. This even works for methods like `format`, because
      calling a private method with an explicit receiver will also trigger that hook.
      
      Unfortunately, `read_attribute_for_serialization` is simply an alias to `send`,
      which does not respect method visibility. As a result, when serializing a record
      with those conflicting attributes, the `method_missing` is not fired, and as a
      result the attribute methods are not defined one would expected.
      
      Before d1316bb1, this is negated by the fact that calling the `run_callbacks`
      method will also trigger a call to `respond_to?`, which is another trigger point
      for the class to define its attribute methods. Therefore, when Active Record
      tries to run the `after_find` callbacks, it will also define all the attribute
      methods thus masking the problem.
      
      * * *
      
      The proper fix for this problem is probably to restrict `read_attribute_for_serialization`
      to call public methods only (i.e. alias `read_attribute_for_serialization` to
      `public_send` instead of `send`). This however would be quite risky to change
      in a patch release and would probably require a full deprecation cycle.
      
      Another approach would be to override `read_attribute_for_serialization` inside
      Active Record to force the definition of attribute methods:
      
         def read_attribute_for_serialization(attribute)
           self.class.define_attribute_methods
           send(attribute)
         end
      
      Unfortunately, this is quite likely going to cause a performance degradation.
      
      This patch therefore restores the behaviour from the 4-0-stable branch by
      explicitly forcing the class to define its attribute methods in a similar spot
      (when records are initialized). This should not cause any extra roundtrips to
      the database because the `@columns` should already be cached on the class.
      
      Fixes #15188.
      2d73f5ae
    • R
      Merge pull request #15257 from jetthoughts/remove_redundant_code · 0e7e4f79
      Rafael Mendonça França 提交于
      Removed not used code
      0e7e4f79
    • A
      b89190f0
    • K
      a2f13e15
    • R
      Merge pull request #15259 from sgrif/sg-push-limit-to-types · b318758b
      Rafael Mendonça França 提交于
      Push limit to type objects
      b318758b
    • S
      Push limit to type objects · 11199051
      Sean Griffin 提交于
      Columns and injected types no longer have any conditionals based on the
      format of SQL type strings! Hooray!
      11199051
    • R
      Merge pull request #15256 from sgrif/sg-push-precision-to-types · 8e4d014a
      Rafael Mendonça França 提交于
      Push precision to type objects
      8e4d014a