1. 01 9月, 2016 4 次提交
    • S
      Remove deprecated handling of PG Points · b347156b
      Sean Griffin 提交于
      There are some minor changes to the point type as I had forgotten that
      this will affect the behavior of `t.point` in migrations and the schema
      dumper so we need to handle those as well.
      
      I'll say this again so I can convince myself to come up with a better
      structure... TYPES SHOULD NOT CARE ABOUT SCHEMA DUMPING AND WE NEED TO
      BETTER SEPARATE THESE.
      b347156b
    • S
      Merge pull request #26332 from y-yagi/use_specified_message_in_assert_changes · 6236cb7e
      Sean Griffin 提交于
      use `message` that specified in argument to error message
      6236cb7e
    • S
      Revert "Extract `PredicateBuilder::CaseSensitiveHandler`" · 84efde74
      Sean Griffin 提交于
      This reverts commit 3a1f6fe7.
      
      This commit takes the code in a direction that I am looking to avoid.
      The predicate builder should be purely concerned with AST construction
      as it matters to methods like `where`. Things like case sensitivity
      should continue to be handled elsewhere.
      84efde74
    • S
      Attempt to maintain encoding for arrays of strings with PG · 7ba3a48d
      Sean Griffin 提交于
      I still think that this is something that should be handled in the pg
      gem, but it's not going to end up happening there so we'll do it here
      instead. Once we bump to pg 0.19 we can pass the encoding to the
      `encode` method instead.
      
      This issue occurs because C has no concept of encoding (or strings,
      really). The bytes that we pass here when sending the value to the
      database will always be interpreted as whatever encoding the connection
      is currently configured to use. That means that roundtripping to the
      database will lose no information
      
      However, after assigning we round trip through our type system without
      hitting the database. The only way that we can do the "correct" thin
      here would be to actually give a reference to the connection to the
      array type and have it check the current value of the connection's
      encoding -- which I'm strongly opposed to. We could also pass in the
      encoding when it's constructed, but since that can change independently
      of the type I'm not a huge fan of that either.
      
      This feels like a reasonable middle ground, where if we have an array of
      strings we simply use the encoding of the string we're given.
      
      Fixes #26326.
      7ba3a48d
  2. 31 8月, 2016 15 次提交
  3. 30 8月, 2016 21 次提交