- 21 4月, 2017 9 次提交
-
-
由 Isaac Betesh 提交于
Fixes #24032
-
由 Rafael França 提交于
Prevent double firing the before save callback of new object when the parent association saved in the callback
-
由 Jon Moss 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
Prevent double firing the before save callback of new object when the parent association saved in the callback Related #18155, #26661, 268a5bb0, #27434, #27442, and #28599. Originally #18155 was introduced for preventing double insertion caused by the after save callback. But it was caused the before save issue (#26661). 268a5bb0 fixed #26661, but it was caused the performance regression (#27434). #27442 added new record to `target` before calling callbacks for fixing #27434. But it was caused double firing before save callback (#28599). We cannot add new object to `target` before saving the object. This is improving #18155 to only track callbacks after `save`. Fixes #28599.
-
由 Rafael Mendonça França 提交于
Fix quoting in db:create grant all statement.
-
由 Rafael França 提交于
Add error logging to Active Job
-
由 Rafael França 提交于
Fixes Hash.from_xml with frozen strings for all engines
-
由 Josh Nussbaum 提交于
-
由 Rafael França 提交于
Namespace CSS selectors on error pages
-
- 20 4月, 2017 19 次提交
-
-
由 Jan Krutisch 提交于
The css selectors on the generated error pages are too broad (for example `text-align: center` on `body` and thus bleed out to the following pages (say, by pressing the back button) when using Turbolinks. This commit namespaces all the selectors.
-
由 Kasper Timm Hansen 提交于
Remove outdated comment
-
The database name used in the test would have actually shown this if it had tried to execute on a real Mysql instead of being stubbed out (dashes in database names needs quotes).
-
由 Marion Bouguet 提交于
Since 3aee9126, this class hasn't inherited from Array.
-
由 Rafael França 提交于
Don't fallback to utf8mb3 after MySQL 8.0.0
-
由 Rafael França 提交于
`cache_key` respects the limit in a relation even if a relation is not loaded
-
由 Rafael França 提交于
Don't generate system test files if `skip_system_test` option is specified
-
由 Rafael Mendonça França 提交于
Closes #28382 Closes #28651
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Log any write errors originating from the socket
-
由 Rafael França 提交于
Fix migration tasks
-
由 Rafael França 提交于
Include gem name and deprecation horizon when calling the deprecation behaviors
-
由 Willem van Bergen 提交于
Send deprecation horizon and gem name as arguments to deprecation heavier handler, and make sure they are used for the ActiveSupport::Notifications message.
-
由 Rafael França 提交于
Improve the upgrade path of Strong Parameters
-
由 bogdanvlviv 提交于
Raise error on the movement of migrations when the current migration does not exist.
-
由 Jon Moss 提交于
Sentence had some awkward grammar and was kind of confusing, tried to make it easier to understand what it was trying to say :) [ci skip]
-
由 bogdanvlviv 提交于
-
由 Vijay Dev 提交于
-
由 Rafael França 提交于
[ci skip] Changed plain text to NOTE.
-
- 19 4月, 2017 12 次提交
-
-
由 Andrew White 提交于
Use `quoted_scope` rather than `@config[:database]` to respect current database
-
由 vishalzambre 提交于
-
由 Ryuta Kamizono 提交于
I'm not sure why `Mysql2VirtualColumnTest#test_schema_dumping` passed previously. But now the test not pass at least in MariaDB 10.1.9. I fixed the regexp to respect `COLLATE`. ``` % ARCONN=mysql2 be ruby -w -Itest test/cases/adapters/mysql2/virtual_column_test.rb -n test_schema_dumping Using mysql2 Run options: -n test_schema_dumping --seed 7131 F Finished in 0.466304s, 2.1445 runs/s, 4.2890 assertions/s. 1) Failure: Mysql2VirtualColumnTest#test_schema_dumping [test/cases/adapters/mysql2/virtual_column_test.rb:55]: Expected /t\.virtual\s+"upper_name",\s+type: :string,\s+as: "UPPER\(`name`\)"$/i to match "# This file is auto-generated from the current state of the database. Instead\n# of editing this file, please use the migrations feature of Active Record to\n# incrementally modify your database, and then regenerate this schema definition.\n#\n# Note that this schema.rb definition is the authoritative source for your\n# database schema. If you need to create the application database on another\n# system, you should be using db:schema:load, not running all the migrations\n# from scratch. The latter is a flawed and unsustainable approach (the more migrations\n# you'll amass, the slower it'll run and the greater likelihood for issues).\n#\n# It's strongly recommended that you check this file into your version control system.\n\nActiveRecord::Schema.define(version: 0) do\n\n create_table \"virtual_columns\", force: :cascade, options: \"ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci\" do |t|\n t.string \"name\"\n t.virtual \"upper_name\", type: :string, as: \n t.virtual \"name_length\", type: :integer, as: \"LENGTH(`name`)\", stored: true\n end\n\nend\n". 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips ``` ``` > select @@version; +--------------------+ | @@version | +--------------------+ | 10.1.9-MariaDB-log | +--------------------+ 1 row in set (0.00 sec) ```
-
由 Ryuta Kamizono 提交于
Related #28399.
-
由 Rafael França 提交于
Remove datetime fields from helper list [ci skip]
-
由 yuuji.yaginuma 提交于
The `datetime_field` is an alias of the `datetime_local_field`, there is no helper to generate datetime fields. Ref: #25469
-
由 Rafael Mendonça França 提交于
Since this protection is now in Parameters we can use it instead of reimplementing again.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We are talking about a list of parameters even so we need to use plural. Even if we were talking about the instance of the Parameters object we would have to use the capital and monospaced font.
-
由 Rafael Mendonça França 提交于
Previously it was raising an error because it may be unsafe to use those methods in a unpermitted parameter. Now we delegate to to_h that already raise an error when the Parameters instance is not permitted. This also fix a bug when using `#to_query` in a hash that contains a `ActionController::Parameters` instance and was returning the name of the class in the string.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-