- 07 1月, 2020 11 次提交
-
-
由 Stuart 提交于
-
由 Rafael Mendonça França 提交于
Fix collision check when using a generator and using the force option
-
由 Gannon McGibbon 提交于
Add ActiveRecord::Validations::NumericalityValidator
-
由 Gannon McGibbon 提交于
Add Active Record numericality validator with support for casting floats using a database columns' precision value.
-
由 Rafael França 提交于
Only assign @new_record_before_save once in autosave_association
-
由 Julian Nadeau 提交于
-
由 Rafael França 提交于
Use full option names in psql / pg_dump for clarity
-
由 Julian Nadeau 提交于
If we defined a callback before an association that updates the object, then this may end up being manipulated to being `false` when it should be `true`. We guard this be only defining it once. The implication of it being false, in this case, is that the children aren't updated with the parent_id and so they fail to associate to one another. See https://github.com/rails/rails/issues/38120 for more details
-
由 Simon Perepelitsa 提交于
-
由 John Hawthorn 提交于
Define mattr_* methods at caller's location
-
由 Simon Perepelitsa 提交于
-
- 06 1月, 2020 5 次提交
-
-
由 Eileen M. Uchitelle 提交于
Avoid unnecessary SQL query when calling ActiveRecord::Relation#cache_key
-
由 Rafael França 提交于
Add `:round_mode` parameter support to number helpers
-
由 Ryuta Kamizono 提交于
Fix the broken anchor of link [ci skip]
-
由 Takayuki Nakata 提交于
-
由 tom-lord 提交于
Support handling a `round_mode` in `ActiveSupport::NumberHelper::RoundingHelper` Add default value to locale file Update inline documentation with new parameter option Update CHANGELOG Add round_mode examples to all the tests Add I18n test Simplify logic Further simpification
-
- 05 1月, 2020 8 次提交
-
-
由 Rafael França 提交于
Include primary key in insert_all conflict target if specified
-
由 John Hawthorn 提交于
-
由 John Hawthorn 提交于
Before: [1] pry(main)> $ ActiveJob::Base.default_priority From: lib/active_support/core_ext/module/attribute_accessors.rb @ line 64: Owner: ActiveJob::QueuePriority::ClassMethods Visibility: public Number of lines: 3 def #{sym} @@#{sym} end After: [1] pry(main)> $ ActiveJob::Base.default_priority From: /home/jhawthorn/src/rails/activejob/lib/active_job/queue_priority.rb @ line 9: Owner: ActiveJob::QueuePriority::ClassMethods Visibility: public Number of lines: 1 mattr_accessor :default_priority
-
由 John Hawthorn 提交于
Previously this was incorrectly defining this attribute on the singleton class, which would end up actually using the class variable from Module.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Fix adding non-null column to existing SQLite3 table
-
由 Mike Vastola 提交于
Forces adding the column by way of copying the table due to lack of support in SQLite3 adapter. Fixes #38129
-
- 04 1月, 2020 13 次提交
-
-
由 Ryuta Kamizono 提交于
Avoid assigning duplicate values to join_values
-
由 Ryuta Kamizono 提交于
-
由 sinsoku 提交于
-
由 sinsoku 提交于
The ArgumentError occurs even though structures is compatible. Because some query methods keep duplicate values. For example, the behavior of `joins` method is as following: ```ruby relation = Post.joins(:author).joins(:author) relation.joins_values #=> [:author, :author] relation.or(Post.joins(:author)) #=> ArgumentError: Relation passed to #or must be structurally compatible. Incompatible values: [:joins] ``` This commit changes to not keep duplicate values. Fixes #38052
-
由 Rafael França 提交于
Update "The Hard Way" setup for Arch Linux
-
由 Keeyan Nejad 提交于
MariaDB cannot be started on Arch Linux before running a command to create the database files See https://wiki.archlinux.org/index.php/MariaDB#Installation It also appears that memcached is not started by default on Arch Linux, so it has been added to the systemctl startup step. This PR adds that step when setting up on Arch Linux
-
由 Rafael França 提交于
Pass env_name as a string in test databases
-
由 John Crepezzi 提交于
In 154abcab we switched from using `Rails.env` to fetch the `env_name` to `ActiveRecord::ConnectionHandling::DEFAULT_ENV.call.to_sym` which changed the type from a `String` to a `Symbol`. This commit brings things back to the original state, so we can find the configurations correctly! It also modifies the configuration in the configurations array, so that future connections can find the database with the updated keyword value.
-
由 Rafael Mendonça França 提交于
When all IPs are trusted, use the furthest away
-
由 Keenan Brock 提交于
-
由 Rafael França 提交于
Fix regression where AJ#perform_now doesn't return the job's value:
-
由 Edouard CHIN 提交于
- I made a change in 0d3aec49 to output a log if a job was aborted in a before callbacks. I didn't take in consideration that a job could return a falsy value and thus it would wrongly log that the job was aborted. This fixes the problem by checking if the callback chain was halted rather than the return value of the job.
-
由 Edouard CHIN 提交于
- Fix #38040
-
- 03 1月, 2020 3 次提交
-
-
由 Matthew Draper 提交于
Scenario: we have a REMOTE_ADDR of `127.0.0.1`, and X-Forwarded-For is `A, B, C`. Without any relevant trust, the `remote_ip` is `C`. If `C` is trusted, then the `remote_ip` is `B`. If `B` and `C` are trusted, then the `remote_ip` is `A`. If all of `A`, `B`, and `C` are trusted, then the `remote_ip` should still be `A`: if our trust was sufficient to get that far out before, trusting something else should not have us fall back to `127.0.0.1`. It is this last situation that we're correcting here: We trust `A` to give us accurate X-Forwarded-For information, yet it has chosen to leave it unset. Therefore, `A` is telling us that it is itself the client.
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Fix regression, enforce fresh ETag header after collection contents change
-