1. 20 4月, 2014 9 次提交
    • R
      Merge pull request #14816 from jonatack/patch-2 · b1000ead
      Robin Dupret 提交于
      Grammar fix in Getting Started Guide [ci skip]
      b1000ead
    • J
      Grammar fix in Getting Started Guide · cd86201e
      Jon Atack 提交于
      cd86201e
    • A
      Make URL escaping more consistent · 5460591f
      Andrew White 提交于
      1. Escape '%' characters in URLs - only unescaped data
         should be passed to URL helpers
      
      2. Add an `escape_segment` helper to `Router::Utils`
         that escapes '/' characters
      
      3. Use `escape_segment` rather than `escape_fragment`
         in optimized URL generation
      
      4. Use `escape_segment` rather than `escape_path`
         in URL generation
      
      For point 4 there are two exceptions. Firstly, when a route uses wildcard
      segments (e.g. *foo) then we use `escape_path` as the value may contain '/'
      characters. This means that wildcard routes can't be optimized. Secondly,
      if a `:controller` segment is used in the path then this uses `escape_path`
      as the controller may be namespaced.
      
      Fixes #14629, #14636 and #14070.
      5460591f
    • A
      Optimize URI escaping · a6179257
      Andrew White 提交于
      The URI::Parser#escape method is a general use method that has to deal
      with a variety of input however our use of it is limited in scope so
      we can increase the performance by implementing our specific needs
      within ActionDispatch::Journey::Router::Utils directly.
      
      If there is no encoding required then there is no change in performance
      or number of objects allocated, but for each character that needs to be
      encoded we save five object allocations and gain a performance boost.
      The performance boost seen varies from 20% when there is one character
      to over 50% when encoding ten characters.
      a6179257
    • E
      Always escape string passed to url helper. · e2ef83f8
      edogawaconan 提交于
      Makes it clear that anything passed with the helper must not be percent encoded.
      
      Fixes previous behavior which tricks people into believing passing
      non-percent-encoded will generate a proper percent-encoded path while in
      reality it doesn't ('%' isn't escaped).
      
      The intention is nice but the heuristic is broken.
      e2ef83f8
    • G
      Merge pull request #14811 from qrush/master · c524556e
      Guillermo Iguaran 提交于
      Remove statement assuming coffee shop/public space wifi is inherently insecure
      c524556e
    • N
    • G
      Merge pull request #14810 from robin850/patch-18 · 6642407c
      Godfrey Chan 提交于
      Don't rely on Arel master in bug report template
      6642407c
    • R
      Don't rely on Arel master in bug report template [ci skip] · fd6d7835
      Robin Dupret 提交于
      We should rely instead on the version supported by Active Record
      
      Closes #14809
      fd6d7835
  2. 19 4月, 2014 13 次提交
  3. 18 4月, 2014 18 次提交