1. 20 6月, 2017 2 次提交
  2. 03 6月, 2017 1 次提交
  3. 19 5月, 2017 1 次提交
  4. 27 4月, 2017 1 次提交
  5. 24 4月, 2017 1 次提交
  6. 19 4月, 2017 1 次提交
  7. 12 1月, 2017 1 次提交
  8. 04 1月, 2017 2 次提交
  9. 23 12月, 2016 1 次提交
  10. 18 10月, 2016 1 次提交
    • J
      Convert ActionController::Parameters to a hash in button_to · 4aae8bfe
      Jon Moss 提交于
      Before, an error would be raised saying that the method `to_param` was
      undefined on the instance of `ActionController::Parameters`. Now, we are
      checking to see if the `params` object being passed to `button_to`
      responds to the `permitted?` method, and if so, we will call `to_h` on it. If it
      does not respond to `permitted?`, then the `params` will remain
      unchanged.
      
      [Jon Moss, Rafael Mendonça França]
      4aae8bfe
  11. 16 8月, 2016 1 次提交
  12. 08 8月, 2016 1 次提交
    • X
      code gardening: removes redundant selfs · a9dc4545
      Xavier Noria 提交于
      A few have been left for aesthetic reasons, but have made a pass
      and removed most of them.
      
      Note that if the method `foo` returns an array, `foo << 1`
      is a regular push, nothing to do with assignments, so
      no self required.
      a9dc4545
  13. 07 8月, 2016 3 次提交
  14. 20 7月, 2016 1 次提交
  15. 13 3月, 2016 1 次提交
  16. 20 2月, 2016 1 次提交
    • J
      Fix button_to's params option to support nested names. · 459cd7fd
      James Coleman 提交于
      In e6e0579d the `params` option was added to the `button_to` helper. However, the patch doesn't support nested hashes so `{a: {b: 'c'}}` for example gets turned into a hidden form input with the name 'a' and the value being the string representation of the `{b: 'c'}` nested hash.
      
      Since Rails supports nested hashes everywhere else (and even in the URL params of link_to and button_to), I believe this to be a bug/unfinished feature.
      459cd7fd
  17. 20 1月, 2016 1 次提交
  18. 05 1月, 2016 1 次提交
  19. 15 12月, 2015 1 次提交
  20. 04 11月, 2015 2 次提交
  21. 30 10月, 2015 1 次提交
    • P
      In url_for, never append ? when the query string is empty anyway. · e6e056c2
      Paul Grayson 提交于
      It used to behave like this:
      
          url_for(controller: 'x', action: 'y', q: {})
          # -> "/x/y?"
      
      We previously avoided empty query strings in most cases by removing
      nil values, then checking whether params was empty.  But as you can
      see above, even non-empty params can yield an empty query string.  So
      I changed the code to just directly check whether the query string
      ended up empty.
      
      (To make everything more consistent, the "removing nil values"
      functionality should probably move to ActionPack's Hash#to_query, the
      place where empty hashes and arrays get removed.  However, this would
      change a lot more behavior.)
      e6e056c2
  22. 06 9月, 2015 1 次提交
  23. 05 9月, 2015 2 次提交
    • A
      use path escaping for email addresses · 21ffef38
      Aaron Patterson 提交于
      Due to e25fdad2, we are correctly using
      path escaping for email addresses.  This commit fixes the tests to
      expect path escaping.
      21ffef38
    • B
      `url_for` does not modify polymorphic options · ee63532d
      Bernerd Schaefer 提交于
      The `url_for` methods in `actionpack` and `actionview`
      now make a copy of the provided options
      before generating polymorphic paths or URLs.
      
      The bug in the previous behavior
      is most noticeable in a case like:
      
          url_options = [:new, :post, param: 'value']
      
          if current_page?(url_options)
            css_class = "active"
          end
      
          link_to "New Post", url_options, class: css_class
      ee63532d
  24. 27 8月, 2015 1 次提交
  25. 24 7月, 2015 1 次提交
  26. 05 5月, 2015 1 次提交
  27. 01 5月, 2015 2 次提交
  28. 03 2月, 2015 1 次提交
  29. 01 2月, 2015 1 次提交
  30. 21 12月, 2014 1 次提交
  31. 02 10月, 2014 1 次提交
    • K
      do not generate blank options in mailTo · a13ad4a6
      Kuldeep Aggarwal 提交于
      when mail_to generate blank options for any passed options(cc, bcc, body, subject)
      then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
      a13ad4a6
  32. 17 6月, 2014 2 次提交