- 20 6月, 2017 1 次提交
-
-
由 Pat Allan 提交于
Plus a couple of related ActionPack patches.
-
- 19 5月, 2017 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 10 8月, 2016 1 次提交
-
-
由 Igor Kasyanchuk 提交于
-
- 08 8月, 2016 2 次提交
-
-
由 Kasper Timm Hansen 提交于
-
由 Stan Lo 提交于
Implement naive partial caching mechanism. Add test for LogSubscriber Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it. Fixed tests Remove useless settings Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload. Update test's hash syntax Add configuration to enable/disable fragment caching logging Remove unless test and add new test to ensure cache info won't effect next rendering's log Move :enable_fragment_cache_logging config from ActionView to ActionPack Apply new config to tests Update actionview's changelog Update configuration guide Improve actionview's changelog Refactor PartialRenderer#render and log tests Mute subscriber's log instead of disabling instrumentation. Fix typo, remove useless comment and use new hash syntax Improve actionpack's log_subscriber test Fix rebase mistake Apply new config to all caching intstrument actions
-
- 10 2月, 2016 1 次提交
-
-
由 Aaron Patterson 提交于
We don't need to use active support in this case because we know the type that will be returned.
-
- 07 2月, 2016 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Referencing Rails.env without checking if it's defined couples us to Railties. Fix by avoiding the line breaks if we don't have an env check to rely on.
-
- 03 2月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Fixes #23428.
-
- 20 7月, 2015 1 次提交
-
-
由 schneems 提交于
I wrote a utility that helps find areas where you could optimize your program using a frozen string instead of a string literal, it's called [let_it_go](https://github.com/schneems/let_it_go). After going through the output and adding `.freeze` I was able to eliminate the creation of 1,114 string objects on EVERY request to [codetriage](codetriage.com). How does this impact execution? To look at memory: ```ruby require 'get_process_mem' mem = GetProcessMem.new GC.start GC.disable 1_114.times { " " } before = mem.mb after = mem.mb GC.enable puts "Diff: #{after - before} mb" ``` Creating 1,114 string objects results in `Diff: 0.03125 mb` of RAM allocated on every request. Or 1mb every 32 requests. To look at raw speed: ```ruby require 'benchmark/ips' number_of_objects_reduced = 1_114 Benchmark.ips do |x| x.report("freeze") { number_of_objects_reduced.times { " ".freeze } } x.report("no-freeze") { number_of_objects_reduced.times { " " } } end ``` We get the results ``` Calculating ------------------------------------- freeze 1.428k i/100ms no-freeze 609.000 i/100ms ------------------------------------------------- freeze 14.363k (± 8.5%) i/s - 71.400k no-freeze 6.084k (± 8.1%) i/s - 30.450k ``` Now we can do some maths: ```ruby ips = 6_226k # iterations / 1 second call_time_before = 1.0 / ips # seconds per iteration ips = 15_254 # iterations / 1 second call_time_after = 1.0 / ips # seconds per iteration diff = call_time_before - call_time_after number_of_objects_reduced * diff * 100 # => 0.4530373333993266 miliseconds saved per request ``` So we're shaving off 1 second of execution time for every 220 requests. Is this going to be an insane speed boost to any Rails app: nope. Should we merge it: yep. p.s. If you know of a method call that doesn't modify a string input such as [String#gsub](https://github.com/schneems/let_it_go/blob/b0e2da69f0cca87ab581022baa43291cdf48638c/lib/let_it_go/core_ext/string.rb#L37) please [give me a pull request to the appropriate file](https://github.com/schneems/let_it_go/blob/b0e2da69f0cca87ab581022baa43291cdf48638c/lib/let_it_go/core_ext/string.rb#L37), or open an issue in LetItGo so we can track and freeze more strings. Keep those strings Frozen ![](https://www.dropbox.com/s/z4dj9fdsv213r4v/let-it-go.gif?dl=1)
-
- 15 12月, 2014 1 次提交
-
-
由 Chris Sinjakli 提交于
-
- 26 11月, 2014 1 次提交
-
-
由 Artur Cygan 提交于
-
- 18 7月, 2014 1 次提交
-
-
由 Guo Xiang Tan 提交于
The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
-
- 03 3月, 2014 1 次提交
-
-
由 Shuhei Kagawa 提交于
-
- 24 2月, 2014 1 次提交
-
-
由 Serj L 提交于
Simple Sungularize ActionController::UnpermittedParameters error in case when only 1 parameter is unpermitted.
-
- 29 1月, 2014 1 次提交
-
-
由 Lukasz Sarnacki 提交于
deep_munge solves CVE-2013-0155 security vulnerability, but its behaviour is definately confuisng. This commit adds logging to deep_munge. It logs keys for which values were set to nil. Also mentions in guides were added.
-
- 15 5月, 2013 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 07 3月, 2013 1 次提交
-
-
由 Daniel Schierbeck 提交于
-
- 01 10月, 2012 1 次提交
-
-
由 Brian Durand 提交于
-
- 20 9月, 2012 1 次提交
-
-
由 Brian Durand 提交于
-
- 18 9月, 2012 1 次提交
-
-
由 Yves Senn 提交于
-
- 03 8月, 2012 1 次提交
-
-
由 Xavier Noria 提交于
-
- 19 5月, 2012 1 次提交
-
-
由 Alexey Vakhov 提交于
-
- 10 5月, 2012 1 次提交
-
-
由 Rafael Magana 提交于
-
- 13 12月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 02 12月, 2011 1 次提交
-
-
由 José Valim 提交于
-
- 30 11月, 2011 1 次提交
-
-
由 José Valim 提交于
Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time a before callback halts.
-
- 25 6月, 2011 1 次提交
-
-
由 James Cox 提交于
make the logs a little simpler to view, put the render message inline with other events, pull processing to char[0] and add a new line to the completed. looks more like a block now, which is useful for serial actions like test/dev
-
- 07 5月, 2011 1 次提交
-
-
由 José Valim 提交于
-
- 26 1月, 2011 1 次提交
-
-
由 Doug Fales 提交于
A patch so that http status codes are still included in logs even during an exception [#6333 state:resolved] Signed-off-by: NJosé Valim <jose.valim@gmail.com>
-
- 25 9月, 2010 1 次提交
-
-
由 Krekoten' Marjan 提交于
Signed-off-by: NJosé Valim <jose.valim@gmail.com>
-
- 24 6月, 2010 1 次提交
-
-
由 José Valim 提交于
Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
-