- 21 12月, 2015 1 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up to #22642.
-
- 18 12月, 2015 4 次提交
-
-
由 Grey Baker 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
We know the query will return exactly one row for each entry in the `ids` array, so we can do all the limit/offset calculations on that array, in advance. I also split our new ordered-ids behaviour out of the existing `find_some` method: especially with this change, the conditionals were overwhelming the actual logic.
-
由 Sean Griffin 提交于
Since the attributes API is new in Rails 5, we don't actually need to keep the behavior of `attribute :point`, as it's not a breaking change.
-
- 17 12月, 2015 5 次提交
-
-
由 Abdelkader Boudih 提交于
-
由 Grey Baker 提交于
Support passing the schema name as a prefix to table name in `ConnectionAdapters::SchemaStatements#indexes`. Previously the prefix would be considered a full part of the index name, and only the schema in the current search path would be considered.
-
由 Sean Griffin 提交于
This test was failing when run on Windows using PostgreSQL. Depending on the OS (and 32 vs 64 bit), this type could be a `BigNum`. We could loosen the assertion to `Numeric`, but if the value is equal to the expected, and responds to `bitlength` properly, who cares?
-
由 Sean Griffin 提交于
Unlike unix, the TZ variable on Windows does not look at a database. It is always expected to be in the form {Standard Time Abbreviation}{UTC-Offset}{Daylight Time Abbriviation}. This changes the relevant tests to use the Windows form when run from Windows.
-
由 Sean Griffin 提交于
When this test was run on Windows, the database file would still be in use, and `File.unlink` would fail. This would cause the temp directory to be unable to be removed, and error out. By disconnecting the connection when finished, we can avoid this error.
-
- 16 12月, 2015 4 次提交
-
-
由 yui-knk 提交于
-
由 Tony Ta 提交于
-
由 Grey Baker 提交于
-
由 Grey Baker 提交于
-
- 15 12月, 2015 8 次提交
-
-
由 Stephen Blackstone 提交于
Fix white-space Add test case demonstrating flags are received by the adapter
-
由 Sean Griffin 提交于
We currently generate an unbounded number of prepared statements when `limit` or `offset` are called with a dynamic argument. This changes `LIMIT` and `OFFSET` to use bind params, eliminating the problem. `Type::Value#hash` needed to be implemented, as it turns out we busted the query cache if the type object used wasn't exactly the same object. This drops support for passing an `Arel::Nodes::SqlLiteral` to `limit`. Doing this relied on AR internals, and was never officially supported usage. Fixes #22250.
-
由 Sean Griffin 提交于
Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`. Supporting this in Active Record massively complicates using bind parameters for limit and offset, and it's trivially easy to build an invalid SQL query by also calling `offset` on the same `Relation`. This is a niche syntax that is only supported by a few adapters, and can be trivially worked around by calling offset explicitly.
-
由 Matthew Draper 提交于
Apart from specific versioning support, our tests should focus on the behaviour of whatever version they're accompanying, regardless of when they were written. Application code should *not* do this.
-
由 Matthew Draper 提交于
-
由 Sean Griffin 提交于
This reverts commit 6d5b1fdf. `eager_load` and `references` can include hashes, which won't match up with `references` A test case has been added to demonstrate the problem
-
由 Sean Griffin 提交于
There was a test remaining for PG only that was checking for an exact limit clause
-
由 Vokhmin Alexey V 提交于
-
- 14 12月, 2015 2 次提交
-
-
由 Sean Griffin 提交于
We currently generate an unbounded number of prepared statements when `limit` or `offset` are called with a dynamic argument. This changes `LIMIT` and `OFFSET` to use bind params, eliminating the problem. `Type::Value#hash` needed to be implemented, as it turns out we busted the query cache if the type object used wasn't exactly the same object. This drops support for passing an `Arel::Nodes::SqlLiteral` to `limit`. Doing this relied on AR internals, and was never officially supported usage. Fixes #22250.
-
由 Sean Griffin 提交于
Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`. Supporting this in Active Record massively complicates using bind parameters for limit and offset, and it's trivially easy to build an invalid SQL query by also calling `offset` on the same `Relation`. This is a niche syntax that is only supported by a few adapters, and can be trivially worked around by calling offset explicitly.
-
- 13 12月, 2015 1 次提交
-
-
由 Fumiaki MATSUSHIMA 提交于
-
- 07 12月, 2015 2 次提交
-
-
由 Arthur Neves 提交于
The problem was that when saving an object, we would call touch_later on the parent which wont be saved immediteally, and it wont call any callbacks. That was working one level up because we were calling touch, during the touch_later commit phase. However that still didnt solve the problem when you have a 3+ levels of parents to be touched, as calling touch would affect the parent, but it would be too late to run callbacks on its grand-parent. The solution for this, is instead, call touch_later upwards when the first touch_later is called. So we make sure all the timestamps are updated without relying on callbacks. This also removed the hard dependency BelongsTo builder had with the TouchLater module. So we can still have the old behaviour if TouchLater module is not included. [fixes 5f5e6d92] [related #19324]
-
由 Genadi Samokovarov 提交于
Those are actually shortcuts for `after_commit`. Before: after_commit :add_to_index_later, on: :create after_commit :update_in_index_later, on: :update after_commit :remove_from_index_later, on: :destroy After: after_create_commit :add_to_index_later after_update_commit :update_in_index_later after_destroy_commit :remove_from_index_later
-
- 05 12月, 2015 1 次提交
-
-
由 yuuji.yaginuma 提交于
This removes the following warning which has been out in the case of a PostgreSQL 9.3 below. ``` activerecord/test/cases/adapters/postgresql/geometric_test.rb:265: warning: instance variable @connection not initialized ```
-
- 03 12月, 2015 1 次提交
-
-
由 Yves Senn 提交于
This will also get the defaults from attribute definitions like: attribute :type, :string, default: "SomethingElse"
-
- 02 12月, 2015 3 次提交
-
-
由 Yves Senn 提交于
`has_attribute?` method to check wether a given attribute has been defined.
-
由 Kuldeep Aggarwal 提交于
fixes #17121
-
由 Sean Griffin 提交于
It appears that I missed this one when I delegated all the non-mutation array methods that were not on Enumerable
-
- 01 12月, 2015 2 次提交
-
-
由 Yasuo Honda 提交于
-
由 Yasuo Honda 提交于
-
- 24 11月, 2015 4 次提交
-
-
由 Sean Griffin 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Sean Griffin 提交于
As was pointed out by #17128, our blacklist of mutation methods was non-exhaustive (and would need to be kept up to date with each new version of Ruby). Now that `Relation` includes `Enumerable`, the number of methods that we actually need to delegate are pretty small. As such, we can change to explicitly delegating the few non-mutation related methods that `Array` has which aren't on `Enumerable`
-
- 23 11月, 2015 1 次提交
-
-
由 Bogdan Gusiev 提交于
When same association is loaded in the model creation callback The new object is inserted into association twice
-
- 21 11月, 2015 1 次提交
-
-
由 yui-knk 提交于
`replace_named_bind_variables` and `replace_bind_variables` are definded in `sanitization.rb`, so it is reasonable these tests are on `sanitize_test.rb`.
-