- 20 10月, 2018 3 次提交
-
-
由 Olivier Lacan 提交于
The names are only used in the Guides Index overlay and several of them are longer than they need to be. For example “Ruby on Rails” is mentioned over and over again in the Release Notes section although these are obviously all Rails versions we’re listing. There’s a Maintenance Policy category with a Maintenance Policy article which is redundant. Policies makes much more sense as a category. Similarly, Contributing to Ruby on Rails is both a category and an article. “Contributions” is a better category title. “Ruby on Rails Guides Guidelines” is a gigantic mouthful. We are *in* the Rails Guides, we don’t need to specify what guides we’re talking about here. As a final added advantage, all of these shortenings make the index much easier to parse in order to find an article. [ci skip]
-
由 Olivier Lacan 提交于
This notably allows us to tile each category without pushing the page down vertically as much as we previously did on any viewport wider than mobile sizes. It also means we can fit more guides which will become useful in the future since we have several new guides in the work. Finally the new layout allows three clearly distinct columns to emerge: - Start Here and Rails basics: Models, Views, Controllers, Other Components - Digging Deeper, Extending Rails, Contributing, Maintenance - Release Notes Having Release Notes shoot back up to the top of the third column is great because that makes finding the latest released version and its associated release notes much easier without having to scroll down a bunch. [ci skip]
-
由 Richard Schneeman 提交于
Add guides section on verbose query logs to Debugging
-
- 19 10月, 2018 8 次提交
-
-
由 Olivier Lacan 提交于
Since this is a useful tool in debugging it made sense to document its existence and usage, especially in the console where it's disabled by default. [ci skip]
-
由 yuuji.yaginuma 提交于
If the dev option is specified, Gemfile contains gem which specifies GitHub. This will take time to execute, so should avoid it in unnecessary tests.
-
由 Yuji Yaginuma 提交于
Make AJ integration tests work in CI
-
由 yuuji.yaginuma 提交于
Since `@mutex.synchronize` is enforced in the `ensure_connection!` method, there is no need to do so on the caller side. https://github.com/jondot/sneakers/blob/c1b47f9c5d5a95da728bbe1700795790e4efbb12/lib/sneakers/publisher.rb#L22-L26 Due to this, `ThreadError(deadlock; recursive locking)` has occurred.
-
由 yuuji.yaginuma 提交于
Also, replace the authentication setting. This is necessary for using `psql` with PostgreSQL 10. Ref: https://github.com/travis-ci/travis-ci/issues/9624#issuecomment-389537036
-
由 Yuji Yaginuma 提交于
Fix typo in testing guide
-
由 yuuji.yaginuma 提交于
-
由 Francesco Rodríguez 提交于
in favor of `array.flatten.pack("U*")` and `string.scan(/\X/).map(&:codepoints)`, respectively.
-
- 18 10月, 2018 3 次提交
-
-
由 Yuji Yaginuma 提交于
Fix generated Gemfile missing gems on jruby
-
由 anthonygharvey 提交于
-
由 Ryuta Kamizono 提交于
-
- 17 10月, 2018 15 次提交
-
-
由 David Rodríguez 提交于
-
由 Richard Schneeman 提交于
ActiveRecord#respond_to? No longer allocates strings
-
由 Ryuta Kamizono 提交于
Follow up #32146.
-
由 Ryuta Kamizono 提交于
Remove index:true option from belongs to as defaults to true. [ci skip]
-
由 Yuji Yaginuma 提交于
Update guide for the counter variable when rendering with the `as:` option
-
由 Ryuta Kamizono 提交于
`init_with` and `init_from_db` are almost the same code except decode `coder`. And also, named `init_from_db` is a little misreading, a raw values hash from the database is already converted to an attributes object by `attributes_builder.build_from_database`, so passed `attributes` in that method is just an attributes object. I renamed that method to `init_with_attributes` since the method is shared with `init_with` to initialize an empty model object.
-
由 Lucas Oliveira 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
Consistently extract checking version for all adapters
-
由 Francesco Rodríguez 提交于
Use \X meta character directly to get grapheme clusters. Thanks to @mtsmfm for the tip: https://github.com/rails/rails/pull/34123#issuecomment-429028878 r? @jeremy
-
由 Ryuta Kamizono 提交于
I don't prefer to extract it for one adapter even though all adapters also does. Related to #34227.
-
由 Gannon McGibbon 提交于
Fix mapping of content [ci skip]
-
由 Adam Demirel 提交于
-
由 Aaron Patterson 提交于
Refactored abstract MySQL adapter to support lazy version check.
-
由 Gannon McGibbon 提交于
Clarify docs of `ActiveJob::TestHelper` [ci skip]
-
由 Brooke Kuhlmann 提交于
Will allow sub classes to override the protected `#check_version` method hook if desired. For example, this will be most helpful in sub classes that wish to support lazy initialization because the version check can be postponed until the connection is ready to be initialized.
-
- 16 10月, 2018 10 次提交
-
-
由 Ryuta Kamizono 提交于
Add regression test against has_and_belong_to_many memoized singular_ids
-
由 Richard Schneeman 提交于
Extend doc for ActiveSupport::Cache#fetch_multi
-
由 Alberto Almagro 提交于
Starting in Rails 5.0.0 and still present in Rails 5.2.1, `singular_ids` got memoized and didn't reload after more items were added to the relation. Although 19c80718 happens to fix the issue, it only adds tests for `has_many` relations while this bug only affected `has_and_belongs_to_many` relations. This commit adds a regression test to ensure it never happens again with `habtm` relations. Ensures #34179 never gets reproduced.
-
由 Carlos Donderis 提交于
-
由 Ryuta Kamizono 提交于
Issue #29200 scaffold an object with a reference displays an object memory address to user
-
由 Ryuta Kamizono 提交于
Fix Collection cache key with limit and custom select
-
由 Federico Martinez 提交于
Change query to use alias name for timestamp_column to avoid ambiguity problems when using timestamp from subquery.
-
由 bogdanvlviv 提交于
I found a few sentences that should be updated as well. See https://github.com/rails/rails/pull/33571#discussion_r209435886 Follow up #33571
-
由 schneems 提交于
This is an alternative to https://github.com/rails/rails/pull/34195 The active record `respond_to?` method needs to do two things if `super` does not say that the method exists. It has to see if the "name" being passed in represents a column in the table. If it does then it needs to pass it to `has_attribute?` to see if the key exists in the current object. The reason why this is slow is that `has_attribute?` needs a string and most (almost all) objects passed in are symbols. The only time we need to allocate a string in this method is if the column does exist in the database, and since these are a limited number of strings (since column names are a finite set) then we can pre-generate all of them and use the same string. We generate a list hash of column names and convert them to symbols, and store the value as the string name. This allows us to both check if the "name" exists as a column, but also provides us with a string object we can use for the `has_attribute?` call. I then ran the test suite and found there was only one case where we're intentionally passing in a string and changed it to a symbol. (However there are tests where we are using a string key, but they don't ship with rails). As re-written this method should never allocate unless the user passes in a string key, which is fairly uncommon with `respond_to?`. This also eliminates the need to special case every common item that might come through the method via the `case` that was originally added in https://github.com/rails/rails/commit/f80aa5994603e684e3fecd3f53bfbf242c73a107 (by me) and then with an attempt to extend in https://github.com/rails/rails/pull/34195. As a bonus this reduces 6,300 comparisons (in the CodeTriage app homepage) to 450 as we also no longer need to loop through the column array to check for an `include?`.
-
由 Francesco Rodríguez 提交于
In favor of String#is_utf8?. I think this method was made for internal use only, and its usage was removed here: https://github.com/rails/rails/pull/8261/files#diff-ce956ebe93786930e40f18db1da5fd46L39.
-
- 15 10月, 2018 1 次提交
-
-
由 Ryuta Kamizono 提交于
Update snippet to rails 5 syntax [ci skip]
-