- 21 5月, 2012 11 次提交
-
-
由 Piotr Sarnacki 提交于
Add more info on how to write a good commit messages along with example showing nicely formatted commit message. Rails git history does not look too well when you try to figure out why particular changes were introduced. We can do much better than that and it's never too late to start.
-
由 Piotr Sarnacki 提交于
In development mode, dependencies are loaded dynamically at runtime, using `const_missing`. Because of that, when one of the constants is already loaded and `const_missing` is not triggered, user can end up with unexpected results. Given such file in an Engine: ```ruby module Blog class PostsController < ApplicationController end end ``` If you load it first, before loading any application files, it will correctly load `Blog::ApplicationController`, because second line will hit `const_missing`. However if you load `ApplicationController` first, the constant will be loaded already, `const_missing` hook will not be fired and in result `PostsController` will inherit from `ApplicationController` instead of `Blog::ApplicationController`. Since it can't be fixed in `AS::Dependencies`, the easiest fix is to just explicitly load application controller. closes #6413
-
由 José Valim 提交于
Template concurrency fixes Conflicts: actionpack/lib/action_view/template.rb
-
由 Rafael Mendonça França 提交于
Action Pack in the upgrading guide. [ci skip]
-
由 Carlos Antonio da Silva 提交于
Fixed typo in AR test name
-
由 Ivan Kukobko 提交于
-
由 Piotr Sarnacki 提交于
This reverts commit cae1ca7d, reversing changes made to da97cf01. These changes break the build, it needs more investigation.
-
由 Andrew White 提交于
Although no recognized formats use non-ASCII characters, sometimes they can be included in the :format parameter because of invalid URLS. To prevent encoding incompatibility errors we need to escape them before passing the path to URI.unescape. Closes #4379
-
由 Andrew White 提交于
Passing path parameters with invalid encoding is likely to trigger errors further on like `ArgumentError (invalid byte sequence in UTF-8)`. This will result in a 500 error whereas the better error to return is a 400 error which allows exception notification libraries to filter it out if they wish. Closes #4450
-
由 Andrew White 提交于
Currently Rack raises a TypeError when it encounters a malformed or ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this through to the application this commit captures the exception and re-raises it using a new ActionController::BadRequest exception. The new ActionController::BadRequest exception returns a 400 error instead of the 500 error that would've been returned by the original TypeError. This allows exception notification libraries to ignore these errors if so desired. Closes #3051
-
由 Andrew White 提交于
-
- 20 5月, 2012 12 次提交
-
-
由 Vijay Dev 提交于
-
由 José Valim 提交于
Raise Assertion instead of RoutingError for routing assertion failures.
-
由 David Chelimsky 提交于
Before this change, assert_recognizes, assert_generates, and assert_routing raised ActionController::RoutingError when they failed to recognize the route. This commit changes them to raise Assertion instead. This aligns with convention for logical failures, and supports reporting tools that care about the difference between logical failures and errors e.g. the summary at the end of a test run. - Fixes #5899
-
由 José Valim 提交于
Show in log correct wrapped keys
-
由 Piotr Sarnacki 提交于
[ci skip] closes #5790
-
由 Piotr Sarnacki 提交于
Call undefine_attribute_methods only when defining new attributes
-
由 Dmitry Vorotilin 提交于
-
由 Piotr Sarnacki 提交于
Make AC::LogSubscriber#send_file like #send_data
-
由 Aaron Patterson 提交于
Fix a problem of translate_exception method in a Japanese (non English) environment.
-
由 Aaron Patterson 提交于
Synchronize read and modification of @reserved_connections
-
由 Patrick Mahoney 提交于
-
由 kennyj 提交于
-
- 19 5月, 2012 17 次提交
-
-
由 Rafael Mendonça França 提交于
Don't use assert_block method. It will be removed.
-
由 Rafael Mendonça França 提交于
Fixed DataMapper namings in symbols and constants.
-
由 kennyj 提交于
-
由 Rafael Mendonça França 提交于
Fix warning: shadowing outer local variable - constant.
-
由 kennyj 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
-
由 Marc-Andre Lafortune 提交于
-
由 Marc-Andre Lafortune 提交于
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
由 Francesco Rodriguez 提交于
-
由 Andrew White 提交于
-
由 Carlos Antonio da Silva 提交于
Refactor define_restrict_dependency_method using reflection
-
由 Francesco Rodriguez 提交于
-
由 Carlos Antonio da Silva 提交于
Remove sort on attributes.keys
-
由 Carlos Antonio da Silva 提交于
Make the method API more clear by explicitly showing the expected arguments. This means that the options cannot be passed as second argument because we are not relying on extract_options! anymore, you are expected to give a selected key or `nil` if you want to pass options, as it is the last argument. Notice that this does not change the current method arguments contract available in 3.2, it just brings back the same functionality with the divider addition.
-