Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

The test fails on PostgreSQL when trying to load the records as
the comments_count field is not included in the GROUP BY clause.

[#5829 state:resolved]
Signed-off-by: NAndrew White <andyw@pixeltrix.co.uk>

Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries.

Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries.

removed an unnecessary second query when passing an ActiveRecord::Relation to a where clause.  And added ability to use subselects in where clauses.

ActiveRecord::Relation#primary_key should return a string, just like ActiveRecord::Base.primary_key does.

Let AssociationCollection#find use #scoped to do its finding. Note that I am removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.

Fix test_any in relations_test.rb, which was failing when relations_test.rb is run on its own (it passes when the entire suite is run). This is a hacky fix for a problem I didn't quite get to the bottom of, so I'd welcome a better solution...

* rename method names (actually in tests)
* rename instance variable @_named_scopes_cache to @_scopes_cache
* rename references in doc comments
* don't touch CHANGELOG :)

[#6022 state:resolved]

When use where more than once on the same column, relation doesn't do an 'or' or 'in' with the values

- persisted? is the API defined in ActiveModel
- makes it easier for extension libraries to conform to ActiveModel APIs
  without concern for whether the extended object is specifically
  ActiveRecord

[#5927 state:committed]
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

use column names as order by complex function parameters, fix for postgresql adapter to correctly remove ASC/DESC
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

Fixes queries using limits and punctuation in order, removes order("col1, col2") usage in favor of order(["col1", "col2"})

[#4597 state:committed]

Add explicit ordering in relations_test.rb, as the lack of this was causing failures against postgres

Fix the tests (I have actually verified that these are also the 'right' fixes, rather than just making the tests pass again)