- 23 10月, 2018 20 次提交
-
-
由 Ryuta Kamizono 提交于
Hide PG::Connection from API docs [ci skip]
-
由 Francesco Rodríguez 提交于
-
由 Ryuta Kamizono 提交于
[ci skip] Fix PullRequest link on Rails 5.1 Release Notes
-
由 tzmfreedom 提交于
-
由 Ryuta Kamizono 提交于
MySQL 8.0.13 raises `ER_NO_REFERENCED_ROW` and `ER_ROW_IS_REFERENCED`
-
由 Yasuo Honda 提交于
when user has no parent table access privileges Refer https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-13.html#mysqld-8-0-13-errors >> * Previously, the ER_NO_REFERENCED_ROW_2 and ER_ROW_IS_REFERENCED_2 error messages for foreign key operations were displayed and revealed information about parent tables, even when the user had no parent table access privileges. Error handling for this situation has been revised: * If the user does have table-level privileges for all parent tables, ER_NO_REFERENCED_ROW_2 and ER_ROW_IS_REFERENCED_2 are displayed, the same as before. * If the user does not have table-level privileges for all parent tables, more generic error messages are displayed instead (ER_NO_REFERENCED_ROW and ER_ROW_IS_REFERENCED). << This pull request addresses these 3 failures: ```ruby $ ARCONN=mysql2 bundle exec ruby -w -Itest test/cases/adapter_test.rb -n /foreign/ Using mysql2 Run options: -n /foreign/ --seed 14251 F Failure: ActiveRecord::AdapterForeignKeyTest#test_foreign_key_violations_are_translated_to_specific_exception_with_validate_false [test/cases/adapter_test.rb:348]: [ActiveRecord::InvalidForeignKey] exception expected, not Class: <ActiveRecord::StatementInvalid> Message: <"Mysql2::Error: Cannot add or update a child row: a foreign key constraint fails: INSERT INTO `fk_test_has_fk` (`fk_id`) VALUES (1231231231)"> ... snip ... rails test test/cases/adapter_test.rb:343 F Failure: ActiveRecord::AdapterForeignKeyTest#test_foreign_key_violations_on_delete_are_translated_to_specific_exception [test/cases/adapter_test.rb:368]: [ActiveRecord::InvalidForeignKey] exception expected, not Class: <ActiveRecord::StatementInvalid> Message: <"Mysql2::Error: Cannot delete or update a parent row: a foreign key constraint fails: DELETE FROM fk_test_has_pk WHERE pk_id = 1"> ... snip ... rails test test/cases/adapter_test.rb:365 F Failure: ActiveRecord::AdapterForeignKeyTest#test_foreign_key_violations_on_insert_are_translated_to_specific_exception [test/cases/adapter_test.rb:358]: [ActiveRecord::InvalidForeignKey] exception expected, not Class: <ActiveRecord::StatementInvalid> Message: <"Mysql2::Error: Cannot add or update a child row: a foreign key constraint fails: INSERT INTO fk_test_has_fk (fk_id) VALUES (0)"> ... snip ... rails test test/cases/adapter_test.rb:357 Finished in 0.087370s, 34.3366 runs/s, 34.3366 assertions/s. 3 runs, 3 assertions, 3 failures, 0 errors, 0 skips $ ```
-
由 Andrew White 提交于
Fix CSP dynamic sources
-
由 Rafael França 提交于
Remove mentions about `javascripts` option from the guide about generators [ci skip]
-
由 Rafael França 提交于
Add docs to ActiveSupport::Notifications.subscribe
-
由 Ryuta Kamizono 提交于
Remove "Upgrading from Old Versions" from Asset Pipeline Guide [skip ci]
-
由 George Claghorn 提交于
Add missing dot in comment in .gitignore template
-
由 Chris Fung 提交于
[ci skip]
-
由 bogdanvlviv 提交于
This option is unused since #33079. Follow up #34277
-
由 Rafael França 提交于
Unify changelog entries related to `database` option of Rails generators [ci skip]
-
由 Jochem Schulenklopper 提交于
My submission for the tiniest commit and PR contest: add a missing dot in a comment line in the generator template for .gitignore. (I just noticed this missing; consistency is king :-)
-
由 Gannon McGibbon 提交于
Fix #33914 : Remove dependent: :destroy option from the belong_to example since there is a warning associated with the usage of dependent: :destroy along with belongs_to
-
由 Raghu Kamat 提交于
This commit removes the dependent: :destroy option from the belong_to example since there is a warning associated with the usage of dependent: :destroy along with belongs_to. Based on the feedback on the issue #33914, I replaced dependent: :destroy with touch: :books_updated_at which will make the example consistent with the example that already exists on that page. * Also Removing the touch option from the belong_to scopes example as the option doesnt have any relation to association scope.
-
由 Rafael França 提交于
Clarify i18n load paths gotcha
-
由 Andrew White 提交于
There is no controller instance when using a redirect route or a mounted rack application so pass the request object as the context when resolving dynamic CSP sources in this scenario. Fixes #34200.
-
由 Andrew White 提交于
Previously if a dynamic source returned a symbol such as :self it would be converted to a string implicity, e.g: policy.default_src -> { :self } would generate the header: Content-Security-Policy: default-src self and now it generates: Content-Security-Policy: default-src 'self'
-
- 22 10月, 2018 13 次提交
-
-
由 Gannon McGibbon 提交于
Clarify `I18n.load_paths` vs `Rails.application.config.i18n.load_paths` behaviour. [Gannon McGibbon + Alberto Almagro Sotelo]
-
由 Ryuta Kamizono 提交于
Remove extra call `remove_file` on `rails new` with `--skip_action_cable`
-
由 Eileen M. Uchitelle 提交于
Rename event variable
-
由 Ryuta Kamizono 提交于
Remove yarn's files from `.gitignore` template
-
由 bogdanvlviv 提交于
There is no need to remove this file since the line below removes entire directory in which that file is placed.
-
由 Ryuta Kamizono 提交于
Merge pull request #34277 from bogdanvlviv/remove-javascripts-javascripts_engine-options-for-generators Remove `javascripts` and `javascript_engine` options for generators
-
由 Ryuta Kamizono 提交于
Remove `:javascript` from `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`
-
由 bogdanvlviv 提交于
It is unused since #33079
-
由 bogdanvlviv 提交于
`--javascript` option was removed by 42198064
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Webpacker already does it, see https://github.com/rails/webpacker/blob/895d2cfc15eda2edae9e667c642a02523d958f53/lib/install/template.rb#L25-L33 I also opened PR https://github.com/rails/webpacker/pull/1765 in order to make it add `/yarn-error.log` file too.
-
由 Bogdan 提交于
* Fix assertions of auto-generated ActiveStorage JS Since #33079 * Correct message on the `assert_equal` failure Related to #33079 * Test ActionCable's js files This commit adds `app/javascript/channels/consumer.js`, and `app/javascript/channels/index.js` to `DEFAULT_APP_FILES` in order to assert their existance in `test_skeleton_is_created`. Related to #33079 * Assert no match `javascript_pack_tag` in `application.html.erb` Since #33079 `rails new` generates `application.html.erb` file with `javascript_pack_tag` instead of `javascript_include_tag`. Note that there some tests that asserting no matching `javascript_include_tag` in the `application.html.erb` file for newly generated rails plugins. It is related to #34009 and shouldn't be changed right now.
-
由 Ryuta Kamizono 提交于
Reduce string allocations in read/write_attribute
-
- 21 10月, 2018 6 次提交
-
-
由 Alberto Almagro 提交于
Improve variable naming by renaming from `e` to `event`. The arguments to rename this are: * The naming `e` is usually a convention used for exceptions. * No other method in this class uses the naming `e`. All other methods are using `event`.
-
由 Eugene Kenny 提交于
When `attr_name` is passed as a symbol, it's currently converted to a string by `attribute_alias?`, and potentially also `attribute_alias`, as well as by the `read_attribute`/`write_attribute` method itself. By converting `attr_name` to a string up front, the extra allocations related to attribute aliases can be avoided.
-
由 Ryuta Kamizono 提交于
Add message to exception in datetime type
-
由 wilddima 提交于
-
由 Francesco Rodríguez 提交于
-
由 Jeremy Daer 提交于
Improve layout of Rails Guides index
-
- 20 10月, 2018 1 次提交
-
-
由 Ryuta Kamizono 提交于
Since #29294, `mattr_acessor` uses kwargs for `instance_reader`, `instance_writer`, and `instance_accessor` options. `thread_mattr_accessor` and `config_accessor` also take the same options, so let's maintain these options handles the same.
-