- 20 3月, 2015 11 次提交
-
-
由 eileencodes 提交于
ActionDispatch::IntegrationTest HTTP request methods will accept only certain kwargs in the future. This test caused a deprecation warning when running ActionPack tests. Added `params` and `headers` to fix.
-
由 eileencodes 提交于
Removing `#build_original_fullpath` because it is no longer used by the Rails' source code or called in the `#call` method becasue the previous commit now uses `fullpath` from Rack. The method was nodoc'ed so it's safe to remove. NOTE: I did this as a separate commit so if this does cause a problem with engines etc reverting is easy.
-
由 eileencodes 提交于
In Rack, `#fullpath` checks if there is a query string and builds the query correctly: ``` def path script_name + path_info end def fullpath query_string.empty? ? path : "#{path}?#{query_string}" end ``` We can utilize this instead of manually building the fullpath because they are the same result. This also reduces allocations in `#call` because we don't need `build_original_fullpath` to create the paths and query strings. We don't need to build `fullpath` twice.
-
由 Akira Matsuda 提交于
-
由 Rafael Mendonça França 提交于
[Fix Select tag Tests] Test correct use of multiple option for select tag
-
由 Akshay Vishnoi 提交于
-
由 Rafael Mendonça França 提交于
Fix test messages use directly true, false and nil instead of their symbol
-
由 Akshay Vishnoi 提交于
-
由 Sean Griffin 提交于
Fixes #19389.
-
由 Rafael Mendonça França 提交于
Updated MySQL documentation link to MySQL latest version 5.6 everywhere ...
-
由 amitkumarsuroliya 提交于
-
- 19 3月, 2015 27 次提交
-
-
由 Sean Griffin 提交于
Updated MySQL documentation link to latest version MySQL 5.6 [ci skip]
-
由 Sean Griffin 提交于
add foreign_key option to result of references column type [ci skip]
-
由 Arthur Nogueira Neves 提交于
Changelog entry for removal of RACK_ENV fallback
-
由 Damien Mathieu 提交于
[ci skip]
-
由 amitkumarsuroliya 提交于
-
由 Yves Senn 提交于
Updated MySQL documentation link for STRICT_ALL_TABLES [ci skip]
-
由 amitkumarsuroliya 提交于
-
由 Aaron Patterson 提交于
Don't fallback to RACK_ENV when RAILS_ENV is not present
-
由 yuuji.yaginuma 提交于
-
由 Arthur Neves 提交于
3 commits were missing when we merged the PR, probably they were lost when that branch was rebased against latest master. This merge, contains those 3 commits.
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
bundle exec db:migrate rake was not working, with the new runner, before this commit
-
由 Arthur Neves 提交于
-
由 Yves Senn 提交于
`bin/rails test` runner (rerun snippets, run tests by line, option documentation)
-
由 Arthur Nogueira Neves 提交于
Add a new-line to the end of route method generated code.
-
由 Yves Senn 提交于
ActiveRecord: Add a changelog entry for issue #17680. [ci skip] Conflicts: activerecord/CHANGELOG.md
-
由 Damien Mathieu 提交于
-
由 Yves Senn 提交于
Active Record changelog pass [skip ci]
-
由 Abdelkader Boudih 提交于
[ci skip] use true as value rather than symbol
-
由 Kasper Timm Hansen 提交于
[skip ci] Fixed typo in asset pipeline documentation
-
由 Akshay Vishnoi 提交于
-
由 Jon Atack 提交于
-
由 James 提交于
-
由 Claudio B. 提交于
[ci skip] use false as value rather than symbol
-
由 Akshay Vishnoi 提交于
-
由 Yves Senn 提交于
Change commands in the Getting Started guide to use scripts in bin/ [ci skip]
-
由 Dimiter Petrov 提交于
[ci skip]
-
- 18 3月, 2015 2 次提交
-
-
由 Arthur Neves 提交于
Fix regression on route method that was added by bac812a7. The regression was that when calling the `route` method, we were not appending a \n anymore. [fixes #19316]
-
由 eileencodes 提交于
This is a better test for 51660f01. It is testing that the SQL is the same before and after the previously leaky scope is called. Before if `hotel.drink_designers` was called first then `hotel.recipes` would incorrectly get the scope applied. We want to be sure that the polymorphic hm:t association is not leaking into or affecting the SQL for the hm:t association on `Hotel`. The reason I couldn't do this before was because there was an issue with the SQL getting cached and wanted to resolve that later and then fix the test to be better. Because of the caching, this test requires that `Hotel.reflect_on_association(:recipes).clear_association_scope_cache` be called after the first call to `hotel.recipes` to clear the assocation scope chain and not interfere with the rest of the test.
-