- 07 2月, 2017 15 次提交
-
-
由 Jeremy Daer 提交于
Revert "Remove useless `column_alias` in `subquery_for_count`"
-
由 Ryuta Kamizono 提交于
This reverts commit 28977f1f.
-
由 Jeremy Daer 提交于
`primary_key` and `references` columns should be identical type
-
由 Jeremy Daer 提交于
Move some ActionCable logs to debug level
-
由 Jeremy Daer 提交于
Decouple the building Arel ASTs for uniqueness validator
-
由 Ryuta Kamizono 提交于
If select clause is specified and last column has a column alias, additional column alias causes a statement invalid. Add test coverage for counting a single column with NULL values. Fixes #27676, #27682, and #27705.
-
由 Ryuta Kamizono 提交于
Follow up to #26266. The default type of `primary_key` and `references` were changed to `bigint` since #26266. But legacy migration and sqlite3 adapter should keep its previous behavior.
-
由 Jeremy Daer 提交于
Restore the behaviour of the compatibility layer for integer-like PKs * kamipo/fix_mysql_pk_dumping_correctly: Restore custom primary key tests lost at #26266 Restore the behaviour of the compatibility layer for integer-like PKs Correctly dump integer-like primary key with default nil
-
由 Jeremy Daer 提交于
Deprecate `ColumnDumper#migration_keys`
-
由 Jeremy Daer 提交于
Remove superfluous `MySQL::Column` tests
-
由 Ryuta Kamizono 提交于
`ColumnDumper#migration_keys` was extracted to customize keys for standardized column arguments widths. But the feature was removed in df84e986. The internal method is no longer used for that.
-
由 Ryuta Kamizono 提交于
Since text default treated as an empty string in non-strict mode has been removed in #26154, `MySQL::Column` behaves like any other column. Also, The difference between strict and non-strict mode is covered by `test_mysql_not_null_defaults_strict` and `test_mysql_not_null_defaults_non_strict`.
-
由 Rafael França 提交于
Remove `ActiveModel::TestCase` from lib
-
由 yuuji.yaginuma 提交于
`ActiveModel::TestCase` is used only for the test of Active Model. Also, it is a private API and can not be used in applications. Therefore, it is not necessary to include it in lib.
-
由 Arthur Nogueira Neves 提交于
Correct spelling
-
- 06 2月, 2017 8 次提交
-
-
由 Rafael França 提交于
Add test for DateTime#blank?
-
由 kenta-s 提交于
-
由 Martijn Storck 提交于
-
由 Kasper Timm Hansen 提交于
Indicate action that failed in YamlColumn
-
由 Benjamin Fleischer 提交于
``` go get -u github.com/client9/misspell/cmd/misspell misspell -w -error -source=text . ```
-
由 Kir Shatrov 提交于
-
由 Kasper Timm Hansen 提交于
Add `:args` to `process.action_mailer` event.
-
由 Kasper Timm Hansen 提交于
Collect all file patterns when running multiple rake test tasks
-
- 04 2月, 2017 9 次提交
-
-
由 Eileen M. Uchitelle 提交于
Docs: Correction: Module::DelegationError
-
由 Dominic Cleal 提交于
Replaces the rake_patterns instance variable with simple require, as `autorun` will run tests from all eagerly required test files. Fixes #27801
-
由 Ryuta Kamizono 提交于
Some custom primary key tests (added at #17631, #17696, #18220, #18228) were lost at #26266. Restore the tests to improve test coverage.
-
由 Ryuta Kamizono 提交于
The PR #27384 changed migration compatibility behaviour. ```ruby class CreateMasterData < ActiveRecord::Migration[5.0] def change create_table :master_data, id: :integer do |t| t.string :name end end end ``` Previously this migration created non-autoincremental primary key expected. But after the PR, the primary key changed to autoincremental, it is unexpected. This change restores the behaviour of the compatibility layer.
-
由 Ryuta Kamizono 提交于
The PR #27384 changed integer-like primary key to be autoincrement unless an explicit default. This means that integer-like primary key is restored as autoincrement unless dumping the default nil explicitly. We should dump integer-like primary key with default nil correctly.
-
由 yuuji.yaginuma 提交于
-
由 Jared Beck 提交于
When the delegation target is nil and the allow_nil option is not in use, a Module::DelegationError is raised. class C delegate :a, to: :b def b nil end end C.new.a # => Module::DelegationError: C#a delegated to b.a, but b is nil [ci skip]
-
由 Eileen M. Uchitelle 提交于
Fix typo in guide: _articles should be _article
-
由 Matthew Eagar 提交于
The guide contains a typo in the "local_assigns" section, where rendering a model named 'Article' via `render @articles` is shown to render a partial called `_articles.html.erb`, when in fact the necessary partial name is `_article.html.erb`
-
- 03 2月, 2017 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix collection_singular_ids= bug
-
由 Eileen M. Uchitelle 提交于
Fix a test of AR::Type::TypeMap#lookup when using Oracle
-
由 Eileen M. Uchitelle 提交于
Ignore yarn error log file
-
由 Daniel Colson 提交于
When the association's primary key is manually set as a symbol and called with an array of strings, CollectionAssociation#ids_writer fails to cast the ids to integers. This is because AssociationReflection#association_primary_key_type and ThroughReflection#association_primary_key_type return the incorrect type, since ModelSchema.type_for_attribute only accepts a string. The result is an ActiveRecord::RecordNotFound error.
-
由 yuuji.yaginuma 提交于
-
由 Kasper Timm Hansen 提交于
generate mailer layout files only when it does not exist
-
- 02 2月, 2017 2 次提交
-
-
由 Akira Matsuda 提交于
Fix CI failure caused by aa647b46
-
由 Ryuta Kamizono 提交于
-